From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA4FC433DB for ; Fri, 15 Jan 2021 10:37:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D579B23877 for ; Fri, 15 Jan 2021 10:37:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D579B23877 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fp13KIv5s+H97pkFmFMz8Zo+YsHxYghHvD1vPf9qOWM=; b=B4FEKw4M3uXZIIiRblqDIDOMh Nc6KYL/XFdNbolmXbe6mjvLt3no1k4gg3EtoZ5ni7tIwpyZD+1Ogvpnqcb9AzOzw9NoXRok274UN5 FRE65b/b+zBoa+xUrsGPiB7KJDYT3iIS3Dh5Cpejqt9TB9nWtVaTHLyKygs6U6U+eTu2wOot/wbz9 XmLpxSfYB4Ny4wj1gdBxLcVoGENciwyQBRpdzjQ/5FdfXf9yy9eLr6fGFlLQm5y3JrzYwxS/Nm89W u98aoDGQMrimJIprmmtIvEHeFNDm484Ztz7zOsyA7gogDCyR/W8YD7mcq3fmkkcnOBDGR/0cFWyhu wK799w1rw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0MSB-0003Pi-E6; Fri, 15 Jan 2021 10:35:39 +0000 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0MS8-0003P6-4E; Fri, 15 Jan 2021 10:35:37 +0000 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10FAWmHZ026898; Fri, 15 Jan 2021 04:35:26 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=LD+LiuwpWXTb1D5hCBKo7VpoiE2Ui0ocmHD3tcAefJc=; b=pVCP/0Kn6scEb6JF03auF0HVcxZ9dSUIjyQQz6HD/fCr/4xaiVxvqTeaykXMpo3s3K2d 2dyCsSW3bEqQk3X9CzSqLpY+vIrLVkBsmw478dK/88QrPfD+jb47NAi6YTzJeJwdqQJt Xcwn24q1DOHffZPUsmrBsofU/tkmRfh8laM5pUWaHIpijNu2sUm7ehcXkBEgaejrB0eD hmCdIobPSkr1lZDFJbJUIviVrrTXKIWxVki2K8JiMhJhLHrx6rPhwwMNQBnEgf+xro76 F1Ljzl8rCIYk5+n7wBvDeDBT5uvfCzUtT/ExL4no1LBG99CtrkCQu07QjsAQi4Hne6O0 ow== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 35y9sryh9u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 15 Jan 2021 04:35:25 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 15 Jan 2021 10:35:23 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Fri, 15 Jan 2021 10:35:23 +0000 Received: from [10.0.2.15] (AUSNPC0LSNW1.ad.cirrus.com [198.61.64.57]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 6A48445; Fri, 15 Jan 2021 10:35:23 +0000 (UTC) Subject: Re: [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties To: Mark Brown , Rob Herring References: <20210108160501.7638-1-rf@opensource.cirrus.com> <20210108160501.7638-3-rf@opensource.cirrus.com> <20210113152225.GA2334778@robh.at.kernel.org> <20210113160917.GF4641@sirena.org.uk> From: Richard Fitzgerald Message-ID: Date: Fri, 15 Jan 2021 10:35:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210113160917.GF4641@sirena.org.uk> Content-Language: en-US X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 priorityscore=1501 phishscore=0 spamscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101150063 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210115_053536_556295_A813E1B3 X-CRM114-Status: GOOD ( 23.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, f.fainelli@gmail.com, kuninori.morimoto.gx@renesas.com, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, nsaenzjulienne@suse.de Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/01/2021 16:09, Mark Brown wrote: > On Wed, Jan 13, 2021 at 09:22:25AM -0600, Rob Herring wrote: > >> I'm not sure this makes sense to be generic, but if so, we already have >> the clock binding and should use (and possibly extend) that. > >> This appears to all be configuration of clocks within the codec, so >> these properties belong in the codec or cpu nodes. > > Right, I think this should just be the clock binding. > Ok, so if the idea is to do this: sound { clocks = <&audio_mclk>, <&pll>; clock-names = "mclk", "pll"; } some_codec { pll: pll { compatible = "fixed-clock"; clocks = <&audio_mclk>; clock-frequency = <98304000>; } }; For this to work the clock binding must be a real clock object (so needs a valid compatible=). But I need to somehow specify the PLL ID and source pin for the PLL configuration. The schema for "fixed-clock" has "additionalProperties: false" so I can't add extra custom properties to the clock node. Of course if we were able to use the clock framework to provide real clock drivers for the plls and sysclks, the ID would be inherent in the binding, and it can define a custom property for the source pin. Some options: 1) Remove "additionalProperties: false" from the "fixed-clock" binding. 2) Add new core clock properties. Well, source-pin might legitimately be meaningful, but for a real clock provider the clock ID is implicit. 3) Use 'reg' as fixed-clock doesn't use it. This works, but I suspect it will be seen as an abuse of reg. 4) Put some extra properties in the sound node to define the pair for each clock. But that's clumsy to have some of the config in a clock binding and a couple of extra elsewhere. 5) Use a bare clock binding that isn't a real clock provider, like: sound { plls = <&pll>; } some_codec { pll: pll { reg = <1>; /* PLL ID */ audio-graph-card,source-pin = <4>; clocks = <&audio_mclk>; clock-frequency = <98304000>; } }; >>> + The PLL id and clock source id are specific to the particular component >>> + so see the relevant component driver for the ids. Typically the > > This should refer to the bindings for components, not to their drivers. > >>> + clock source id indicates the pin the source clock is connected to. >>> + The same phandle can appear in multiple entries so that several plls >>> + can be set in the same component. >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + >>> + plls-clocks: >>> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array >>> + description: | >>> + A list of clock names giving the source clock for each setting >>> + in the plls property. >>> + >>> + sysclks: >>> + description: | >>> + A list of component sysclk settings. There are 4 cells per sysclk >>> + setting: >>> + - phandle to the node of the codec or cpu component, >>> + - component sysclk id, >>> + - component clock source id, >>> + - direction of the clock: 0 if the clock is an input to the component, >>> + 1 if it is an output. >> >> A clock provider and consumer would provide the direction. >> >>> + The sysclk id and clock source id are specific to the particular >>> + component so see the relevant component driver for the ids. Typically >>> + the clock source id indicates the pin the source clock is connected to. >>> + The same phandle can appear in multiple entries so that several sysclks >>> + can be set in the same component. >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + >>> + sysclks-clocks: >>> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array >>> + description: | >>> + A list of clock names giving the source clock for each setting >>> + in the sysclks property. >>> + >>> +dependencies: >>> + plls: [ plls-clocks ] >>> + sysclks: [ sysclks-clocks ] >>> + >>> required: >>> - dais >>> >>> -- >>> 2.20.1 >>> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel