From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC88C12002 for ; Wed, 14 Jul 2021 23:29:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F5166100A for ; Wed, 14 Jul 2021 23:29:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F5166100A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=dh-electronics.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kHfZeIz5Ftw24LWMC3D/CjFti1Ne7ZbbtuBIIJL/b8s=; b=2csaeq/NRJaLGE YRM+3+/LM87e/REMHhGIg/LMyqUnNKVDJQtZa5mj3yPCPvEnLfjrO6EH5VE+hRdlgcuSTXFoM0wMx Ebu+4WQiKi8UKINVYogXG7Ujc3WtmnAsaQpnd99XiTtCZ1AFbNw4gouj2riq7hV6hh57Px3S+Uvdl 2UWDf73FtTkQT85bw1yFH0leeR9NAjrDWWtHnJZm/uL2tiw/Hb/lPYzQHj03sPerJ4RYhwQg2l3rT vbMoCulT7jlIeydpm/nnFKKD4VB1Qu2Z/JUbHHqp9yLnRvIAH05s1Hx5lm9GHECkPKfzqXdkhBMFv rLSpHpSqqI4xi2GrvSIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3oHU-00GH9b-5F; Wed, 14 Jul 2021 23:27:12 +0000 Received: from mx2.securetransport.de ([2a03:4000:13:6c7::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3lHD-00EtcZ-QS for linux-arm-kernel@lists.infradead.org; Wed, 14 Jul 2021 20:14:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1626293633; bh=u62i/JJ2Q5UmQ3ZJBwRVwxZWz6ZFbq47acPIhISaOXo=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=gJndAW0ATYOgVEHCjqrhgUgd0wcOXImfnb4/g6vtdW4yX4QvMvFeHeV4lleNqcmzR gLfYzbpNvCTDlbkxoY6nGpHPS1vZsMWEcGBQ8Gcboux6q7LGdPbJ338aAmnP9jd29O ufkLbZxctLAC4Ldu+3h0NCVCfwzU9Umgx5aSBT4bcujo/X5kCBfMm17jTsE/V6VfCJ 97ZJ2GV343/QJZjyBc249SY4rKWXvP0BOXtPaZClzXHQ7xxvXWnSt5hg0NF85B1VDa 5vO1zXjqGuv8Y1o5/D9oiKugVDdSYqRKuQ0r9nRgwmvaF5aWUjsS/+wDeC40JJdC7s zI1NuJTbpSgWw== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Shawn Guo CC: "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , kernel , "festevam@gmail.com" , "Marek MV. Vasut" Subject: RE: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards Thread-Topic: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards Thread-Index: AQHXUXKxVloH3v/6CkGMRLXBETQyyKsBDI+AgBWQzrD//+TigIAicn3wgAj1bYCAAUtcoA== Date: Wed, 14 Jul 2021 20:13:41 +0000 Message-ID: References: <20210525143001.9298-1-cniedermaier@dh-electronics.com> <20210602195009.GA3870858@robh.at.kernel.org> <76d6cc846f4f473083e597303956ff11@dh-electronics.com> <20210714022354.GA31370@dragon> In-Reply-To: <20210714022354.GA31370@dragon> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_131440_277707_D7FF41EB X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Shawn Guo [mailto:shawnguo@kernel.org] Sent: Wednesday, July 14, 2021 4:24 AM > On Thu, Jul 08, 2021 at 07:38:44AM +0000, Christoph Niedermaier wrote: >> From: Marek Vasut [mailto:marex@denx.de] >> Sent: Wednesday, June 16, 2021 1:33 PM >> >> >>> On 6/16/21 1:19 PM, Christoph Niedermaier wrote: >>>> Send reply also to Rob Herrings +dt email address: >>>> >>>> From: Rob Herring >>>> Sent: Wednesday, June 2, 2021 9:50 PM >>>> >>>>> On Tue, May 25, 2021 at 04:30:01PM +0200, Christoph Niedermaier wrote: >>>>>> Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. >>>>>> >>>>>> Signed-off-by: Christoph Niedermaier >>>>>> Cc: linux-arm-kernel@lists.infradead.org >>>>>> Cc: linux-kernel@vger.kernel.org >>>>>> Cc: robh+dt@kernel.org >>>>>> Cc: Shawn Guo >>>>>> Cc: kernel@dh-electronics.com >>>>>> To: devicetree@vger.kernel.org >>>>>> --- >>>>>> V2: Remove line with fsl,imx6s on the DRC02 Board >>>>>> --- >>>>>> Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ >>>>>> 1 file changed, 12 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>>>>> index fce2a8670b49..3c4ff79a3be7 100644 >>>>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>>>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>>>>> @@ -407,6 +407,12 @@ properties: >>>>>> - const: dfi,fs700e-m60 >>>>>> - const: fsl,imx6dl >>>>>> >>>>>> + - description: i.MX6DL DHCOM PicoITX Board >>>>>> + items: >>>>>> + - const: dh,imx6dl-dhcom-picoitx >>>>>> + - const: dh,imx6dl-dhcom-som >>>>>> + - const: fsl,imx6dl >>>>>> + >>>>>> - description: i.MX6DL Gateworks Ventana Boards >>>>>> items: >>>>>> - enum: >>>>>> @@ -458,6 +464,12 @@ properties: >>>>>> - const: toradex,colibri_imx6dl # Colibri iMX6 Module >>>>>> - const: fsl,imx6dl >>>>>> >>>>>> + - description: i.MX6S DHCOM DRC02 Board >>>>>> + items: >>>>>> + - const: dh,imx6s-dhcom-drc02 >>>>>> + - const: dh,imx6s-dhcom-som >>>>>> + - const: fsl,imx6dl >>>>> >>>>> fsl,imx6s? >>>> >>>> In the first version I had here an additional line with "fsl,imx6s", >>>> but currently the kernel isn't supporting that compatible. The i.MX6 >>>> Solo is currently supported by "fsl,imx6dl". So my idea was to add >>>> both "fsl,imx6dl" and "fsl,imx6s" to match it maybe on a later kernel >>>> version. If there is no match with the Solo now, it will fall back to >>>> the i.MX6 DualLite. That is why I had both fsl,imx6s and fsl,imx6dl >>>> in that order. On Fabio's advice, I removed the line with "fsl,imx6s" >>>> in version 2. >>>> Is this what you meant by your comment? >>> >>> I didn't notice that at first myself, but I think what Rob means is >>> >>> - const: dh,imx6s-dhcom-drc02 >>> - const: dh,imx6s-dhcom-som >>> - const: fsl,imx6dl <------ this should be consistent with the two above >>> >>> that is >>> >>> - const: dh,imx6s-dhcom-drc02 >>> - const: dh,imx6s-dhcom-som >>> -- const: fsl,imx6dl >>> +- const: fsl,imx6s >>> ^^^^^ >>> >>> But that is a bit odd here: >>> - The MX6S is MX6DL with one CPU core disabled. >>> - The DRC02 device can only house a SOM with MX6S and NOT with MX6DL >>> (due to some thermal design consideration or something). >>> - The kernel discerns the MX6S/MX6DL automatically based on the number >>> of cores it reads from some register, therefore it only has the >>> fsl,mx6dl compatible to cover both MX6S and MX6DL. >>> So, the closest fallback compatible for this device really is the MX6DL, >>> i.e. fsl,imx6dl. >>> >>> So I think this patch is correct as-is, no ? >> >> Is this Patch OK? > > Can we explain that fsl,imx6s thing a bit with some comments or commit > log? > > Shawn I will send a version 3. Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel