From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC211C433DB for ; Wed, 17 Feb 2021 20:19:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64BC964E5F for ; Wed, 17 Feb 2021 20:19:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64BC964E5F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=phytec.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+QiN04Yylj5rSRbXLevtDui04V/DI34hQ+gwVteS5o8=; b=2IjH5K7GYnosqZkLstlkTER8h j34BPUkDjEEDKPBpfClR0t+EgL5fGKsI8teECLsVHCH+eDnuupU3HCt6g7Ucy5uiQDU+xerU0Y8eZ OURSGAuxwT8X6l+tJFdf0uIdvXXryPjHZnePQdhL+JmzUVU98EqqHUGV3W/5r/21adHA55sFmT+Nx 9OSJA30WXfNuK0Kyhi/7sVqwHF+N9DK+xKDV991zE+GtY2LkeukcymNXlmhCXMvIqky2L1lhakHcw 168q0Ith+pY+6YiR/2/5vjjuDEDMzu3Q2O4uuMMMw3HpWySBrpjZUrdKzr0j37FzJK3pbjKqBfhC1 ARQsqPMuQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCTGe-0008UC-Sv; Wed, 17 Feb 2021 20:17:48 +0000 Received: from mickerik.phytec.de ([195.145.39.210]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCTGb-0008Sv-VE for linux-arm-kernel@lists.infradead.org; Wed, 17 Feb 2021 20:17:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=phytec.de; s=a1; c=relaxed/simple; q=dns/txt; i=@phytec.de; t=1613593061; x=1616185061; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OklyI6wK+3D+WAYCJCCip37BFLD19qPKmpKHrfnzJBE=; b=Z7KYhbmKHeBRCrX6F8c7j1ncXNVteAvUSMjNbrcQoRYhuWSf4b2W9xYjflDj6oFj GkprBj/XXOeqmg2TxxIME/w4QJRhV+5AwoH8GsX5yJtBTDYd+nPm6xWfM0mPvE+j MQPQIPy6w+SEDoX55wRLdHn9lD8a78XAsrsN2ff1xeU=; X-AuditID: c39127d2-0c7b670000001c86-de-602d79e59461 Received: from Florix.phytec.de (florix.phytec.de [172.16.0.118]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mickerik.phytec.de (PHYTEC Mail Gateway) with SMTP id 62.ED.07302.5E97D206; Wed, 17 Feb 2021 21:17:41 +0100 (CET) Received: from Berlix.phytec.de (172.16.0.117) by Florix.phytec.de (172.16.0.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Wed, 17 Feb 2021 21:17:41 +0100 Received: from Berlix.phytec.de ([fe80::6dc0:81aa:52a5:106a]) by Berlix.phytec.de ([fe80::6dc0:81aa:52a5:106a%6]) with mapi id 15.01.1779.004; Wed, 17 Feb 2021 21:17:41 +0100 From: Teresa Remmet To: "linux-arm-kernel@lists.infradead.org" , "marex@denx.de" Subject: Re: [PATCH 2/2] arm64: dts: freescale: Add support EQOS MAC on phyBOARD-Pollux-i.MX8MP Thread-Topic: [PATCH 2/2] arm64: dts: freescale: Add support EQOS MAC on phyBOARD-Pollux-i.MX8MP Thread-Index: AQHXBEeA3WLYpZ91b0qJJybaxa+gGKpcuo8A Date: Wed, 17 Feb 2021 20:17:40 +0000 Message-ID: References: <20210216093825.61154-1-marex@denx.de> <20210216093825.61154-2-marex@denx.de> In-Reply-To: <20210216093825.61154-2-marex@denx.de> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.0.116] Content-ID: <7248D5C8A5BD834BA92CF149BB2355F6@phytec.de> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsWyRoChTPdppW6Cwc4mRYsvU3cxW+y4c5/Z YtPja6wWXb9WMlu8aWtktPix6gurxYst4g7sHvNmnWDx2LSqk81j85J6j43vdjAFsERx2aSk 5mSWpRbp2yVwZZz6epSx4IlCxaGf51kaGH/IdzFyckgImEgsWX2CuYuRi0NIYBmTRNO6OVDO Q0aJhw/eM0I4mxglzu9qZgZpYRPQkHh5opsJxBYRKJH4sLmdDaSIWeAso0TjzCdADgeHsECi xKt3LCCmiECSxKOFuhDlRhL7NveBtbIIqErcPXeKDcTmFXCTePnoLSuILSQQI3Gq8SPYKk4B Y4n7d/vB6hkFZCU2bDgPFmcWEJfY9Ow7K8QHAhJL9kDEJQREJV4+/gcVV5Bo6+lkAjmBWUBT Yv0ufYhWC4kXs3pZIGxFiSndD9khThCUODnzCcsERvFZSDbMQuiehaR7FpLuWUi6FzCyrmIU ys1Mzk4tyszWK8ioLElN1ktJ3cQIjNTDE9Uv7WDsm+NxiJGJg/EQowQHs5IIL/tnrQQh3pTE yqrUovz4otKc1OJDjNIcLErivBt4S8KEBNITS1KzU1MLUotgskwcnFINjKvn7z7U/P7EtLJH tTt+FP+9OsMutkU88dajSww3bA/InttxIppNePPPi7eDDUwPJ/WfEGLp3nFh3SlL3qqezUbG 12626F+c7KTD+JbR3baLf4rWcvvDHqfnMez6lXY8btLUv+G+p/Tst5mIf9pkslxxpQNv8CHv dN8EbZPdDYsKpY9f/LhHP1OJpTgj0VCLuag4EQBatSs6wgIAAA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210217_151746_250089_79F19917 X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "aisheng.dong@nxp.com" , "peng.fan@nxp.com" , "hs@denx.de" , "shawnguo@kernel.org" , "linux-imx@nxp.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Marek, Am Dienstag, den 16.02.2021, 10:38 +0100 schrieb Marek Vasut: > The board has both MACs routed out, enable the EQOS. > > Signed-off-by: Marek Vasut > Cc: Dong Aisheng > Cc: Heiko Schocher > Cc: NXP Linux Team > Cc: Peng Fan > Cc: Shawn Guo > Cc: Teresa Remmet > --- > .../dts/freescale/imx8mp-phycore-som.dtsi | 44 > +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi > b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi > index 44a8c2337cee4..526197b6972c3 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi > @@ -38,6 +38,30 @@ > cpu-supply = <&buck2>; > }; > > +&eqos { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_eqos>; > + phy-mode = "rgmii-id"; > + phy-handle = <ðphy0>; > + status = "okay"; > + > + mdio { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy0: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <0x1>; > + ti,rx-internal-delay = > ; > + ti,tx-internal-delay = > ; > + ti,fifo-depth = > ; > + ti,clk-output-sel = ; > + enet-phy-lane-no-swap; > + }; > + }; > +}; I would prefer having this added to imx8mp-phyboard-pollux-rdk.dts. The phy of eqos is populated on the carrier board and not on the SoM. Boards using the same SoM should not need to patch in the imx8mp-phycore-som.dtsi to make it fit for their selected phy. Thanks! Regards, Teresa > + > /* ethernet 1 */ > &fec { > pinctrl-names = "default"; > @@ -197,6 +221,26 @@ > }; > > &iomuxc { > + pinctrl_eqos: eqosgrp { > + fsl,pins = < > + MX8MP_IOMUXC_ENET_MDC__ENET_QOS_MDC > 0x3 > + MX8MP_IOMUXC_ENET_MDIO__ENET_QOS_MDIO > 0x3 > + MX8MP_IOMUXC_ENET_RD0__ENET_QOS_RGMII_RD0 > 0x91 > + MX8MP_IOMUXC_ENET_RD1__ENET_QOS_RGMII_RD1 > 0x91 > + MX8MP_IOMUXC_ENET_RD2__ENET_QOS_RGMII_RD2 > 0x91 > + MX8MP_IOMUXC_ENET_RD3__ENET_QOS_RGMII_RD3 > 0x91 > + MX8MP_IOMUXC_ENET_RXC__CCM_ENET_QOS_CLOCK_GENER > ATE_RX_CLK 0x91 > + MX8MP_IOMUXC_ENET_RX_CTL__ENET_QOS_RGMII_RX_CTL > 0x91 > + MX8MP_IOMUXC_ENET_TD0__ENET_QOS_RGMII_TD0 > 0x1f > + MX8MP_IOMUXC_ENET_TD1__ENET_QOS_RGMII_TD1 > 0x1f > + MX8MP_IOMUXC_ENET_TD2__ENET_QOS_RGMII_TD2 > 0x1f > + MX8MP_IOMUXC_ENET_TD3__ENET_QOS_RGMII_TD3 > 0x1f > + MX8MP_IOMUXC_ENET_TX_CTL__ENET_QOS_RGMII_TX_CTL > 0x1f > + MX8MP_IOMUXC_ENET_TXC__CCM_ENET_QOS_CLOCK_GENER > ATE_TX_CLK 0x1f > + MX8MP_IOMUXC_SAI1_MCLK__GPIO4_IO20 > 0x10 > + >; > + }; > + > pinctrl_fec: fecgrp { > fsl,pins = < > MX8MP_IOMUXC_SAI1_RXD2__ENET1_MDC 0x3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel