From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3028C433E2 for ; Thu, 3 Sep 2020 05:08:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BD2D2065E for ; Thu, 3 Sep 2020 05:08:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PIp681k2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fyhEhW+i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BD2D2065E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GDw1skGiigYps9dlXzysQL3sDP0ioZHYy/jajCusWrk=; b=PIp681k2yHPFyD m9teMzbhCfTOuXRqp1k2p6KAthWgLjVWviJGe75hltFVEDMEp75BF4NQqRjpOmUYIg5CdY3uRMgO2 PcYqAAfAWhYoBcSc00dtCCk+9RdsecKA8FN9MyYHXs8XyKO2JzmbYPlOg4RUflOpJxHdlEAvoDV0U CQ5Au+gu33NoX28YHma89vJicUpgJFbxI+T0G9PKvcjOGpb8k+to/ub0CzE0zgFgBlWiiF2TuKDJj RiTqYA+nUlSflU410ltYoPy2yV6umVPEFyaXcwZukB5TGFm3W650mM3EWQI2qc/BBRhXxsuq7LUkb zGqsICumJ8E8w7ZSzkTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDhT8-000740-CN; Thu, 03 Sep 2020 05:07:30 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDhT6-00073d-U5 for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 05:07:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599109648; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=weMxr7wdefcFu3lhAtUW/ZGVlS24UpPpY8VmtuLKvJ8=; b=fyhEhW+iH+hLdtDk3FzkWqZFRgUHIXVs3xwjoGPZLn0OmBKmZwF95SlwcgccKDz6K7PLD8 g52KvP0OU6D/3THLJrRzY+akBa1+0UqvcxCY22FjanzUU2UxZTzVRSrnMHiI2TdH+mlCtF vafRAaitVuoQs0VE/SY2M0cyR6BjwOk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-71-ZPrdevr5PxiOxM_OaQadqQ-1; Thu, 03 Sep 2020 01:07:23 -0400 X-MC-Unique: ZPrdevr5PxiOxM_OaQadqQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 26D64E75D; Thu, 3 Sep 2020 05:07:22 +0000 (UTC) Received: from [10.64.54.159] (vpn2-54-159.bne.redhat.com [10.64.54.159]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A8AEB77C1B; Thu, 3 Sep 2020 05:07:19 +0000 (UTC) Subject: Re: [PATCH v3 20/21] KVM: arm64: Remove unused 'pgd' field from 'struct kvm_s2_mmu' To: Will Deacon , kvmarm@lists.cs.columbia.edu References: <20200825093953.26493-1-will@kernel.org> <20200825093953.26493-21-will@kernel.org> From: Gavin Shan Message-ID: Date: Thu, 3 Sep 2020 15:07:17 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20200825093953.26493-21-will@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=gshan@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_010729_032741_D2BF8AB6 X-CRM114-Status: GOOD ( 19.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Gavin Shan Cc: Suzuki Poulose , Marc Zyngier , Quentin Perret , James Morse , Catalin Marinas , kernel-team@android.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, On 8/25/20 7:39 PM, Will Deacon wrote: > The stage-2 page-tables are entirely encapsulated by the 'pgt' field of > 'struct kvm_s2_mmu', so remove the unused 'pgd' field. > > Cc: Marc Zyngier > Cc: Quentin Perret > Signed-off-by: Will Deacon > --- > arch/arm64/include/asm/kvm_host.h | 1 - > arch/arm64/kvm/mmu.c | 2 -- > 2 files changed, 3 deletions(-) > I think this might be folded into PATCH[18] as both patches are simple enough. I'm not sure the changes introduced in PATCH[19] prevent us doing this. There is another question below. Reviewed-by: Gavin Shan > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 0b7c702b2151..41caf29bd93c 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -79,7 +79,6 @@ struct kvm_s2_mmu { > * for vEL1/EL0 with vHCR_EL2.VM == 0. In that case, we use the > * canonical stage-2 page tables. > */ > - pgd_t *pgd; > phys_addr_t pgd_phys; > struct kvm_pgtable *pgt; > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index ddeec0b03666..f28e03dcb897 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -384,7 +384,6 @@ int kvm_init_stage2_mmu(struct kvm *kvm, struct kvm_s2_mmu *mmu) > mmu->kvm = kvm; > mmu->pgt = pgt; > mmu->pgd_phys = __pa(pgt->pgd); > - mmu->pgd = (void *)pgt->pgd; > mmu->vmid.vmid_gen = 0; > return 0; > > @@ -470,7 +469,6 @@ void kvm_free_stage2_pgd(struct kvm_s2_mmu *mmu) > spin_lock(&kvm->mmu_lock); > pgt = mmu->pgt; > if (pgt) { > - mmu->pgd = NULL; > mmu->pgd_phys = 0; > mmu->pgt = NULL; > free_percpu(mmu->last_vcpu_ran); > I guess mmu->pgd_phys might be removed either because kvm_get_vttbr() is the only consumer. Thanks, Gavin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel