From: Olivier MOYSAN <olivier.moysan@foss.st.com>
To: Marek Vasut <marex@denx.de>, <linux-arm-kernel@lists.infradead.org>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [Linux-stm32] [PATCH] ARM: dts: stm32: Replace SAI format with dai-format DT property
Date: Tue, 27 Sep 2022 10:35:54 +0200 [thread overview]
Message-ID: <f14a5c06-6bd8-deb6-56e6-35523a23d3de@foss.st.com> (raw)
In-Reply-To: <20220927002023.685128-1-marex@denx.de>
Hi Marek,
Thanks for your patch.
You can add my:
Reviewed-by: Olivier Moysan <olivier.moysan@foss.st.com>
BRs
On 9/27/22 02:20, Marek Vasut wrote:
> The dai-format and format are handled equally by sound-core.c , the
> later is however the only documented property in audio-graph-port.yaml .
> Switch to the later.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi | 4 ++--
> arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi | 2 +-
> arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi
> index 5f586f024060f..4709677151aac 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi
> @@ -242,7 +242,7 @@ sai2a: audio-controller@4400b004 {
> sai2a_port: port {
> sai2a_endpoint: endpoint {
> remote-endpoint = <&sgtl5000_tx_endpoint>;
> - format = "i2s";
> + dai-format = "i2s";
> mclk-fs = <512>;
> dai-tdm-slot-num = <2>;
> dai-tdm-slot-width = <16>;
> @@ -260,7 +260,7 @@ sai2b: audio-controller@4400b024 {
> sai2b_port: port {
> sai2b_endpoint: endpoint {
> remote-endpoint = <&sgtl5000_rx_endpoint>;
> - format = "i2s";
> + dai-format = "i2s";
> mclk-fs = <512>;
> dai-tdm-slot-num = <2>;
> dai-tdm-slot-width = <16>;
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> index aa79ed1cb1f15..50af4a27d6be4 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> @@ -358,7 +358,7 @@ sai2a: audio-controller@4400b004 {
> sai2a_port: port {
> sai2a_endpoint: endpoint {
> remote-endpoint = <&adv7513_i2s0>;
> - format = "i2s";
> + dai-format = "i2s";
> mclk-fs = <256>;
> };
> };
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
> index 6afff983069b6..7798a2e17c5ca 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
> @@ -508,7 +508,7 @@ sai2a: audio-controller@4400b004 {
> sai2a_port: port {
> sai2a_endpoint: endpoint {
> remote-endpoint = <&cs42l51_tx_endpoint>;
> - format = "i2s";
> + dai-format = "i2s";
> mclk-fs = <256>;
> dai-tdm-slot-num = <2>;
> dai-tdm-slot-width = <32>;
> @@ -526,7 +526,7 @@ sai2b: audio-controller@4400b024 {
> sai2b_port: port {
> sai2b_endpoint: endpoint {
> remote-endpoint = <&cs42l51_rx_endpoint>;
> - format = "i2s";
> + dai-format = "i2s";
> mclk-fs = <256>;
> dai-tdm-slot-num = <2>;
> dai-tdm-slot-width = <32>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-27 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 0:20 [PATCH] ARM: dts: stm32: Replace SAI format with dai-format DT property Marek Vasut
2022-09-27 8:35 ` Olivier MOYSAN [this message]
2022-10-20 16:12 ` Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f14a5c06-6bd8-deb6-56e6-35523a23d3de@foss.st.com \
--to=olivier.moysan@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marex@denx.de \
--cc=patrick.delaunay@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).