From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73C4C43331 for ; Fri, 6 Sep 2019 15:19:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A862B214DE for ; Fri, 6 Sep 2019 15:19:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s9TijdGK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A862B214DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:Subject:From:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WIpjS2MnXv8qtYfiOl7qeAjEhWgEUddIcg2T9bKha5Q=; b=s9TijdGKdx3xko rs5MP4YgLFflV6N/UPZqIohTuIgGmvP8pZ1S+i4bbQYVmfsbRy0Q556lTmNk2RrcA+QDeCZBmzHXt ATEOVJS+WkgswNZecCf8dsdNg1kK8z723CzK0g0Os1nJV30youckK4UmKqdzXloQslYqsYnS2rjMf fKcN02OxS7oTytRAwv83qHGvqXP8LhKk/bpaSSNz7NKAsr5ZNwmqVrAkCl4erdP3MdckK+nTy+sI+ b8GgzRZSPL8967JiJQNx4agQix9xPPn3q16pE6PLvHO2juSJvWP/sAznLRocH7vaE3mw9mO7g8a2x NZNFN5vs7c8FcxIPZHXg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6G1Y-0004ZX-Jt; Fri, 06 Sep 2019 15:19:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6G0Y-0003aj-7b; Fri, 06 Sep 2019 15:18:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A95341576; Fri, 6 Sep 2019 08:18:41 -0700 (PDT) Received: from [10.1.196.105] (unknown [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8B82E3F59C; Fri, 6 Sep 2019 08:18:38 -0700 (PDT) From: James Morse Subject: Re: [PATCH v3 07/17] arm64, hibernate: move page handling function to new trans_pgd.c To: Pavel Tatashin References: <20190821183204.23576-1-pasha.tatashin@soleen.com> <20190821183204.23576-8-pasha.tatashin@soleen.com> Message-ID: Date: Fri, 6 Sep 2019 16:18:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190821183204.23576-8-pasha.tatashin@soleen.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190906_081842_559124_F7A462B1 X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sashal@kernel.org, mark.rutland@arm.com, vladimir.murzin@arm.com, corbet@lwn.net, marc.zyngier@arm.com, catalin.marinas@arm.com, bhsharma@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, jmorris@namei.org, linux-mm@kvack.org, ebiederm@xmission.com, matthias.bgg@gmail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pavel, On 21/08/2019 19:31, Pavel Tatashin wrote: > Now, that we abstracted the required functions move them to a new home. > Later, we will generalize these function in order to be useful outside > of hibernation. > diff --git a/arch/arm64/mm/trans_pgd.c b/arch/arm64/mm/trans_pgd.c > new file mode 100644 > index 000000000000..00b62d8640c2 > --- /dev/null > +++ b/arch/arm64/mm/trans_pgd.c > @@ -0,0 +1,211 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +/* > + * Copyright (c) 2019, Microsoft Corporation. > + * Pavel Tatashin Hmmm, while line-count isn't a useful metric: this file contains 41% of the code that was in hibernate.c, but has stripped the substantial copyright-pedigree that the hibernate code had built up over the years. (counting lines identified by 'cloc' as code, not comments or blank) If you are copying or moving a non trivial quantity of code, you need to preserve the copyright. Something like 'Derived from the arm64 hibernate support which has:'.... > + */ > + > +/* > + * Transitional tables are used during system transferring from one world to > + * another: such as during hibernate restore, and kexec reboots. During these > + * phases one cannot rely on page table not being overwritten. I think you need to mention that hibernate and kexec are rewriting memory, and may overwrite the live page tables, therefore ... > + * > + */ > + > +#include > +#include > +#include > +#include #include #include #include > +static void _copy_pte(pte_t *dst_ptep, pte_t *src_ptep, unsigned long addr) > +{ > + pte_t pte = READ_ONCE(*src_ptep); > + > + if (pte_valid(pte)) { > + /* > + * Resume will overwrite areas that may be marked > + * read only (code, rodata). Clear the RDONLY bit from > + * the temporary mappings we use during restore. > + */ > + set_pte(dst_ptep, pte_mkwrite(pte)); > + } else if (debug_pagealloc_enabled() && !pte_none(pte)) { > + /* > + * debug_pagealloc will removed the PTE_VALID bit if > + * the page isn't in use by the resume kernel. It may have > + * been in use by the original kernel, in which case we need > + * to put it back in our copy to do the restore. > + * > + * Before marking this entry valid, check the pfn should > + * be mapped. > + */ > + BUG_ON(!pfn_valid(pte_pfn(pte))); Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel