From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: Shawn Guo <shawnguo@kernel.org>,
Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: mark.rutland@arm.com, robh@kernel.org, kernel@puri.sm,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor
Date: Mon, 23 Dec 2019 09:13:58 +0100 [thread overview]
Message-ID: <f2f1e320-6a9e-a669-c7c0-0402570b1e9a@puri.sm> (raw)
In-Reply-To: <20191223071805.GR11523@dragon>
On 23.12.19 08:18, Shawn Guo wrote:
> On Mon, Dec 16, 2019 at 10:32:15AM +0100, Martin Kepplinger wrote:
>> On 03.12.19 14:03, Martin Kepplinger wrote:
>>> Now that there is driver support, describe the accel and gyro sensor parts
>>> of the LSM9DS1 IMU.
>>>
>>> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
>>> ---
>>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> index 683a11035643..7a92704c53ec 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
>>> @@ -415,6 +415,13 @@
>>> pinctrl-0 = <&pinctrl_i2c3>;
>>> status = "okay";
>>>
>>> + accel_gyro@6a {
>
> We prefer to use hyphen than underscore in node name. Also nodes with
> unit-address should be sorted in the address.
>
> Shawn
thanks a lot for taking a look. resent.
martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-23 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 13:03 [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor Martin Kepplinger
2019-12-10 9:08 ` [PATCH] arm64: dts: imx8mq-librem5-devkit: use correct interrupt for the magnetometer Martin Kepplinger
2019-12-16 9:32 ` [PATCH] arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor Martin Kepplinger
2019-12-23 7:18 ` Shawn Guo
2019-12-23 8:13 ` Martin Kepplinger [this message]
2019-12-16 16:27 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2f1e320-6a9e-a669-c7c0-0402570b1e9a@puri.sm \
--to=martin.kepplinger@puri.sm \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).