From: "liuqi (BA)" <liuqi115@huawei.com>
To: John Garry <john.garry@huawei.com>, <will@kernel.org>,
<mark.rutland@arm.com>, <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<zhangshaokun@hisilicon.com>
Subject: Re: [PATCH v4 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU
Date: Thu, 20 May 2021 11:31:40 +0800 [thread overview]
Message-ID: <f48736a1-a81f-9506-2169-a0f879928270@huawei.com> (raw)
In-Reply-To: <4c0f623b-fd0f-e13d-452a-7d72719ecaf8@huawei.com>
On 2021/5/19 19:40, John Garry wrote:
> On 19/05/2021 10:49, Qi Liu wrote:
>> PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported
>> to sample bandwidth, latency, buffer occupation etc.
>>
>> Each PMU RCiEP device monitors multiple Root Ports, and each RCiEP is
>> registered as a PMU in /sys/bus/event_source/devices, so users can
>> select target PMU, and use filter to do further sets.
>>
>> Filtering options contains:
>> event - select the event.
>> subevent - select the subevent.
>> port - select target Root Ports. Information of Root Ports
>> are shown under sysfs.
>> bdf - select requester_id of target EP device.
>> trig_len - set trigger condition for starting event statistics.
>> trigger_mode - set trigger mode. 0 means starting to statistic when
>> bigger than trigger condition, and 1 means smaller.
>> thr_len - set threshold for statistics.
>> thr_mode - set threshold mode. 0 means count when bigger than
>> threshold, and 1 means smaller.
>>
>> Reviewed-by: John Garry <john.garry@huawei.com>
>> Signed-off-by: Qi Liu <liuqi115@huawei.com>
>
> JFYI, In light of this following series:
> https://lore.kernel.org/linux-arm-kernel/87v97fccq9.ffs@nanos.tec.linutronix.de/
>
>
> At some stage the irq_set_affinity_hint() calls need to be fixed up here
> as well.
Hi John,
Seems irq_set_affinity_hint() need to be replaced by irq_set_affinity().
I'll fix this and send a new version latter.
Thanks,
Qi
>
> Thanks,
> John
>
> .
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-05-20 3:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 9:48 [PATCH v4 0/2] drivers/perf: hisi: Add support for PCIe PMU Qi Liu
2021-05-19 9:49 ` [PATCH v4 1/2] docs: perf: Add description for HiSilicon PCIe PMU driver Qi Liu
2021-05-19 11:44 ` John Garry
2021-05-20 3:22 ` liuqi (BA)
2021-05-19 9:49 ` [PATCH v4 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Qi Liu
2021-05-19 11:40 ` John Garry
2021-05-20 3:31 ` liuqi (BA) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f48736a1-a81f-9506-2169-a0f879928270@huawei.com \
--to=liuqi115@huawei.com \
--cc=bhelgaas@google.com \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).