From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A977C04E87 for ; Tue, 21 May 2019 08:31:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C82A121783 for ; Tue, 21 May 2019 08:31:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eNQOQ0pK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="IfEy8V57" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C82A121783 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=79AvdqLXNUNyHKUxR9gHwOBbgRyhLL0iNDRTE0rkhmA=; b=eNQOQ0pKHCz+Pa +wAUWB1x4z89ryk9mPpLbxf+Xrdrtph6Aa5pg5m06Glord27DXIC1kLZ61NRqFNK8x3a1DWO0SsKU OuZisiXVf7oHu8Ogv3BCHSpGe1yx326lOdwST9XGc1JQh/9l7aNubG4ZGT9WPFNc0JuZFouVIsHzt Cja2hLGdHZjhPcw1BAXrDTvRGRmGUccirUOMeE1Lfm4fYvvf9Q8+1zUCQRsTb9JiKjE240B0a7i8i zZLnjjEBBe9q6XUuB5gEqeKe+uB3oo6uOhgpaF+ZVC58gXaiAE7r0l8w6L7FwuVRjd+qR/FDKeJzQ Om88maNAvRHhjCnWB6tw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT0BB-0008BD-K0; Tue, 21 May 2019 08:31:25 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT0B7-00089a-FU for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2019 08:31:23 +0000 Received: by mail-wm1-x344.google.com with SMTP id 198so1974744wme.3 for ; Tue, 21 May 2019 01:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=rLMkeC7ZDWiCEDicTHIFFXWJRw7Y+FUp1ZFBHZUECXU=; b=IfEy8V578LipWbHiK+656YA9HrusDOf2tatzFFberJxM8l9wvNnqZOv8T26LJznUwy mpiBYnlHFiKRuAIqeN51CAsBCBlvpKxVzlnjX9sQt5zXkbPtNlVcVoAf1/TJm2ys8c9H /gB0RI8aaDUGg2Tu5DSIa2STuICM60Fa9gds8f8HHaIMLvOWq9JG3a2Sh/ScQzzPT0le vjx/xO4q5UFLWuVsrdfjJAXoGTSFm9YXpkOxF/yqeXEGe0p7vyOPdaA6BhtrtIz50VWw +GpZJQsAhVlPSZSvHBv0jr7EerIbSnWgEW3T9rQaNq1rZo8nrFyW+kINsVgj/DAna8jT 32XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=rLMkeC7ZDWiCEDicTHIFFXWJRw7Y+FUp1ZFBHZUECXU=; b=famMNVJnM07a/eCStas+mgInDwpRFDE8jC269llPLlW2As5bbu5vu7ouHfpTudd4Or bD9VyhwFXpIJzwEFxaZhthXqcMrZwT0Y0XFKZ70HCCLKp0KIGiSbqd5WvUA3qFqdN+Le ASO6wZFFx3XEvqdUbsY25GpFQC1qKCBbrBtd2zyKfIQDESznHBMdD2ANYtB8SXIveGbH aXYLIydzNy92Bhgm4RcIAOACJ0XPy+LP5TPppA95lgDxQA1Ot1UTTcWuW35lhaJeeCgA fbSMIT6BThRpk4SmXLW3K3/FYwGtfK1mmUdwkoenyKnrS9sVg+00E0jqTBbLjo6yBhDL 3MrA== X-Gm-Message-State: APjAAAWEO6SpEnyTfji9DnRSbe+ylEfDh/mR76o3kugYVJsphWRF3Avv cqZ5F2ulwU5Hs2eS/+Kyi+rCdwBtVhDQbg== X-Google-Smtp-Source: APXvYqzW/vxXveXXp97Sm//lu9OId1XXCD+8TbOi05FaHmAfbUrFEIWSXyfqRMy9HLFH2Vma+HKO5A== X-Received: by 2002:a1c:7a0d:: with SMTP id v13mr2654747wmc.44.1558427478814; Tue, 21 May 2019 01:31:18 -0700 (PDT) Received: from [10.1.2.12] (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id d9sm25075013wro.26.2019.05.21.01.31.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 May 2019 01:31:18 -0700 (PDT) Subject: Re: [PATCH 3/3] arm64: dts: meson: g12a: Add hwrng node To: Martin Blumenstingl References: <20190520134817.25435-1-narmstrong@baylibre.com> <20190520134817.25435-4-narmstrong@baylibre.com> From: Neil Armstrong Openpgp: preference=signencrypt Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= mQENBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAG0KE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT6JATsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIW5AQ0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAYkBHwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8guQINBFYnf6QBEADQ+wBYa+X2n/xIQz/RUoGHf84Jm+yTqRT43t7sO48/cBW9vAn9 GNwnJ3HRJWKATW0ZXrCr40ES/JqM1fUTfiFDB3VMdWpEfwOAT1zXS+0rX8yljgsWR1UvqyEP 3xN0M/40Zk+rdmZKaZS8VQaXbveaiWMEmY7sBV3QvgOzB7UF2It1HwoCon5Y+PvyE3CguhBd 9iq5iEampkMIkbA3FFCpQFI5Ai3BywkLzbA3ZtnMXR8Qt9gFZtyXvFQrB+/6hDzEPnBGZOOx zkd/iIX59SxBuS38LMlhPPycbFNmtauOC0DNpXCv9ACgC9tFw3exER/xQgSpDVc4vrL2Cacr wmQp1k9E0W+9pk/l8S1jcHx03hgCxPtQLOIyEu9iIJb27TjcXNjiInd7Uea195NldIrndD+x 58/yU3X70qVY+eWbqzpdlwF1KRm6uV0ZOQhEhbi0FfKKgsYFgBIBchGqSOBsCbL35f9hK/JC 6LnGDtSHeJs+jd9/qJj4WqF3x8i0sncQ/gszSajdhnWrxraG3b7/9ldMLpKo/OoihfLaCxtv xYmtw8TGhlMaiOxjDrohmY1z7f3rf6njskoIXUO0nabun1nPAiV1dpjleg60s3OmVQeEpr3a K7gR1ljkemJzM9NUoRROPaT7nMlNYQL+IwuthJd6XQqwzp1jRTGG26J97wARAQABiQM+BBgB AgAJBQJWJ3+kAhsCAikJEBaat7Gkz/iuwV0gBBkBAgAGBQJWJ3+kAAoJEHfc29rIyEnRk6MQ AJDo0nxsadLpYB26FALZsWlN74rnFXth5dQVQ7SkipmyFWZhFL8fQ9OiIoxWhM6rSg9+C1w+ n45eByMg2b8H3mmQmyWztdI95OxSREKwbaXVapCcZnv52JRjlc3DoiiHqTZML5x1Z7lQ1T3F 8o9sKrbFO1WQw1+Nc91+MU0MGN0jtfZ0Tvn/ouEZrSXCE4K3oDGtj3AdC764yZVq6CPigCgs 6Ex80k6QlzCdVP3RKsnPO2xQXXPgyJPJlpD8bHHHW7OLfoR9DaBNympfcbQJeekQrTvyoASw EOTPKE6CVWrcQIztUp0WFTdRGgMK0cZB3Xfe6sOp24PQTHAKGtjTHNP/THomkH24Fum9K3iM /4Wh4V2eqGEgpdeSp5K+LdaNyNgaqzMOtt4HYk86LYLSHfFXywdlbGrY9+TqiJ+ZVW4trmui NIJCOku8SYansq34QzYM0x3UFRwff+45zNBEVzctSnremg1mVgrzOfXU8rt+4N1b2MxorPF8 619aCwVP7U16qNSBaqiAJr4e5SNEnoAq18+1Gp8QsFG0ARY8xp+qaKBByWES7lRi3QbqAKZf yOHS6gmYo9gBmuAhc65/VtHMJtxwjpUeN4Bcs9HUpDMDVHdfeRa73wM+wY5potfQ5zkSp0Jp bxnv/cRBH6+c43stTffprd//4Hgz+nJcCgZKtCYIAPkUxABC85ID2CidzbraErVACmRoizhT KR2OiqSLW2x4xdmSiFNcIWkWJB6Qdri0Fzs2dHe8etD1HYaht1ZhZ810s7QOL7JwypO8dscN KTEkyoTGn6cWj0CX+PeP4xp8AR8ot4d0BhtUY34UPzjE1/xyrQFAdnLd0PP4wXxdIUuRs0+n WLY9Aou/vC1LAdlaGsoTVzJ2gX4fkKQIWhX0WVk41BSFeDKQ3RQ2pnuzwedLO94Bf6X0G48O VsbXrP9BZ6snXyHfebPnno/te5XRqZTL9aJOytB/1iUna+1MAwBxGFPvqeEUUyT+gx1l3Acl ZaTUOEkgIor5losDrePdPgE= Organization: Baylibre Message-ID: Date: Tue, 21 May 2019 10:31:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190521_013121_520651_4F8A77A0 X-CRM114-Status: GOOD ( 18.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: khilman@baylibre.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/05/2019 19:45, Martin Blumenstingl wrote: > Hi Neil, > > On Mon, May 20, 2019 at 3:49 PM Neil Armstrong wrote: >> >> The Amlogic G12A has the hwrng module in an unknown "EFUSE" bus. >> >> The hwrng is not enabled on the vendor G12A DTs, but is enabled on >> next generation SM1 SoC family sharing the exact same memory mapping. >> >> Let's add the "EFUSE" bus and the hwrng node. >> >> This hwrng has been checked with the rng-tools rngtest FIPS tool : >> rngtest: starting FIPS tests... >> rngtest: bits received from input: 1630240032 >> rngtest: FIPS 140-2 successes: 81436 >> rngtest: FIPS 140-2 failures: 76 >> rngtest: FIPS 140-2(2001-10-10) Monobit: 10 >> rngtest: FIPS 140-2(2001-10-10) Poker: 6 >> rngtest: FIPS 140-2(2001-10-10) Runs: 26 >> rngtest: FIPS 140-2(2001-10-10) Long run: 34 >> rngtest: FIPS 140-2(2001-10-10) Continuous run: 0 >> rngtest: input channel speed: (min=3.784; avg=5687.521; max=19073.486)Mibits/s >> rngtest: FIPS tests speed: (min=47.684; avg=52.348; max=52.835)Mibits/s >> rngtest: Program run time: 30000987 microseconds >> >> Signed-off-by: Neil Armstrong >> --- >> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi >> index 8fcdd12f684a..19ef6a467d63 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi >> @@ -197,6 +197,19 @@ >> }; >> }; >> >> + apb_efuse: bus@30000 { >> + compatible = "simple-bus"; >> + reg = <0x0 0x30000 0x0 0x1000>; > the public S922X datasheet lists the range as FF630000 - FF631FFF > that translates to a size of 0x2000, which the vendor kernel > (kernel/aml-4.9/arch/arm64/boot/dts/amlogic/mesong12a.dtsi from > buildroot-openlinux-A113-201901) seems to use as well: > io_efuse_base{ > reg = <0x0 0xff630000 0x0 0x2000>; > }; > > where did you take the size from? Another typo, it's 0x2000. > >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges = <0x0 0x0 0x0 0x30000 0x0 0x1000>; > (see reg property above) > >> + >> + hwrng: rng { > this should be rng@218 Exact. > > > Martin > Neil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel