From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC677C433B4 for ; Tue, 6 Apr 2021 12:47:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EE8461279 for ; Tue, 6 Apr 2021 12:47:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EE8461279 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jBNnPbKzTrberl2J9VwGldKOSrZwNmvn9SJ9WY1nGb4=; b=JlPxx601lJfbhn0F1bldQBxPX 1LQHFeMnWjyaatPC7SCIOOfFsTfNleSZ/JOEnePGJXutgmtghqcEnhuBys3IcTyW9IV2yiLAT9KYO 05X+3fk65VqeqFus7gLCxD1r5adwNawV6mFjegKjsnILuyHl57dfQDhvbihdfeYoEbXRBFidqRZ6/ OZi4nXkwgNaBDCAiyw5JyfczSUvlMC5Z5TChJlvYfIaTSygx/w1S5+VCoM21e6avneU8ZWDcwTLv4 v719KBLLdsz2LKFZat7aX7Q0LDY6DTej1ah6IK3gPDpY+rPHCbxSGK4XgexeRXl7mVZjkQIp2kFTM ICwU+UqAA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTl5W-002ceo-KW; Tue, 06 Apr 2021 12:45:47 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTl5S-002ceP-Eh for linux-arm-kernel@lists.infradead.org; Tue, 06 Apr 2021 12:45:44 +0000 Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FF6X04Jycz681X8; Tue, 6 Apr 2021 20:38:40 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 6 Apr 2021 14:45:38 +0200 Received: from [10.210.166.136] (10.210.166.136) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 6 Apr 2021 13:45:36 +0100 Subject: Re: [PATCH v2 2/6] perf test: Handle metric reuse in pmu-events parsing test To: Jiri Olsa CC: , , , , , , , , , , , , , , , , References: <1616668398-144648-1-git-send-email-john.garry@huawei.com> <1616668398-144648-3-git-send-email-john.garry@huawei.com> From: John Garry Message-ID: Date: Tue, 6 Apr 2021 13:43:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.210.166.136] X-ClientProxiedBy: lhreml711-chm.china.huawei.com (10.201.108.62) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_134542_633875_3D12466D X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/04/2021 13:17, Jiri Olsa wrote: >>>> + ref = &metric->metric_ref; >>>> + ref->metric_name = pe->metric_name; >>>> + ref->metric_expr = pe->metric_expr; >>>> + list_add_tail(&metric->list, compound_list); >>>> + >>>> + rc = expr__find_other(pe->metric_expr, NULL, pctx, 0); >> Hi Jirka, >> >>> so this might add new items to pctx->ids, I think you need >>> to restart the iteration as we do it in __resolve_metric >>> otherwise you could miss some new keys >> I thought that I was doing this. Indeed, this code is very much like >> __resolve_metric();) >> >> So expr__find_other() may add a new item to pctx->ids, and we always iterate >> again, and try to lookup any pmu_events, *, above. If none exist, then we > hm, I don't see that.. so, what you do is: > > hashmap__for_each_entry_safe((&pctx->ids) ....) { > > rc = expr__find_other(pe->metric_expr, NULL, pctx, 0); > } > > and what I think we need to do is: > > hashmap__for_each_entry_safe((&pctx->ids) ....) { > > rc = expr__find_other(pe->metric_expr, NULL, pctx, 0); > > break; > } > > each time you resolve another metric, you need to restart > the pctx->ids iteration, because there will be new items, > and we are in the middle of it Sure, but we will restart anyway. Regardless of this, I don't think what I am doing is safe, i.e. adding new items in the middle of the iter, so I will change in the way you suggest. Thanks, John _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel