linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Felix Fietkau <nbd@nbd.name>,
	linux-arm-kernel@lists.infradead.org,
	Russell King <linux@armlinux.org.uk>
Cc: john@phrozen.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 04/12] ARM: Add basic support for Airoha EN7523 SoC
Date: Thu, 25 Nov 2021 13:21:33 +0000	[thread overview]
Message-ID: <f5c80024-1457-58fc-6c4a-1ef5f60cce8f@arm.com> (raw)
In-Reply-To: <20211125110738.41028-5-nbd@nbd.name>

On 2021-11-25 11:07, Felix Fietkau wrote:
> From: John Crispin <john@phrozen.org>
> 
> EN7523 is an armv8 based silicon used inside broadband access type devices
> such as xPON and xDSL. It shares various silicon blocks with MediaTek
> silicon such as the MT7622.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Bert Vermeulen <bert@biot.com>
> ---
>   arch/arm/Kconfig | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index f0f9e8bec83a..8468361a8721 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -573,6 +573,20 @@ config ARCH_VIRT
>   	select HAVE_ARM_ARCH_TIMER
>   	select ARCH_SUPPORTS_BIG_ENDIAN
>   
> +config ARCH_AIROHA
> +	bool "Airoha SoC Support"
> +	depends on ARCH_MULTI_V7
> +	select ARM_AMBA
> +	select ARM_GIC
> +	select ARM_GIC_V3
> +	select ARM_DMA_USE_IOMMU

Is this really needed? TBH I'd be rather surprised to see IOMMUs in a 
small-scale embedded router SoC, or are there others in a similar vein 
to MT7623N with random multimedia bits thrown in as well?

> +	select ARM_PSCI
> +	select HAVE_ARM_ARCH_TIMER
> +	select IOMMU_DMA

This does nothing (except bloat your image with some dead code which 
won't be called).

Robin.

> +	select COMMON_CLK
> +	help
> +	  Support for Airoha EN7523 SoCs
> +
>   #
>   # This is sorted alphabetically by mach-* pathname.  However, plat-*
>   # Kconfigs may be included either alphabetically (according to the
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-11-25 13:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 11:07 [PATCH v4 00/12] Add support for Airoha EN7523 SoC Felix Fietkau
2021-11-25 11:07 ` [PATCH v4 01/12] dt-bindings: Add vendor prefix for Airoha Felix Fietkau
2021-11-28 23:28   ` Rob Herring
2021-11-25 11:07 ` [PATCH v4 02/12] dt-bindings: arm: airoha: Add binding for EN7523 SoC and EVB Felix Fietkau
2021-11-28 23:29   ` Rob Herring
2021-11-25 11:07 ` [PATCH v4 03/12] ARM: dts: Add basic support for Airoha EN7523 Felix Fietkau
2021-11-25 11:07 ` [PATCH v4 04/12] ARM: Add basic support for Airoha EN7523 SoC Felix Fietkau
2021-11-25 13:21   ` Robin Murphy [this message]
2021-11-25 11:07 ` [PATCH v4 05/12] ARM: multi_v7_defconfig: Add " Felix Fietkau
2021-11-25 11:07 ` [PATCH v4 06/12] dt-bindings: Add en7523-scu device tree binding documentation Felix Fietkau
2021-11-28 23:31   ` Rob Herring
2021-11-25 11:07 ` [PATCH v4 07/12] clk: en7523: Add clock driver for Airoha EN7523 SoC Felix Fietkau
2021-11-27 11:23   ` kernel test robot
2021-11-25 11:07 ` [PATCH v4 08/12] dt-bindings: PCI: Add support for Airoha EN7532 Felix Fietkau
2021-11-28 23:32   ` Rob Herring
2021-11-25 11:07 ` [PATCH v4 09/12] PCI: mediatek: allow selecting controller driver for airoha arch Felix Fietkau
2021-11-25 11:07 ` [PATCH v4 10/12] ARM: dts: Add PCIe support for Airoha EN7523 Felix Fietkau
2021-11-25 12:15   ` Jianjun Wang
2021-11-25 11:07 ` [PATCH v4 11/12] dt-bindings: arm: airoha: Add binding for Airoha GPIO controller Felix Fietkau
2021-11-26  1:19   ` Linus Walleij
2021-11-25 11:07 ` [PATCH v4 12/12] gpio: Add support for Airoha EN7523 " Felix Fietkau
2021-11-25 12:59   ` Bartosz Golaszewski
2021-11-26 16:57     ` Andy Shevchenko
2021-11-26 17:19   ` John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5c80024-1457-58fc-6c4a-1ef5f60cce8f@arm.com \
    --to=robin.murphy@arm.com \
    --cc=john@phrozen.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).