archive mirror
 help / color / mirror / Atom feed
From: Suman Anna <>
To: Rob Herring <>
Cc: Jassi Brar <>,
	Tony Lindgren <>,  Nishanth Menon <>,
	Jan Kiszka <>, <>,
Subject: Re: [PATCH] dt-bindings: mailbox: Convert omap-mailbox.txt binding to YAML
Date: Thu, 20 May 2021 11:45:28 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 5/19/21 7:08 PM, Rob Herring wrote:
> On Wed, May 19, 2021 at 10:14:14AM -0500, Suman Anna wrote:
>> On 5/18/21 12:20 PM, Suman Anna wrote:
>>> Convert the current OMAP Mailbox binding from text format to YAML
>>> format/DT schema, and delete the legacy text binding file.
>>> The new YAML binding conversion is an updated version compared to
>>> the original. The descriptions for certain properties have been
>>> improved to provide more clarity. Constraints are added to the
>>> properties 'ti,mbox-num-users', 'ti,mbox-num-fifos' and 'interrupts'.
>>> The 'ti,hwmods' is a legacy property and is retained only to reflect
>>> the existing usage on some older OMAP2 and OMAP3 platforms.
>>> All the existing examples have also been updated to reflect the
>>> latest dts nodes (ti,hwmods removed from OMAP4 and AM33xx examples,
>>> and interrupts value updated for AM65x SoCs).
>>> Signed-off-by: Suman Anna <>
>>> ---
>>> Hi,
>>> This patch does fix a number of dtbs_check warnings seen around OMAP Mailbox
>>> nodes with the latest kernel. There are few left-over warnings when just
>>> this patch is used on v5.13-rc1 or next-20210518. I have posted a separate
>>> fix for a warning on TI K3 SoCs [1], and will be posting a separate cleanup
>>> series for OMAP2+ SoCs. The dts patches can be picked up independently
>>> of this patch.
>> FYI, All the dtbs_check warnings will be gone with [1] and the OMAP2+ cleanup
>> series [2].
> Nice, though it is a moving target. :) Is that still true with the 
> undocumented compatible checks that's been added? 

[1] is acked, so will definitely get picked up for the next merge window. Should
hit next sometime in the next couple of days.

I didn't exactly understand your second comment, but no new compatibles were
added. The existing nodes are already in compliance with the constraints I added
(so that's strictly binding enforcements). These constraints are almost all on
legacy SoCs, so these do not pose any issues.

Most of the generated warnings stem from me adding a pattern for the child nodes
in the binding, and [2] is mostly just renaming these node names.

Do you have/foresee any concerns with the patches in [2]?



linux-arm-kernel mailing list

  reply	other threads:[~2021-05-20 16:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 17:20 Suman Anna
2021-05-19 15:14 ` Suman Anna
2021-05-20  0:08   ` Rob Herring
2021-05-20 16:45     ` Suman Anna [this message]
2021-05-20 19:21       ` Rob Herring
2021-05-20 20:07         ` Suman Anna
2021-05-25  6:44           ` Tony Lindgren
2021-05-21  9:21       ` Tony Lindgren
2021-05-20  0:14 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] dt-bindings: mailbox: Convert omap-mailbox.txt binding to YAML' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).