From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D45EC388F9 for ; Tue, 27 Oct 2020 10:59:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 815D62224E for ; Tue, 27 Oct 2020 10:59:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WjNxSqsO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 815D62224E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GtQzqeTPMkYNvchjiVCnwAR69kURNfLw63Soa6sDnD4=; b=WjNxSqsO59R8Gr3VNuKS+1oXdh ryUdghIXh27t5pddEeGPs/j/YGs7cNNGJ+zIgYgEjl8pUhPk2xgd4LRlOdUedHhvZD9dFib2cmc22 h1Yqd7Y/s2XWMZOEbgcvDvXcm2YKdLgTXcDXuBojkuyA+ySZv3Kobdyw0it9j54/3y3HR3XFshXh/ BSPx4ot/AzBAMqPipk/FQba+nVU6Q8VnZ+qPAMhMJevoiBOZh3SYvSxf7srU8aC3eJX4R+0HS19+z ulneQ4z5fFkIH13+VOnJ7rEQ+qBtav4sTmcuNowW+T4okdT35ndARLDFtJWJCGAGRQqbTasoiu0Cv rURXDxEg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXMgM-0005eY-FE; Tue, 27 Oct 2020 10:58:26 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXMgJ-0005dg-0O for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 10:58:23 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kXMg7-00046a-Qk; Tue, 27 Oct 2020 11:58:11 +0100 Subject: Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds To: Pavel Machek , Dan Murphy , Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Alexander Dahl , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Jacek Anaszewski , Maxime Coquelin , linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org References: <20201005203451.9985-1-post@lespocky.de> <20201005203451.9985-11-post@lespocky.de> <20201027100536.cpfizc67gwrolp2z@falbala.internal.home.lespocky.de> From: Ahmad Fatoum Message-ID: Date: Tue, 27 Oct 2020 11:58:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201027100536.cpfizc67gwrolp2z@falbala.internal.home.lespocky.de> Content-Language: en-US X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_065823_080806_A36A5BEB X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 10/27/20 11:05 AM, Alexander Dahl wrote: > Hello Ahmad, > > thanks for your feedback, comments below. > >>> - led-rgb { >>> + led-controller-2 { >> >> Is a single RGB LED really a controller? > > I just followed the recommendations by Rob here. Do you happen to know if the new multicolor LED support could be used here? I find it unfortunate that the device tree loses information relevant to humans to adhere to a fixed nomenclature. Apparently led-controller isn't even codified in the YAML binding (It's just in the examples). If you respin, please add a comment that this is a single RGB led. I'd prefer to keep the information in the DTB as well though. > >>> compatible = "pwm-leds"; >>> >>> - led-red { >>> + led-2 { >> >> Shouldn't this have been led-1 as well or is the numbering "global" ? > > Also good question. This numbering is for dts only, it usually does > not correspond with LEDs on the board, so it could be numbered per > led-controller as well? I'd prefer that it starts by 1. That way it's aligned with PWM channel ID. Thanks for fixing the dtschema warnings by the way! Cheers, Ahmad > > Greets > Alex > >> >>> label = "mc1:red:rgb"; >>> pwms = <&leds_pwm 1 1000000 0>; >>> max-brightness = <255>; >>> active-low; >>> }; >>> >>> - led-green { >>> + led-3 { >>> label = "mc1:green:rgb"; >>> pwms = <&leds_pwm 2 1000000 0>; >>> max-brightness = <255>; >>> active-low; >>> }; >>> >>> - led-blue { >>> + led-4 { >>> label = "mc1:blue:rgb"; >>> pwms = <&leds_pwm 3 1000000 0>; >>> max-brightness = <255>; >>> >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel