From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Quentin Schulz <foss+kernel@0leil.net>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
heiko@sntech.de, dmitry.torokhov@gmail.com,
klaus.goger@theobroma-systems.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard
Date: Fri, 23 Sep 2022 11:55:17 +0200 [thread overview]
Message-ID: <f72271d7-9f42-45e9-01a4-590bd20250ab@theobroma-systems.com> (raw)
In-Reply-To: <e481af15-7e37-47dc-b272-6d032b5dd7a7@linaro.org>
Hi Krzysztof,
On 9/22/22 14:45, Krzysztof Kozlowski wrote:
> On 22/09/2022 12:12, Quentin Schulz wrote:
[...]
>> diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
>> new file mode 100644
>> index 000000000000..74a7f1182c21
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
>> @@ -0,0 +1,347 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2022 Theobroma Systems Design und Consulting GmbH
>> + */
>> +
>> +/dts-v1/;
>> +#include "px30.dtsi"
>> +
>> +/ {
>> + aliases {
>> + mmc0 = &emmc;
>> + mmc1 = &sdio;
>> + rtc0 = &rtc_twi;
>> + rtc1 = &rk809;
>> + };
>> +
>> + emmc_pwrseq: emmc-pwrseq {
>> + compatible = "mmc-pwrseq-emmc";
>> + pinctrl-0 = <&emmc_reset>;
>> + pinctrl-names = "default";
>> + reset-gpios = <&gpio1 RK_PB3 GPIO_ACTIVE_HIGH>;
>> + };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>
> This belongs to DTSI.
>
It is in the DTSI :)
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&module_led_pin>;
>> + status = "okay";
>
> No need.
>
>> +
>> + module_led: led-0 {
>
> Why DTSI - which in logic comes first - starts with 1 and this is 0?\
>
The first diff in this patch is for the DTS, this is now the DTSI. So it
does have led-0 in the DTSI and led-1 in the DTS which I think is what
you're requesting here? Is this a correct assumption?
Ack for all other review comments, thanks!
Cheers,
Quentin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-23 9:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 10:12 [PATCH 0/3] add support for Theobroma Systems PX30-µQ7 (Ringneck) with Haikou devkit Quentin Schulz
2022-09-22 10:12 ` [PATCH 1/3] Input: add `SW_BOOT_ALT` Quentin Schulz
2022-09-22 17:20 ` Jeff LaBundy
2022-09-23 8:25 ` Quentin Schulz
2022-09-23 17:19 ` Jeff LaBundy
2022-09-23 17:24 ` Dmitry Torokhov
2022-09-26 9:37 ` Quentin Schulz
2022-09-27 1:56 ` Jeff LaBundy
2022-09-27 8:51 ` Quentin Schulz
2022-09-27 12:57 ` Robin Murphy
2022-09-22 10:12 ` [PATCH 2/3] arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard Quentin Schulz
2022-09-22 11:56 ` Quentin Schulz
2022-09-22 12:45 ` Krzysztof Kozlowski
2022-09-23 9:55 ` Quentin Schulz [this message]
2022-09-23 10:28 ` Krzysztof Kozlowski
2022-09-22 10:12 ` [PATCH 3/3] dt-bindings: arm: rockchip: add Theobroma Systems PX30-µQ7 (Ringneck) with Haikou Quentin Schulz
2022-09-22 12:40 ` Krzysztof Kozlowski
2022-09-22 12:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f72271d7-9f42-45e9-01a4-590bd20250ab@theobroma-systems.com \
--to=quentin.schulz@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=foss+kernel@0leil.net \
--cc=heiko@sntech.de \
--cc=klaus.goger@theobroma-systems.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).