From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18BBDC433EF for ; Thu, 14 Oct 2021 07:38:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D536F60FDC for ; Thu, 14 Oct 2021 07:38:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D536F60FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:Subject:From:References:Cc:To:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=/+4FsJyuh/UfS4ZB9xaO0t/vZGSBcd0h9PC9+M19HL0=; b=QWKiRNWv28Q3mEAgZoVpaw6LAZ 9uR5Ym++dN9bJyEAQ3lJW3RqA4j03j2wDirdtURrjlwfgKbjdxqIjN7aeH/weHt9QzvbRRuSe4Ph/ 3GSN8ULgUNga6nKRNSTcjL/DuMq3zCh9qJGAW+s9kL0E4D5beDjCxN3Vlb5xuTWeKzE1af3Tlya9w LDrYo4x6+/V5zpWdLCnNVVtc8lVH8LIGfuEhGie+fRaCmZWhfSn55g7yCYwqvPX7v/aGuH2BQ10DQ o9iHMBbZFfO4rG2ADld9mYz2Embi1tmRpNO7EirQvbEB6t/j6DRo77rY8gDLKdhBBqRkYBluKjrBp Yall9+0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mavI1-001vyX-GX; Thu, 14 Oct 2021 07:36:33 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mavHy-001vx4-1m for linux-arm-kernel@lists.infradead.org; Thu, 14 Oct 2021 07:36:31 +0000 Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id C1A7C40024 for ; Thu, 14 Oct 2021 07:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1634196987; bh=3dBHQ0CCwS4iqRIss5gN00T/QO/pYW+4oQWUdLki5wU=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=NfZ1IBpWJFjHA431BtAXCXUs9jwHZyJuC1RMb72biZiCbP5pfnVFE6z4tbedelVoo pw0arGbpJrx1qAhzr9quu/QNuLEJ7wbvAgzZzLEVS91lT+iWkQO1EYiNBaCdVDhjW2 rqPtboiPGMCjinYdyfz3Muy4nyI9x3ZqkhuD5b9fe1ShfvFvWT0+0LLWnKjFuKJJ0B Yl+CzRPMJRUgQDFBEBSgPKQzO45teVQ3oQW21xkDUZV5KLslE7ka+VzSyN50QVIjD7 PjUiwwrGH+w5/ZViPQ5ZcDjQ0Sbyua0clIi1YApQrEJVRYT7UDuz5VUda6Hv/eNm1F aJdCyYsaD6vPw== Received: by mail-lf1-f69.google.com with SMTP id p42-20020a05651213aa00b003fd8935b8d6so3771246lfa.10 for ; Thu, 14 Oct 2021 00:36:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3dBHQ0CCwS4iqRIss5gN00T/QO/pYW+4oQWUdLki5wU=; b=KJ1gM+WbGsDhfHZizQXBXLIELyjgTdoYqdC1I26Ee5wXvRYo6YArjZ0lpS1h1NSvS4 bv6NIkMyyvCuM2FJrFCDxMhAwdxkA2QLaPIObM6Z5e/0WNj3GX+ocjvFU15q6u5SSsCx tE9O/jwxw4DAw2FqlErT9P2r/EzIbeN+IYX5JkYcnJL2QB+7SyasDFbAOP31lTkwbxRT bJsjPNVsvcMaXrAzqc22p7zfpFoR2mtquh+X/fLe+3VP8Sz432FE7MwtSCgfEO7+MmGD lPhTfKIhXJ4q1SIhfNFWHaDDYpc1H5XQokEVbsbA5oiV2wDpMpexVAra68Ni/jGvANK8 HZtQ== X-Gm-Message-State: AOAM531TYMtS9Jd7VtDr+rh3t7cEO6ATbFcUrifrWf6T9jVKLfDnRDQf a0Smc1mM56wxcLBUECyWDM/pIpjFI1+AVmOn3hBMokTSW77+GataP+iVXMtureLHYeMK7O/LXRe cNU/QXUafEwcIj06u77w2b12rSUJP0b9BDwzAs1eVYcNm4sldr5ND X-Received: by 2002:a2e:3005:: with SMTP id w5mr4290252ljw.228.1634196987029; Thu, 14 Oct 2021 00:36:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsQsq/0kwEUVa9aO6xG/cThkpvqL7ggL6yk+veaubzi/nCENc7uw5xGlJJejFOv/z5TAeGtw== X-Received: by 2002:a2e:3005:: with SMTP id w5mr4290229ljw.228.1634196986778; Thu, 14 Oct 2021 00:36:26 -0700 (PDT) Received: from [192.168.3.161] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id f6sm200698ljo.36.2021.10.14.00.36.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 00:36:26 -0700 (PDT) To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Alyssa Rosenzweig , Sven Peter , Marc Zyngier , Mark Kettenis , Michael Turquette , Stephen Boyd , Rob Herring , Viresh Kumar , Nishanth Menon , Catalin Marinas , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211011165707.138157-1-marcan@marcan.st> <20211011165707.138157-7-marcan@marcan.st> <2a6f14e5-fbc9-4b9a-9378-a4b5200bc3fb@marcan.st> From: Krzysztof Kozlowski Subject: Re: [RFC PATCH 6/9] memory: apple: Add apple-mcc driver to manage MCC perf in Apple SoCs Message-ID: Date: Thu, 14 Oct 2021 09:36:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <2a6f14e5-fbc9-4b9a-9378-a4b5200bc3fb@marcan.st> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211014_003630_329327_E3A99D2C X-CRM114-Status: GOOD ( 27.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/10/2021 08:59, Hector Martin wrote: > On 12/10/2021 18.19, Krzysztof Kozlowski wrote: >>> +// SPDX-License-Identifier: GPL-2.0-only OR MIT >>> +/* >>> + * Apple SoC MCC memory controller performance control driver >>> + * >>> + * Copyright The Asahi Linux Contributors >> >> Copyright date? > > We've gone over this one a few times already; most copyright dates > quickly become outdated and meaningless :) > > See: > https://www.linuxfoundation.org/blog/copyright-notices-in-open-source-software-projects/ > >>> +static int apple_mcc_probe(struct platform_device *pdev) >>> +{ >>> + struct device *dev = &pdev->dev; >>> + struct device_node *node = dev->of_node; >> >> By convention mostly we call the variable "np". > > Ack, I'll change it for v2. > >>> + mcc->reg_base = devm_platform_ioremap_resource(pdev, 0); >>> + if (IS_ERR(mcc->reg_base)) >>> + return PTR_ERR(mcc->reg_base); >>> + >>> + if (of_property_read_u32(node, "apple,num-channels", &mcc->num_channels)) { >> >> Don't you have a limit of supported channels? It cannot be any uint32... > > Today, it's max 8. But if come Monday we find out Apple's new chips have > 16 channels and otherwise the same register layout, I'd much rather not > have to change the driver... OK, however if the driver ever receives different DT with a different value, it will accept it unconditionally and go via address space. I am just saying that being conservative on received values is safer, but I am fine with skipping this problem. At the end we trust DT that it will always match the kernel, don't we? Oh wait, someone can use DT from other kernel in this one... > >>> + dev_err(dev, "missing apple,num-channels property\n"); >> >> Use almost everywhere dev_err_probe - less code and you get error msg >> printed. > > Heh, I didn't know about that one. Thanks! > >>> + >>> + dev_info(dev, "Apple MCC performance driver initialized\n"); >> >> Please skip it, or at least make it a dev_dbg, you don't print any >> valuable information here. > > Ack, I'll remove this. > >>> +static struct platform_driver apple_mcc_driver = { >>> + .probe = apple_mcc_probe, >>> + .driver = { >>> + .name = "apple-mcc", >>> + .of_match_table = apple_mcc_of_match, >>> + }, >>> +}; >> >> module_platform_driver() goes here. > > Ack, will fix for v2. > >> >>> + >>> +MODULE_AUTHOR("Hector Martin "); >>> +MODULE_DESCRIPTION("MCC memory controller performance tuning driver for Apple SoCs"); >>> +MODULE_LICENSE("GPL v2"); >> >> I think this will be "Dual MIT/GPL", based on your SPDX. > > Ah, I didn't realize that was a valid option for MODULE_LICENSE. I guess > anything containing "GPL" works with EXPORT_SYMBOL_GPL? I don't think exporting symbols is related to how you license your code. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel