From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42933C83004 for ; Wed, 29 Apr 2020 10:43:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 030FB2087E for ; Wed, 29 Apr 2020 10:43:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kr6HhhLT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 030FB2087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OAJJl31KGJ8zH6WY0WD5F7xEKEwSV7cTDhiZTc7ImJU=; b=kr6HhhLTZAnsK3z1/LXvlMrB3 nLte1m/q/eildMqVIwA7Z38GC4TAddSuWZ87c2GnaCO5zROQXtfkMuBi6pFKNvOlgW2fSg0gLAbCy j8AMJhaW4V9KyoipE9d8tiYHHDkggpXCTqRLUGgJw5jPcMst7lO5qHGayiY1+TbBjgi4KIMHvqqu+ KQT1ggM+mIEErA4+iP+RJS7JEsW9SWd9HFgnog33yQPmdKIcxL1BquqY4WwSiFJ1mqiBIIdKN7ceW W0RyDbhGa0c/fMLbvCMkEbz92ClAVrlaAd1eWvaahy19y0sCpbf1Gs9aNLj1RU9ycZhbk9Mvof83i OE8lx38zQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTkBt-0000JL-5T; Wed, 29 Apr 2020 10:43:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTkBS-0008Mj-Mc for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2020 10:43:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EDD6BC14; Wed, 29 Apr 2020 03:43:17 -0700 (PDT) Received: from [10.57.33.170] (unknown [10.57.33.170]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7D8773F73D; Wed, 29 Apr 2020 03:43:09 -0700 (PDT) Subject: Re: [linux-sunxi] Re: Audio sound card name [was [PATCH 4/7] arm64: dts: allwinner: a64: Add HDMI audio] To: Maxime Ripard , Chen-Yu Tsai References: <20200426120442.11560-1-peron.clem@gmail.com> <20200426120442.11560-5-peron.clem@gmail.com> <20200428080020.35qcuylwq2ylmubu@gilmour.lan> <20200428160417.6q5oab2guaumhhwi@gilmour.lan> <031ee5d3-8a30-82ee-76db-c0e8a1073046@arm.com> <20200429081729.qa3gqtl5sof2jhem@gilmour.lan> From: Robin Murphy Message-ID: Date: Wed, 29 Apr 2020 11:43:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200429081729.qa3gqtl5sof2jhem@gilmour.lan> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_034318_842019_98C58B23 X-CRM114-Status: GOOD ( 22.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Linux-ALSA , Takashi Iwai , Jernej Skrabec , Liam Girdwood , Rob Herring , linux-kernel , Marcus Cooper , linux-sunxi , Mark Brown , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Jaroslav Kysela , linux-arm-kernel Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="windows-1252"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-04-29 9:17 am, Maxime Ripard wrote: > On Wed, Apr 29, 2020 at 02:24:00PM +0800, Chen-Yu Tsai wrote: >> On Wed, Apr 29, 2020 at 1:11 AM Robin Murphy wrot= e: >>> >>> On 2020-04-28 5:49 pm, Cl=E9ment P=E9ron wrote: >>>> Hi Mark, Rob, >>>> >>>> On Tue, 28 Apr 2020 at 18:04, Maxime Ripard wrote: >>>>> >>>>> On Tue, Apr 28, 2020 at 10:54:00AM +0200, Cl=E9ment P=E9ron wrote: >>>>>> Hi Maxime, >>>>>> >>>>>> On Tue, 28 Apr 2020 at 10:00, Maxime Ripard wrot= e: >>>>>>> >>>>>>> On Sun, Apr 26, 2020 at 02:04:39PM +0200, Cl=E9ment P=E9ron wrote: >>>>>>>> From: Marcus Cooper >>>>>>>> >>>>>>>> Add a simple-soundcard to link audio between HDMI and I2S. >>>>>>>> >>>>>>>> Signed-off-by: Jernej Skrabec >>>>>>>> Signed-off-by: Marcus Cooper >>>>>>>> Signed-off-by: Cl=E9ment P=E9ron >>>>>>>> --- >>>>>>>> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 21 ++++++++++++= +++++++ >>>>>>>> 1 file changed, 21 insertions(+) >>>>>>>> >>>>>>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/= arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>>>>>> index e56e1e3d4b73..08ab6b5e72a5 100644 >>>>>>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>>>>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>>>>>> @@ -102,6 +102,25 @@ >>>>>>>> status =3D "disabled"; >>>>>>>> }; >>>>>>>> >>>>>>>> + hdmi_sound: hdmi-sound { >>>>>>>> + compatible =3D "simple-audio-card"; >>>>>>>> + simple-audio-card,format =3D "i2s"; >>>>>>>> + simple-audio-card,name =3D "allwinner,hdmi"; >>>>>>> >>>>>>> I'm not sure what the usual card name should be like though. I woul= d assume that >>>>>>> this should be something specific enough so that you're able to dif= ferentiate >>>>>>> between boards / SoC so that the userspace can choose a different c= onfiguration >>>>>>> based on it? >>>>>> >>>>>> I really don't know what we should use here, >>>>>> I just have a look at other SoC: >>>>>> rk3328: "HDMI" >>>>>> rk3399: "hdmi-sound" >>>>>> r8a774c0-cat874: "CAT874 HDMI sound" >>>>>> >>>>>> But maybe it's time to introduce proper name: >>>>>> What about : >>>>>> pat >>>>>> sun50i-h6-hdmi >>>>> >>>>> It's pretty much what we've been using for the other sound cards we h= ave, so it >>>>> makes sense to me. >>>> >>>> I have a question regarding the simple-audio-card,name. >>>> In this patch, I would like to introduce a simple-audio-card for the >>>> Allwinner A64 HDMI. >>>> >>>> What should be the preferred name for this sound card? >>>> "sun50i-a64-hdmi" ? "allwinner, sun50i-a64-hdmi" ? >>> >>> I can at least speak for RK3328, and the reasoning there was that as the >>> user looking at what `aplay -l` says, I don't give a hoot about what the >>> SoC may be called, I see two cards and I want to know, with the least >>> amount of uncertainty, which one will make the sound come out of the >>> port that's labelled "HDMI" on the box ;) >> >> I agree. The user really doesn't care what SoC the system uses. The only >> real requirement is to be able to tell which output the card is related >> to, i.e. is it onboard or an external DAC, is it analog or HDMI, etc.. > = > Yeah, but it's exactly the point. > = > If we also end up with "HDMI" as our card name, then the userspace has no= way to > tell anymore if it's running from an rk3328 or an allwinner SoC, or somet= hing > else entirely. And therefore it cannot really configure anything to work = out of > the box anymore. OK, you're a userspace audio application - enlighten me as to what exact = chip you're running on here, and why you need to know: card 0: HDMI [HDA ATI HDMI] or how about here? card 0: Intel [HDA Intel] Furthermore, your argument works both ways - if the equivalent (or in = common cases like DesignWare IP blocks, exact same) thing across 3 = different SoCs has 3 different names, then it's that much harder for = userspace that wants to present a consistent behaviour. I don't know = exactly why LibreELEC have downstream patches that standardise all the = Rockchip ones to "HDMI", but I can't help noting that they do. With simple-audio-card we're talking about trivial interfaces that often = don't expose any controls at all, so there's unlikely to be much = 'configuration' for userspace to do beyond choosing which card to output to. Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel