linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: arnd@arndb.de, paul@pgazz.com, linux-kernel@vger.kernel.org,
	bgolaszewski@baylibre.com, jeho@cs.utexas.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL
Date: Thu, 24 Sep 2020 20:50:34 +0530	[thread overview]
Message-ID: <fa237200-7555-9fda-04be-994151637bf7@ti.com> (raw)
In-Reply-To: <20200914123848.307406-1-fazilyildiran@gmail.com>

Hi Necip,

On 14/09/20 6:08 PM, Necip Fazil Yildiran wrote:
> When ARCH_DAVINCI is enabled and PINCTRL is disabled, it results
> in the following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for PINCTRL_SINGLE
>   Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - ARCH_DAVINCI [=y] && ARCH_MULTI_V5 [=y]
> 
> The reason is that ARCH_DAVINCI selects PINCTRL_SINGLE without depending on
> or selecting PINCTRL while PINCTRL_SINGLE is subordinate to PINCTRL.
> 
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
> 
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>

I think its better to fix this by changing the "select PINCTRL_SINGLE"
to "imply PINCTRL_SINGLE". It should be valid to build a DaVinci kernel
without pinctrl support if bootloader is taking care of the pin muxing.

I would not recommend it, but its not illegal either.

While at it, I would drop the other "select PINCTRL" line under "config
MACH_DA8XX_DT". It should not be needed since ARCH_DAVINCI will imply
PINCTRL_SINGLE

Thanks,
Sekhar

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2020-09-24 15:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 12:38 [PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL Necip Fazil Yildiran
2020-09-24 15:20 ` Sekhar Nori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa237200-7555-9fda-04be-994151637bf7@ti.com \
    --to=nsekhar@ti.com \
    --cc=arnd@arndb.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=fazilyildiran@gmail.com \
    --cc=jeho@cs.utexas.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@pgazz.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).