From: Marek Vasut <marex@denx.de>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>,
arnd@arndb.de, robh+dt@kernel.org, jagan@amarulasolutions.com,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Marcin Sloniewski <marcin.sloniewski@gmail.com>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
kuba@kernel.org
Subject: Re: [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU
Date: Thu, 15 Apr 2021 16:30:38 +0200 [thread overview]
Message-ID: <fa3885df-8977-9540-f2af-d4095f519483@denx.de> (raw)
In-Reply-To: <36e9f0df-dfdb-e2f5-3d6e-ac32a1b8156e@foss.st.com>
On 4/15/21 3:34 PM, Alexandre TORGUE wrote:
> Hi Marek
Hello Alexandre,
>>> diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts
>>> b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>>> index 2bc92ef3aeb9..19ef475a48fc 100644
>>> --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
>>> +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>>> @@ -82,9 +82,15 @@
>>> };
>>> <dc {
>>> - status = "okay";
>>> -
>>> port {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + ltdc_ep0_out: endpoint@0 {
>>> + reg = <0>;
>>> + remote-endpoint = <&sii9022_in>;
>>> + };
>>> +
>>> ltdc_ep1_out: endpoint@1 {
>>> reg = <1>;
>>> remote-endpoint = <&dsi_in>;
>>
>> [...]
>>
>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
>>> b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
>>> index 64dca5b7f748..e7f10975cacf 100644
>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
>>> @@ -277,11 +277,7 @@
>>> status = "okay";
>>> port {
>>> - #address-cells = <1>;
>>> - #size-cells = <0>;
>>> -
>>> - ltdc_ep0_out: endpoint@0 {
>>> - reg = <0>;
>>> + ltdc_ep0_out: endpoint {
>>> remote-endpoint = <&adv7513_in>;
>>> };
>>> };
>>
>> I think this is wrong, the AV96 can have two displays connected to two
>> ports of the LTDC, just like DK2 for example.
>
> As for dk2 address/size cells are added only if there are 2 endpoints.
> It is for this reason I moved endpoint0 definition from stm32mp15xx-dkx
> to stm32mp151a-dk1.dts (dk1 has only one endpoint).
>
> Here it's the same, if you have second endpoint then adress/size will
> have to be added.
That's a bit problematic. Consider either the use case of DTO which adds
the other display, or even a custom board DTS. Without your patch, this
works:
arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
<dc {
...
ports {
ltdc_ep0_out: endpoint@0 {
remote-endpoint = <&adv7513_in>;
};
};
};
board-with-display.dts or board-overlay.dts
<dc {
ports {
endpoint@1 { // just add another endpoint@1, no problem
remote-endpoint = <&display>;
};
};
};
With your patch, the DTS would have to modify the "endpoint" node to be
"endpoint@0" probably with a whole lot of /detele-node/ etc. magic (DTO
cannot do that, so that's a problem, and I do use DTOs on AV96
extensively for the various expansion cards) and then add the
endpoint@1. That becomes real complicated in custom board DT, and
impossible with DTO.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-15 14:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:10 [PATCH 00/13] ARM: dts: stm32: fix "make dtbs_check W=1" round1 Alexandre Torgue
2021-04-15 10:10 ` [PATCH 01/13] ARM: dts: stm32: fix gpio-keys node on STM32 MCU boards Alexandre Torgue
2021-04-15 10:10 ` [PATCH 02/13] ARM: dts: stm32: fix RCC node name on stm32f429 MCU Alexandre Torgue
2021-04-15 10:10 ` [PATCH 03/13] ARM: dts: stm32: fix timer nodes on STM32 MCU to prevent warnings Alexandre Torgue
2021-04-16 15:52 ` [Linux-stm32] " Fabrice Gasnier
2021-04-15 10:10 ` [PATCH 04/13] dt-bindings: mfd: stm32-timers: remove #address/size cells from required properties Alexandre Torgue
2021-04-16 15:52 ` [Linux-stm32] " Fabrice Gasnier
2021-04-20 20:04 ` Rob Herring
2021-06-01 16:26 ` Lee Jones
2021-04-15 10:10 ` [PATCH 05/13] ARM: dts: stm32: update pinctrl node name on STM32 MCU to prevent warnings Alexandre Torgue
2021-04-15 10:10 ` [PATCH 06/13] ARM: dts: stm32: fix i2c node name on stm32f746 " Alexandre Torgue
2021-04-15 10:10 ` [PATCH 07/13] ARM: dts: stm32: move stmmac axi config in ethernet node on stm32mp15 Alexandre Torgue
2021-04-15 10:10 ` [PATCH 08/13] dt-bindings: net: document ptp_ref clk in dwmac Alexandre Torgue
2021-04-20 20:05 ` Rob Herring
2021-04-15 10:10 ` [PATCH 09/13] ARM: dts: stm32: fix stpmic node for stm32mp1 boards Alexandre Torgue
2021-06-10 14:33 ` Alexandre TORGUE
2021-04-15 10:10 ` [PATCH 10/13] dt-bindings: mfd: add vref_ddr-supply to st, stpmic1 yaml Alexandre Torgue
2021-04-15 10:51 ` Ahmad Fatoum
2021-04-15 12:12 ` Alexandre TORGUE
2021-04-15 10:10 ` [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU Alexandre Torgue
2021-04-15 13:21 ` Marek Vasut
2021-04-15 13:34 ` Alexandre TORGUE
2021-04-15 14:30 ` Marek Vasut [this message]
2021-04-15 14:35 ` Alexandre TORGUE
2021-04-15 14:59 ` Marek Vasut
2021-04-15 10:10 ` [PATCH 12/13] ARM: dts: stm32: fix DSI port node on STM32MP15 Alexandre Torgue
2021-04-15 10:43 ` Ahmad Fatoum
2021-04-15 12:23 ` Alexandre TORGUE
2021-04-19 13:57 ` Arnd Bergmann
2021-04-19 14:04 ` Alexandre TORGUE
2021-05-04 13:16 ` Ahmad Fatoum
2021-04-15 10:10 ` [PATCH 13/13] ARM: dts: stm32: fix ltdc pinctrl on microdev2.0-of7 Alexandre Torgue
2021-06-01 10:37 ` [PATCH 00/13] ARM: dts: stm32: fix "make dtbs_check W=1" round1 Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa3885df-8977-9540-f2af-d4095f519483@denx.de \
--to=marex@denx.de \
--cc=a.fatoum@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marcin.sloniewski@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).