From: CK Hu <ck.hu@mediatek.com>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>,
<chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <matthias.bgg@gmail.com>, <deller@gmx.de>,
<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
<jitao.shi@mediatek.com>, <wenst@chromium.org>,
<angelogioacchino.delregno@collabora.com>,
<liangxu.xu@mediatek.com>, <dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-fbdev@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v17 09/10] drm/mediatek: dp: Add hpd debounce
Date: Fri, 2 Sep 2022 16:12:58 +0800 [thread overview]
Message-ID: <fa57b7e392ce8dac005dd572963a8844a7070007.camel@mediatek.com> (raw)
In-Reply-To: <20220901044149.16782-10-rex-bc.chen@mediatek.com>
Hi, Bo-Chen:
On Thu, 2022-09-01 at 12:41 +0800, Bo-Chen Chen wrote:
> From: Jitao Shi <jitao.shi@mediatek.com>
>
> From the DP spec 1.4a chapter 3.3, upstream devices should implement
> HPD signal de-bouncing on an external connection.
> A period of 100ms should be used to detect an HPD connect event.
> To cover these cases, HPD de-bounce should be implemented only after
> HPD low has been detected for at least 100ms.
>
> Therefore,
> 1. If HPD is low (which means plugging out) for longer than 100ms:
> we need to do de-bouncing (which means we need to wait for 100ms).
> 2. If HPD low is for less than 100ms:
> we don't need to care about the de-bouncing.
>
> In this patch, we start a 100ms timer and use a need_debounce boolean
> to implement the feature.
>
> Two cases when HPD is high:
> 1. If the timer is expired (>100ms):
> - need_debounce is true.
> - When HPD high (plugging event comes), need_debounce will be true
> and then we need to do de-bouncing (wait for 100ms).
> 2. If the timer is not expired (<100ms):
> - need_debounce is false.
> - When HPD high (plugging event comes), need_debounce will be
> false
> and no need to do de-bouncing.
>
> HPD_______ __________________
> | |<- 100ms ->
> |____________|
> <- 100ms ->
>
> Without HPD de-bouncing, USB-C to HDMI Adapaters will not be
> detected.
>
> The change has been successfully tested with the following devices:
> - Dell Adapter - USB-C to HDMI
> - Acer 1in1 HDMI dongle
> - Ugreen 1in1 HDMI dongle
> - innowatt HDMI + USB3 hub
> - Acer 2in1 HDMI dongle
> - Apple 3in1 HDMI dongle (A2119)
> - J5Create 3in1 HDMI dongle (JAC379)
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Tested-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dp.c | 25 ++++++++++++++++++++++++-
> 1 file changed, 24 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c
> b/drivers/gpu/drm/mediatek/mtk_dp.c
> index 11a94927c0d0..dd34dae417e5 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> @@ -87,6 +87,7 @@ struct mtk_dp_efuse_fmt {
>
> struct mtk_dp {
> bool enabled;
> + bool need_debounce;
> u8 max_lanes;
> u8 max_linkrate;
> u8 rx_cap[DP_RECEIVER_CAP_SIZE];
> @@ -109,6 +110,7 @@ struct mtk_dp {
> struct platform_device *phy_dev;
> struct phy *phy;
> struct regmap *regs;
> + struct timer_list debounce_timer;
> };
>
> struct mtk_dp_data {
> @@ -1475,14 +1477,24 @@ static irqreturn_t
> mtk_dp_hpd_event_thread(int hpd, void *dev)
> unsigned long flags;
> u32 status;
>
> + if (mtk_dp->need_debounce && mtk_dp-
> >train_info.cable_plugged_in)
> + msleep(100);
> +
> spin_lock_irqsave(&mtk_dp->irq_thread_lock, flags);
> status = mtk_dp->irq_thread_handle;
> mtk_dp->irq_thread_handle = 0;
> spin_unlock_irqrestore(&mtk_dp->irq_thread_lock, flags);
>
> - if (status & MTK_DP_THREAD_CABLE_STATE_CHG)
> + if (status & MTK_DP_THREAD_CABLE_STATE_CHG) {
> drm_helper_hpd_irq_event(mtk_dp->bridge.dev);
>
> + if (!mtk_dp->train_info.cable_plugged_in) {
> + mtk_dp->need_debounce = false;
> + mod_timer(&mtk_dp->debounce_timer,
> + jiffies + msecs_to_jiffies(100) - 1);
> + }
> + }
> +
> if (status & MTK_DP_THREAD_HPD_EVENT)
> dev_dbg(mtk_dp->dev, "Receive IRQ from sink
> devices\n");
>
> @@ -1996,6 +2008,13 @@ static const struct drm_bridge_funcs
> mtk_dp_bridge_funcs = {
> .detect = mtk_dp_bdg_detect,
> };
>
> +static void mtk_dp_debounce_timer(struct timer_list *t)
> +{
> + struct mtk_dp *mtk_dp = from_timer(mtk_dp, t, debounce_timer);
> +
> + mtk_dp->need_debounce = true;
> +}
> +
> static int mtk_dp_probe(struct platform_device *pdev)
> {
> struct mtk_dp *mtk_dp;
> @@ -2069,6 +2088,9 @@ static int mtk_dp_probe(struct platform_device
> *pdev)
>
> drm_bridge_add(&mtk_dp->bridge);
>
> + mtk_dp->need_debounce = true;
> + timer_setup(&mtk_dp->debounce_timer, mtk_dp_debounce_timer, 0);
> +
> pm_runtime_enable(dev);
> pm_runtime_get_sync(dev);
>
> @@ -2081,6 +2103,7 @@ static int mtk_dp_remove(struct platform_device
> *pdev)
>
> pm_runtime_put(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> + del_timer_sync(&mtk_dp->debounce_timer);
> drm_bridge_remove(&mtk_dp->bridge);
> platform_device_unregister(mtk_dp->phy_dev);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-02 9:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 4:41 [PATCH v17 00/10] Add MT8195 DisplayPort driver Bo-Chen Chen
2022-09-01 4:41 ` [PATCH v17 01/10] dt-bindings: mediatek,dp: Add Display Port binding Bo-Chen Chen
2022-09-01 4:41 ` [PATCH v17 02/10] video/hdmi: Add audio_infoframe packing for DP Bo-Chen Chen
2022-09-04 14:56 ` Dmitry Osipenko
2022-09-01 4:41 ` [PATCH v17 03/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver Bo-Chen Chen
2022-09-02 7:17 ` CK Hu
2022-09-06 0:07 ` Chun-Kuang Hu
2022-09-01 4:41 ` [PATCH v17 04/10] drm/mediatek: dp: Add multiple bridge types support Bo-Chen Chen
2022-09-02 7:22 ` CK Hu
2022-09-01 4:41 ` [PATCH v17 05/10] drm/mediatek: dp: Add multiple smc commands support Bo-Chen Chen
2022-09-02 7:32 ` CK Hu
2022-09-01 4:41 ` [PATCH v17 06/10] drm/mediatek: dp: Add multiple calibration data formats support Bo-Chen Chen
2022-09-02 7:38 ` CK Hu
2022-09-01 4:41 ` [PATCH v17 07/10] drm/mediatek: dp: Determine device of next_bridge Bo-Chen Chen
2022-09-02 7:44 ` CK Hu
2022-09-01 4:41 ` [PATCH v17 08/10] drm/mediatek: dp: Add MT8195 External DisplayPort support Bo-Chen Chen
2022-09-02 8:07 ` CK Hu
2022-09-01 4:41 ` [PATCH v17 09/10] drm/mediatek: dp: Add hpd debounce Bo-Chen Chen
2022-09-02 8:12 ` CK Hu [this message]
2022-09-01 4:41 ` [PATCH v17 10/10] drm/mediatek: dp: Audio support for MT8195 Bo-Chen Chen
2022-09-02 8:57 ` CK Hu
2022-09-01 10:58 ` [PATCH v17 00/10] Add MT8195 DisplayPort driver AngeloGioacchino Del Regno
2022-09-04 12:59 ` Dmitry Osipenko
2022-09-05 10:53 ` Dmitry Osipenko
2022-09-06 0:35 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa57b7e392ce8dac005dd572963a8844a7070007.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liangxu.xu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).