From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6ACC433FF for ; Wed, 31 Jul 2019 04:33:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACC36206A3 for ; Wed, 31 Jul 2019 04:33:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HCNvqbu0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACC36206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MWkDUMlpEtfasZd/CSd3gQQoOORYgfQJp87HCkUWEU8=; b=HCNvqbu0hBwOms iXFwos8h46Syg7LAHYNnBtRM08Blb9fU3Yw0pQ+X1liPWsdHcR/Sorh2JxNzMh27XRrMy5BEAsoyb /xx6ZzwrWE3t/fm5Y7cygDuImkX8ej4msRD5oT/t/79yfqYyTbLoZZQE4S75ACmB3anQaxuB2Ohs0 8cljX5GD1YVFZLCcR+VxlFnjss/xHLCt2gWJPn0IvZv6ZTswyZcCJw/BLhAF4A6tS8ge/HWPyuCkn GyR66uMUa3GYBb3xPjn5sj+znxw/kMXpdWNsAY++3xhoGOabU1meQODGX4qJsZXx+RpInnLqhMLIe rnF1SHrn5NKZaY0DsTrw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsgIf-00083I-JX; Wed, 31 Jul 2019 04:33:17 +0000 Received: from lb1-smtp-cloud7.xs4all.net ([194.109.24.24]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsgIc-0007sA-6k; Wed, 31 Jul 2019 04:33:16 +0000 Received: from [IPv6:2001:983:e9a7:1:a003:9a19:9f18:5372] ([IPv6:2001:983:e9a7:1:a003:9a19:9f18:5372]) by smtp-cloud7.xs4all.net with ESMTPA id sgIYh2UxBur8TsgIZhB7oo; Wed, 31 Jul 2019 06:33:11 +0200 Subject: Re: [PATCH v8 00/14] Rockchip ISP1 Driver From: Hans Verkuil To: Helen Koike , linux-rockchip@lists.infradead.org References: <20190730184256.30338-1-helen.koike@collabora.com> <41e7e574-2708-eb4c-ea30-e6a1ac9c073e@collabora.com> <8ce532de-6c26-f8db-8754-c8dd1eb0764b@collabora.com> <74bb0ba1-2859-39ff-d946-129a440ba150@xs4all.nl> Message-ID: Date: Wed, 31 Jul 2019 06:33:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <74bb0ba1-2859-39ff-d946-129a440ba150@xs4all.nl> Content-Language: en-US X-CMAE-Envelope: MS4wfEaWO9wIFWm8X+G7TYQwIadLRFXiGM7jx6AHCtLf88bMkZ2Bzi3fT6ovkUy5dg9H734PKmhtKSn28Kl0V5z2nXAfF55ZUJehCnTKFrLSEbfHbYCMVj0V AdK4qCjivJzIPZAxYnRLbxZuYQPi2DII98Iq4GMGm1Pdh+0MPMibGL/RspqvqcwkpxsESqJDnYol38s183u3MMC8CteYV9rK0J8UtoUIgimlCIffgCkicd1y v6bSOrSlDoAqfENUPdzoYP4kL6BBiddJwgBk+gCTwa4MSB9WddH7CGDTdfdN7JxhOfLAbBip9rscpaCopmE6PMNkz0/InnEnNDdb5rRL4h7cbq6lfigdBBdr DcdlkXhiJi4N98aBRuLL+T6uOLaJTWtB1KrS3U+iJyeEfXflY1no8/QIA9zJA4MHduEYYCTlVTAxFz/Uj5eYe+bjK8A4MW2byCizEcGtTOrgejHErtKbcuNr 45W/HpOE6wM7dRT4LnQ2pgkT2gptz9/sIXgOLM7yNARhYB6cl4kCqgYoBmJp0eIZOrRLRcMD3aCpjXriwA5Vo2a5tiDOAs/YenYb8NV0QBBvtLkMrkglUjRe dP/3S1W5wuDNRhVwn8Qk+WubDlmdR+yDWqt80MUHWJ2cHzGlSJglDhk2xQm6r5osHBsos7eODGO2xwD4hF2DnEr6eJlY3a6PzuB4HfW+cis62LGTFNwrPYp7 eXuBQPWn69n4V9IV3GaXIOoZ2dS0vYD7gh3cNmJObqDOl51gODwzcV2qEAKD6aNLoZVrW0Lq7WStOVlgl6MFOM7+5YQySO3NtGZtYh9sWfIA4vfdE1mNmWoQ RC6nCFIb+tvbJJlCznXJZQjSn66Gjy8+hS4JUstjk0C2Zk/VuaRONpc+s91B0IeBcPd7aWIEw3eJQcRDqJzE/a+VbRVmYoMjd5EI6GiE X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190730_213314_415618_D1BDF485 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, eddie.cai.linux@gmail.com, kernel@collabora.com, heiko@sntech.de, zhengsq@rock-chips.com, jeffy.chen@rock-chips.com, zyc@rock-chips.com, linux-kernel@vger.kernel.org, tfiga@chromium.org, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, mchehab@kernel.org, ezequiel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/31/19 6:29 AM, Hans Verkuil wrote: > On 7/31/19 2:08 AM, Helen Koike wrote: >> >> >> On 7/30/19 5:50 PM, Helen Koike wrote: >>> >>> >>> On 7/30/19 5:15 PM, Hans Verkuil wrote: >>>> On 7/30/19 8:42 PM, Helen Koike wrote: >>>>> Hello, >>>>> >>>>> I'm re-sending a new version of ISP(Camera) v4l2 driver for rockchip >>>>> rk3399 SoC. >>>>> >>>>> I didn't change much from the last version, just applying the >>>>> suggestions made in the previous one. >>>>> >>>>> This patchset is also available at: >>>>> https://gitlab.collabora.com/koike/linux/tree/rockchip/isp/v8 >>>>> >>>>> Libcamera patched to work with this version: >>>>> https://gitlab.collabora.com/koike/libcamera >>>>> (also sent to the mailing list) >>>>> >>>>> I tested on the rockpi 4 with a rpi v1.3 sensor and also with the >>>>> Scarlet Chromebook. >>>>> >>>>> Known issues (same as in v7): >>>>> ------------- >>>>> - Reloading the module doesn't work (there is some missing cleanup when >>>>> unloading) >>>>> - When capturing in bayer format, changing the size doesn't seem to >>>>> affect the image. >>>>> - crop needs more tests >>>>> - v4l2-compliance error: >>>>> fail: v4l2-test-controls.cpp(824): subscribe event for control 'Image Processing Controls' failed >>>>> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL >>>> >>>> Can you mail me the full v4l2-compliance output? >>> >>> Sure, please check here: http://ix.io/1Q5u >>> I updated v4l-utils with the latest version and I re-ran bootstrap/configure/make, >>> but for some reason the hash from the link above is not the latest commit, probably some >>> old configuration somewhere. I'll resend this log as soon as I get v4l2-compliance >>> properly updated. >> >> Please see the output of v4l2-compliance here with an updated v4l-utils: http://ix.io/1Q6A > > So this FAIL is for /dev/v4l-subdev0 (rkisp1-isp-subdev). > > What is weird that this subdev does not appear to have controls at all. > > What is the output of 'v4l2-ctl -d /dev/v4l-subdev0 -l'? And if it lists > controls, then why? > > If you run 'v4l2-compliance -u /dev/v4l-subdev0', do you get a fail as > well? I see the same issue with v4l-subdev1, but I see no "Media Driver Info" in the v4l2-compliance output for that subdev. That's strange. It would be good to know why that's happening. Regards, Hans > > BTW, note that struct rkisp1_isp_subdev has a ctrl_handler field that > isn't used at all. > > Regards, > > Hans > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel