From: Randy Dunlap <rdunlap@infradead.org>
To: Quan Nguyen <quan@os.amperecomputing.com>,
Corey Minyard <minyard@acm.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Brendan Higgins <brendanhiggins@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Wolfram Sang <wsa@kernel.org>,
openipmi-developer@lists.sourceforge.net,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Cc: Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: Re: [PATCH v8 1/3] ipmi: ssif_bmc: Add SSIF BMC driver
Date: Thu, 16 Jun 2022 08:02:22 -0700 [thread overview]
Message-ID: <fb8e7e35-7f26-15bc-9fbb-2949fc80a18b@infradead.org> (raw)
In-Reply-To: <74f94464-a095-f539-746a-853b8f1d52ca@os.amperecomputing.com>
On 6/16/22 00:25, Quan Nguyen wrote:
> On 15/06/2022 23:06, Randy Dunlap wrote:
>>
>>
>> On 6/15/22 02:02, Quan Nguyen wrote:
>>> diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
>>> index b061e6b513ed..18a89093d64e 100644
>>> --- a/drivers/char/ipmi/Kconfig
>>> +++ b/drivers/char/ipmi/Kconfig
>>> @@ -169,6 +169,17 @@ config ASPEED_BT_IPMI_BMC
>>> found on Aspeed SOCs (AST2400 and AST2500). The driver
>>> implements the BMC side of the BT interface.
>>> +config SSIF_IPMI_BMC
>>> + tristate "SSIF IPMI BMC driver"
>>> + select I2C
>>
>> No. That should be:
>> depends on I2C
>>
>> We don't select an entire subsystem just to satisfy one driver.
>>
>>> + select I2C_SLAVE
>>> + help
>>> + This enables the IPMI SMBus system interface (SSIF) at the
>>> + management (BMC) side.
>>> +
>>> + The driver implements the BMC side of the SMBus system
>>> + interface (SSIF).
>>> +
>>
>> Thanks.
>
> Thanks Randy,
> it should be change to "depends on I2C && I2C_SLAVE"
Either way is OK for I2C_SLAVE AFAIK.
thanks.
--
~Randy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-16 15:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 9:02 [PATCH v8 0/3] Add SSIF BMC driver Quan Nguyen
2022-06-15 9:02 ` [PATCH v8 1/3] ipmi: ssif_bmc: " Quan Nguyen
2022-06-15 16:06 ` Randy Dunlap
2022-06-16 7:25 ` Quan Nguyen
2022-06-16 15:02 ` Randy Dunlap [this message]
2022-06-16 10:47 ` Ryan Chen
2022-06-20 7:28 ` Quan Nguyen
2022-06-16 20:04 ` kernel test robot
2022-06-16 20:47 ` Christophe JAILLET
2022-06-20 7:16 ` Quan Nguyen
2022-06-15 9:02 ` [PATCH v8 2/3] bindings: ipmi: Add binding for " Quan Nguyen
2022-06-27 22:00 ` Rob Herring
2022-06-29 8:02 ` Quan Nguyen
2022-06-15 9:02 ` [PATCH v8 3/3] i2c: aspeed: Assert NAK when slave is busy Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb8e7e35-7f26-15bc-9fbb-2949fc80a18b@infradead.org \
--to=rdunlap@infradead.org \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openbmc@lists.ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).