Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] arm64: dts: qcom: msm8996: Rename smmu nodes
       [not found] <20190618052441.32306-1-bjorn.andersson@linaro.org>
@ 2019-06-18  7:39 ` Marc Gonzalez
  2019-06-18 20:04   ` Bjorn Andersson
  0 siblings, 1 reply; 2+ messages in thread
From: Marc Gonzalez @ 2019-06-18  7:39 UTC (permalink / raw)
  To: Bjorn Andersson, Andy Gross, Rob Herring; +Cc: MSM, Linux ARM

On 18/06/2019 07:24, Bjorn Andersson wrote:

> Node names shouldn't include "qcom," and should whenever possible use
> a generic identifier. Resolve this by renaming the smmu nodes "iommu".

You mention "qcom" here, but the prefix you changed is "arm"
/me confused ^_^


>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 2ecd9d775d61..c934e00434c7 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1163,7 +1163,7 @@
>  			};
>  		};
>  
> -		vfe_smmu: arm,smmu@da0000 {
> +		vfe_smmu: iommu@da0000 {
>  			compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
>  			reg = <0xda0000 0x10000>;
>  
> @@ -1314,7 +1314,7 @@
>  			};
>  		};
>  
> -		adreno_smmu: arm,smmu@b40000 {
> +		adreno_smmu: iommu@b40000 {
>  			compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
>  			reg = <0xb40000 0x10000>;
>  
> @@ -1331,7 +1331,7 @@
>  			power-domains = <&mmcc GPU_GDSC>;
>  		};
>  
> -		mdp_smmu: arm,smmu@d00000 {
> +		mdp_smmu: iommu@d00000 {
>  			compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
>  			reg = <0xd00000 0x10000>;
>  
> @@ -1347,7 +1347,7 @@
>  			power-domains = <&mmcc MDSS_GDSC>;
>  		};
>  
> -		lpass_q6_smmu: arm,smmu-lpass_q6@1600000 {
> +		lpass_q6_smmu: iommu@1600000 {
>  			compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
>  			reg = <0x1600000 0x20000>;
>  			#iommu-cells = <1>;
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: qcom: msm8996: Rename smmu nodes
  2019-06-18  7:39 ` [PATCH] arm64: dts: qcom: msm8996: Rename smmu nodes Marc Gonzalez
@ 2019-06-18 20:04   ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2019-06-18 20:04 UTC (permalink / raw)
  To: Marc Gonzalez; +Cc: MSM, Andy Gross, Linux ARM, Rob Herring

On Tue 18 Jun 00:39 PDT 2019, Marc Gonzalez wrote:

> On 18/06/2019 07:24, Bjorn Andersson wrote:
> 
> > Node names shouldn't include "qcom," and should whenever possible use
> > a generic identifier. Resolve this by renaming the smmu nodes "iommu".
> 
> You mention "qcom" here, but the prefix you changed is "arm"
> /me confused ^_^
> 

Thanks for proof reading my patches Marc
I'll respin this.

Regards,
Bjorn

> 
> >  arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > index 2ecd9d775d61..c934e00434c7 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > @@ -1163,7 +1163,7 @@
> >  			};
> >  		};
> >  
> > -		vfe_smmu: arm,smmu@da0000 {
> > +		vfe_smmu: iommu@da0000 {
> >  			compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> >  			reg = <0xda0000 0x10000>;
> >  
> > @@ -1314,7 +1314,7 @@
> >  			};
> >  		};
> >  
> > -		adreno_smmu: arm,smmu@b40000 {
> > +		adreno_smmu: iommu@b40000 {
> >  			compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> >  			reg = <0xb40000 0x10000>;
> >  
> > @@ -1331,7 +1331,7 @@
> >  			power-domains = <&mmcc GPU_GDSC>;
> >  		};
> >  
> > -		mdp_smmu: arm,smmu@d00000 {
> > +		mdp_smmu: iommu@d00000 {
> >  			compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> >  			reg = <0xd00000 0x10000>;
> >  
> > @@ -1347,7 +1347,7 @@
> >  			power-domains = <&mmcc MDSS_GDSC>;
> >  		};
> >  
> > -		lpass_q6_smmu: arm,smmu-lpass_q6@1600000 {
> > +		lpass_q6_smmu: iommu@1600000 {
> >  			compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> >  			reg = <0x1600000 0x20000>;
> >  			#iommu-cells = <1>;
> > 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190618052441.32306-1-bjorn.andersson@linaro.org>
2019-06-18  7:39 ` [PATCH] arm64: dts: qcom: msm8996: Rename smmu nodes Marc Gonzalez
2019-06-18 20:04   ` Bjorn Andersson

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox