From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3F9C47082 for ; Thu, 3 Jun 2021 14:28:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D229613BA for ; Thu, 3 Jun 2021 14:28:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D229613BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rPNcVn8zVBNew7UUUne3BKoDkUdPWsXrk2IQl7xwE2g=; b=rBcVIr19j7Ce8vkqwNfFfnyF+W v8fBlpTT1VqVysXPJ7yZrUrxDagNcuu+u4OvrJZ10KgseHDLsk7mQAwyvjn1vUjD5lplaLmokbsF6 gxK3PapKYcwgRBzvRMCIQrlIlPP+RcdbmJiKHzEgrJpFXq6GE0P2MrpDYlwzLrk7KUkwdl9uwVY5E 6Aa9QNu7WKHPcvSYWWM2Fn9fDPFez3joDyIEtfdbw7MceM197TCsGrxzORZt+zyBiXjsMOAuyEBlH L3v5X6SGzNG8YwaCPtT2EetcR/s5t2SsRSt1KfX2Z6tdfdkC+ulIZu+iCm2cUEZn3Kx+PMkKaMxhO KVBxjkuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1looJW-0099qQ-QK; Thu, 03 Jun 2021 14:27:15 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1looJN-0099lx-AT for linux-arm-kernel@lists.infradead.org; Thu, 03 Jun 2021 14:27:09 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1looJJ-0007gc-51; Thu, 03 Jun 2021 16:27:01 +0200 Subject: Re: [PATCH] ARM: dts: stm32: set stm32mp157c-odyssey DCMI pins To: Grzegorz Szymaszek , Alexandre Torgue , Maxime Coquelin , Marcin Sloniewski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: From: Ahmad Fatoum Message-ID: Date: Thu, 3 Jun 2021 16:26:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210603_072705_424463_C0DDF1FD X-CRM114-Status: GOOD ( 22.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Grzegorz, On 03.06.21 16:23, Grzegorz Szymaszek wrote: > The Seeed Odyssey-STM32MP157C board has a 20-pin DVP camera output. > stm32mp15-pinctrl.dtsi contains one pin state definition for the DCMI > interface, dcmi-0, AKA phandle dcmi_pins_a. This definition is > incompatible with the pins used on the Odyssey board, where: > - there are 8 data pins instead of 12, > - DCMI_HSYNC is available at PA4 instead of PH8, > - DCMI_D0 is at PC6 instead of PH9, > - DCMI_D3 is at PE1 instead of PH12, > - DCMI_D4 is at PE11 instead of PH14, > - DCMI_D5 is at PD3 instead of PI4, > - DCMI_D6 is at PE13 instead of PB8, > - DCMI_D7 is at PB9 instead of PE6. > > Override the dcmi_pins_a definition (as well as dcmi_sleep_pins_a) in > the Odyssey device tree. Rather define a new pinctrl group (e.g. &dcmi_pins_b) and use that instead of overriding an existing one. Current convention is also to place all STM32MP1 pinctrl nodes into a central file, not in the individual board device trees. Cheers, Ahmad > > Signed-off-by: Grzegorz Szymaszek > --- > arch/arm/boot/dts/stm32mp157c-odyssey.dts | 32 +++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32mp157c-odyssey.dts b/arch/arm/boot/dts/stm32mp157c-odyssey.dts > index be1dd5e9e744..2d6cf70ca623 100644 > --- a/arch/arm/boot/dts/stm32mp157c-odyssey.dts > +++ b/arch/arm/boot/dts/stm32mp157c-odyssey.dts > @@ -22,6 +22,38 @@ chosen { > }; > }; > > +&dcmi_pins_a { > + pins { > + pinmux = ,/* DCMI_HSYNC */ > + ,/* DCMI_VSYNC */ > + ,/* DCMI_PIXCLK */ > + ,/* DCMI_D0 */ > + ,/* DCMI_D1 */ > + ,/* DCMI_D2 */ > + ,/* DCMI_D3 */ > + ,/* DCMI_D4 */ > + ,/* DCMI_D5 */ > + ,/* DCMI_D6 */ > + ;/* DCMI_D7 */ > + }; > +}; > + > +&dcmi_sleep_pins_a { > + pins { > + pinmux = ,/* DCMI_HSYNC */ > + ,/* DCMI_VSYNC */ > + ,/* DCMI_PIXCLK */ > + ,/* DCMI_D0 */ > + ,/* DCMI_D1 */ > + ,/* DCMI_D2 */ > + ,/* DCMI_D3 */ > + ,/* DCMI_D4 */ > + ,/* DCMI_D5 */ > + ,/* DCMI_D6 */ > + ;/* DCMI_D7 */ > + }; > +}; > + > ðernet0 { > status = "okay"; > pinctrl-0 = <ðernet0_rgmii_pins_a>; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel