From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FA19C38145 for ; Thu, 8 Sep 2022 15:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PhSrgjpUUVzqRnd+Tm+IOzQ2hBDOc3D5siAje8cu+0Q=; b=xv34gydumdYCuy v2t29KPHBoWD73Q1ZCfCyztynsWISOGZYUlM7BjqFHmavkCCc4K2ZthgGn5J6x2rkHTn/saIHBpSJ dXSpzfGiE4Xh42IX3sn6Oa0gy+FMf4/jHwBTcXuoX76JBXHVhtFm9G2zTWAaOGEvijBxI5o8cu8j7 uPPH4+j/N+bzqASQRFe93bhvkEz/x9et+ewmyTKRbiR2Zh7N5FD1Cg/vRRX50FOAHEPtyrKB+BMze jJIjiY9QlNbhn26ALqDjr9Q9oIJXtCGlI839MIS0PhaqTbl50h6tUOv8i51dhSSSFmHWAcEqqy3Ef 9sPSsncMyAt1OEIRHVtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWJCy-0055qj-Jk; Thu, 08 Sep 2022 15:12:50 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWJ6p-0052iu-0e for linux-arm-kernel@lists.infradead.org; Thu, 08 Sep 2022 15:06:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1662649588; x=1694185588; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=RUeJwtCm1cm0sz+vxCvvwhXHOenkwC5gvRoeep4Cofk=; b=PRRetfRbd2SmTxw312Lq3OvLufF6GYI7aAu1xds9P/GmHZZLXPwgWIqg KRdUbw6kYMHd6/BTFrjAn5iWcFbd+L9PY7GHzSS4a3Z2JtCgniOMwsdCz SlEvNlFSC5Ogrpb7At3hOmkEUulccJMzWlzu6dqnZo6U7gy5HXgGtUMTJ Xovd1NPHLQJpIIPIvcsNoZeg36RkKAGZiFRYPCU/b8PkqF8aK9AjBAfFI e7QZ0il44IygCHqwn5KVtTkLDg2BAvrWmES+taZjQTsO0sD8sDUA0C8xD zUaaorjPjJtXzjeJwEvtOmEfu7YNJ1Jo/RiSzdUV+wxsk+CM3SwlmbWv2 Q==; X-IronPort-AV: E=Sophos;i="5.93,300,1654585200"; d="scan'208";a="179587794" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Sep 2022 08:06:24 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 8 Sep 2022 08:06:22 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Thu, 8 Sep 2022 08:06:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jNpl/sg7Rk5KfhsNaNP5eH598Uy9vjyimAp39J5O7fKyND7rqVA0ASRSsubDU3eW0p5d9/RUy8APweliX3nAhpnjWWvoXJuPacqJQXJ1dQ6waIgURPyiKsLsHlsbpmioyxVVwO0sLyVLnOM7OGnf89vNsYAZrQdCvAaK9NHZqAwQNWDJjxtS1xANrI6ypmENHXwt39239GMJFwD2deCFKpEOwThcEAxIGUmPcNazri81OUVbBh7YsZQ5R7pR/IYZllrdtebyrS4xQdGMY1Gu/alGL2sMCqFN4R7yOFoiqTAWldQtosOKakKUDOv63HMGjjlzMObYaVN1x+Ogyi4/EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RUeJwtCm1cm0sz+vxCvvwhXHOenkwC5gvRoeep4Cofk=; b=DdpbMm3c2nTr4mcdeJdTr86zxdeyJmNGX5sHEHgNvWB/fLlVBwZnsEo0R26Yy+IySyNyMB3fSATRI/k4wdTkbLwBC8DlFCaRgHVHEqu/HXEZHRMeeHLzc5RYTrXRqNK1Ic+eO20gWcWbgEcdl72qLkLVBlly33unwxL5yEKMLaqjeTzyzTYNbfYMneCbY9aZAGaNdEdfsFRderSM6Jvd5HwtxMqFdzyy6cLAXhZ3d6r/lUlUFsAL3EprXdqOKIULW0k2F63IybWcC230zx+32kGRaq6lMmFXyduoJab7gO963GumT1mOvfXayLAyH860yspeE3/ltmYYog8H3pnFwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RUeJwtCm1cm0sz+vxCvvwhXHOenkwC5gvRoeep4Cofk=; b=NB4+yK3QTijWdqYv7RRUvfYTVuT79dcGkDAYziNHBH42phCA8P4J5BmkQL0rYUrMQQI+9qwTBUA8SXNShWx2dHTJldD1XoZgGW67fLHnr96B7HZm5r2rSIDoytFlk4/wtIqg8h2iigKhfry5kOzFuU2vdWbu4e+yz5oqY+Dccts= Received: from BYAPR11MB2758.namprd11.prod.outlook.com (2603:10b6:a02:c9::11) by CY4PR11MB1783.namprd11.prod.outlook.com (2603:10b6:903:11d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.16; Thu, 8 Sep 2022 15:06:11 +0000 Received: from BYAPR11MB2758.namprd11.prod.outlook.com ([fe80::6852:5740:4bc9:d1b4]) by BYAPR11MB2758.namprd11.prod.outlook.com ([fe80::6852:5740:4bc9:d1b4%7]) with mapi id 15.20.5588.014; Thu, 8 Sep 2022 15:06:11 +0000 From: To: , , , , , , , , , , , , , , , , CC: , , , , , Subject: Re: [PATCH v2 05/13] dt-bindings: serial: atmel,at91-usart: convert to json-schema Thread-Topic: [PATCH v2 05/13] dt-bindings: serial: atmel,at91-usart: convert to json-schema Thread-Index: AQHYwfjByH4K4eAxe0ucv3xGn9LEXq3VeUyAgAAr1QA= Date: Thu, 8 Sep 2022 15:06:10 +0000 Message-ID: References: <20220906135511.144725-1-sergiu.moga@microchip.com> <20220906135511.144725-6-sergiu.moga@microchip.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a1b848dc-19d3-427f-e024-08da91abaa5a x-ms-traffictypediagnostic: CY4PR11MB1783:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q6GnVhVLozVa1eR5J2e+H7JPP7eymT27A7vyZvbE5OBZhcBXtex7NyVT7E/D5Et9uih2bRL4vEH79gP8g3QZw0DARwvN24+NqGiNDYshtqic5JGGknrb1/UuFIG6d22+0UFaB2P9CdXFe5ncbU57dTd/nzC24lQ6YjlCbXZTADf2XF6At+6BnpC6A7j7+bhdnc1cOJrxiQfdyTfKETDpNKDF+i4UdlI9sDb7QHTLIKktpIlMvCjzWc1p3GKiasaKwA+Q2bECmucuCkuXdeT993zYjfLmrkILFzuALbWkAfmnGIjxlft4NrirqmYEru7M8HpzLC2gsWdOH37AJiKuUGRhHhjRuKLbRBfZmsK8Rp/fxPn9fCDFLQb5UpbV36UBUqZgqAp0lQS/jSOA9XFtMU8i7T6J3nx5tY+c4y8L4i37aQ2ghYlNdLktIsifMFKL116Vr64+m7gUGYCzh6d2hjENQ1QgN10qEklkj/RhS1icp+1Xca5PdhaDS85qCE6A/9LsEvneQI8AYIXMEvtAPTyAV4HwFIXVczUdBkEeh6vTKvOCJhuCstFXFrL6uTAMWYd3DRN/2vv2z3b8wvyPqIwGZVxCdMh1GeKtx9csM5FZGNkOjDsLpeGi6IrQ5s8MCiJXHDURZVKKiGYMaW+WUqX0JiJtZYKcu6fj/KATVT8nO/bIV/b9Q1o3sF2jzGgAkLlAQuqerPL2rs/Y9kqKXXvgHnz65iS9Wt182Id6KolUg3O7k3ak6UsBeGzsfW5HU/EiNGm18HX58mU8oLxaZ5oSg0nUgu5hDkP9l8SkQDi9XPtvTk1OqwTn0wzRRgk3MJ3Lkt0ZD5dDqSNvb7y43nF2grPPIVjRocLc80j0EGif2FBbd6cOOAvp2qKATng2 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB2758.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(366004)(396003)(376002)(346002)(38100700002)(122000001)(83380400001)(186003)(2616005)(66556008)(7416002)(2906002)(31686004)(5660300002)(316002)(6636002)(31696002)(54906003)(110136005)(66946007)(8676002)(66476007)(8936002)(91956017)(64756008)(66446008)(4326008)(36756003)(76116006)(6512007)(508600001)(966005)(6486002)(71200400001)(53546011)(26005)(921005)(38070700005)(86362001)(6506007)(41300700001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R2lFUjlEMUcvc2lFdzVldEZlbk93YTBvZTlOTDlzWjJwUzJnUTdaUTFJUzQ5?= =?utf-8?B?QnhsaGtDKzNnSVhjTVJJcHNHbkJpeUFWM3VnRkNsK2kzVEF3bjJ1QWtiWVU2?= =?utf-8?B?MEJEV0svc05pNEZJeTVHbjRyMlJ3bDIwNGdJdDdXWmVVSDkyOHkyVUZqUm80?= =?utf-8?B?SFg3MWZDd05ONjdFaWNSUUhrcG0weVJlNUJOd1Vpdm5MaTlhY2VLdC9EK21k?= =?utf-8?B?NEJLQkhDanQ0QVU0SGFIbnhnVGxJbkR1OWhWNnVXczI0VTdidGtUeFp1eDhS?= =?utf-8?B?OVZBR2NUV2VydlBzNU5uaUN2ZmdJRWdQZXVvQmQyaE41a1FvOXoyVkpjU3NZ?= =?utf-8?B?bmRiZ0NkWGg4SCtpem54V0xIaFFnaDF3cDZmYTdHT1hRUUw4UmNGQllKUVlK?= =?utf-8?B?U1BkTU80NHV5ejJNeitsSlhqSVlWVGo1STIzcElnOUpiaVJzblViZ3hpdnll?= =?utf-8?B?YnpraEFPb0tBQk54b1BnbTFtNGhoYjhRQm5ieHZ4Rng4NGp6VSt5WHd5eEVm?= =?utf-8?B?T0dsQW5ocFg0bkRwL0F5Q2pKMlp6c2taNHMzcElPSndKVG9mdFhOVHE4K0g0?= =?utf-8?B?aXNlcEhSNEsxNmNXcFhDQ2d3MkJ6aVhPUnVkMUdWdXJWbHVkWjNGRTIrNW5S?= =?utf-8?B?T0FzQ21HVkMyWXpRd1VYZkM0SjZPR3NKWEZmTGNYR0t3UFdNb0xCWFFuajls?= =?utf-8?B?c28rMVlXY3F0bkd3NklON0lqTUk2ejMwTS91MGVNY1JaNXBpZnlIS2hJNUdx?= =?utf-8?B?UjFHaFNVMnArZkdzWkhwN01qd2tzbWtLOEZ0OEdmbE1GK2ZLTVc5Q21VZmdn?= =?utf-8?B?NUN5U1FuTVlrVjFqRGtWS29LNm5tWHRVMlo1bDdlV3VpSTEwUHljeFNQZ3Av?= =?utf-8?B?aE81NUJ6VGZUL1VhSDdNQmNqVkNOL28vUVU1Y21LSHVSQzJYSXZ6S1Z5Tmtp?= =?utf-8?B?WlYvWVhaRmtWbi94ZWMzU3RXK01EcC91azR3WGo5TUUwSCtLRWYyR1Q4L2Vx?= =?utf-8?B?QmFVRVdqd0dWbHpjK3c5RXVvdklDME1NazBJYWg3V1haYTlGTXd5NW84NTdm?= =?utf-8?B?QkdQSXNPSERCS3dscE9QVGx6ZzdaRDFySUNFT1BoalFmNEkyVVFrcFd2SmNE?= =?utf-8?B?a0NRaDJEM2s4SVUxVG02UEdodmFNdnFRTXZyT21RQjNnL0dMNkFUWXhjZ3hx?= =?utf-8?B?VE1nRFdKSTFvOTRvT2FQNE5idUZqa1JyeFNKWnFWNm91dyt6M21pd2tCUGV5?= =?utf-8?B?Uk5tK0lvcG13M2tJTFNXdWt0aXg2WDUvLzIxOUd3ekJrbkVqRElCeGVoemtO?= =?utf-8?B?cVl0NmFuL2RHMVlVS0Y5aXRQL01vMlM3THdFSG12bDhaajY3NE1pT1B5TUlH?= =?utf-8?B?OHRwdGVJVkJLUzV1ZEJGMkdNcTZaYjZra3VXZFBFL0d6eGVzK0liLytPK0ZG?= =?utf-8?B?LzMydGhtZmRHVFpRWno0UzlOMkhZcm1HS0FRaFpVNzVDN3BpalFFNDM3RmRF?= =?utf-8?B?ZndvSngwaVlreVFqOWhvQjgzSnRjcEdlOGZEK09lQU9YMmgrQlVxVTdKTVNv?= =?utf-8?B?OUlJaVZ6YWdQS0hDS0ZOb2ZudHU4dmxGSmhwVXJlUGFlcWMzS2k1MHhGS01G?= =?utf-8?B?dkI0RTNsWTJ1ODVoVVlnaldNQU5pOE80dTFwS1F0Y0VJcGZ2ZTVDSUd1allB?= =?utf-8?B?M2JxYmI3QlVPTU5FTUNkSmJ2TE5PaGFmTlEwdlNEdVA3Wjk3R2JpRCt6eWxY?= =?utf-8?B?M2dReS9NOU9saXdwTEthTTBHcm1JL0kyeHdRZUZteUNNYUgzL2ltRjZMUlpy?= =?utf-8?B?NjE3bmdoOEY2Z2pkQ1d1NnNjZzRxMjRmT3RHNjlBaldhalJUNUN2OEo2UWVn?= =?utf-8?B?dU8vRGVQY2RaK29OOUlNMnJSbEFGQ1liOFYvN1VXd21MZW1XRXNoRUhYYzBQ?= =?utf-8?B?MGxXQU83NkZLLzU5bVVNNjMrdHNCWlYyUXB0ZnZWeW00dVcxS0I2UFdFUmdt?= =?utf-8?B?SVZqRVR3RzkwQ1F6ekZKTTFFbFNtRHlmcWhqUngyejVBaWRkTTkyRGg5ck1o?= =?utf-8?B?L3lOWWQwMnJFYW41VTRBVkoxRXVwRGR6dWdTSmUwRmJFVEo4NEdrV3RJejRZ?= =?utf-8?Q?7bVx8TEmt2cFAphFLnqNJJI2j?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2758.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1b848dc-19d3-427f-e024-08da91abaa5a X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 15:06:10.9239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HcPHucPrUorNm1bBYS7hHGDRgCsCBlRGLfa/gEHC51Qyhte2t6Oh2u5vUabc52tBUYwpgEOQYRF67hltqwsFPlgXzyoc/SUrKeoc/ITmHog= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1783 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_080627_158573_A92E38CD X-CRM114-Status: GOOD ( 17.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08.09.2022 15:29, Krzysztof Kozlowski wrote: > On 06/09/2022 15:55, Sergiu Moga wrote: >> Convert at91 USART DT Binding for Atmel/Microchip SoCs to >> json-schema format. Furthermore, move this binding to the >> serial directory, since binding directories match hardware, >> unlike the driver subsystems which match Linux convention. >> >> Signed-off-by: Sergiu Moga >> --- >> >> >> >> v1 -> v2: >> - only do what the commit says, split the addition of other compatibles and >> properties in other patches >> - remove unnecessary "|"'s >> - mention header in `atmel,usart-mode`'s description >> - place `if:` under `allOf:` >> - respect order of spi0's DT properties: compatible, then reg then the reset of properties >> >> >> >> >> >> .../devicetree/bindings/mfd/atmel-usart.txt | 98 ---------- >> .../bindings/serial/atmel,at91-usart.yaml | 183 ++++++++++++++++++ >> 2 files changed, 183 insertions(+), 98 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-usart.txt >> create mode 100644 Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >> >> diff --git a/Documentation/devicetree/bindings/mfd/atmel-usart.txt b/Documentation/devicetree/bindings/mfd/atmel-usart.txt >> deleted file mode 100644 >> index a09133066aff..000000000000 >> --- a/Documentation/devicetree/bindings/mfd/atmel-usart.txt >> +++ /dev/null >> @@ -1,98 +0,0 @@ >> -* Atmel Universal Synchronous Asynchronous Receiver/Transmitter (USART) >> - >> -Required properties for USART: >> -- compatible: Should be one of the following: >> - - "atmel,at91rm9200-usart" >> - - "atmel,at91sam9260-usart" >> - - "microchip,sam9x60-usart" >> - - "atmel,at91rm9200-dbgu", "atmel,at91rm9200-usart" >> - - "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart" >> - - "microchip,sam9x60-dbgu", "microchip,sam9x60-usart" >> -- reg: Should contain registers location and length >> -- interrupts: Should contain interrupt >> -- clock-names: tuple listing input clock names. >> - Required elements: "usart" >> -- clocks: phandles to input clocks. >> - >> -Required properties for USART in SPI mode: >> -- #size-cells : Must be <0> >> -- #address-cells : Must be <1> >> -- cs-gpios: chipselects (internal cs not supported) >> -- atmel,usart-mode : Must be (found in dt-bindings/mfd/at91-usart.h) >> - >> -Optional properties in serial and SPI mode: >> -- dma bindings for dma transfer: >> - - dmas: DMA specifier, consisting of a phandle to DMA controller node, >> - memory peripheral interface and USART DMA channel ID, FIFO configuration. >> - The order of DMA channels is fixed. The first DMA channel must be TX >> - associated channel and the second one must be RX associated channel. >> - Refer to dma.txt and atmel-dma.txt for details. >> - - dma-names: "tx" for TX channel. >> - "rx" for RX channel. >> - The order of dma-names is also fixed. The first name must be "tx" >> - and the second one must be "rx" as in the examples below. >> - >> -Optional properties in serial mode: >> -- atmel,use-dma-rx: use of PDC or DMA for receiving data >> -- atmel,use-dma-tx: use of PDC or DMA for transmitting data >> -- {rts,cts,dtr,dsr,rng,dcd}-gpios: specify a GPIO for RTS/CTS/DTR/DSR/RI/DCD line respectively. >> - It will use specified PIO instead of the peripheral function pin for the USART feature. >> - If unsure, don't specify this property. >> -- atmel,fifo-size: maximum number of data the RX and TX FIFOs can store for FIFO >> - capable USARTs. >> -- rs485-rts-delay, rs485-rx-during-tx, linux,rs485-enabled-at-boot-time: see rs485.txt >> - >> - compatible description: >> -- at91rm9200: legacy USART support >> -- at91sam9260: generic USART implementation for SAM9 SoCs >> - >> -Example: >> -- use PDC: >> - usart0: serial@fff8c000 { >> - compatible = "atmel,at91sam9260-usart"; >> - reg = <0xfff8c000 0x4000>; >> - interrupts = <7>; >> - clocks = <&usart0_clk>; >> - clock-names = "usart"; >> - atmel,use-dma-rx; >> - atmel,use-dma-tx; >> - rts-gpios = <&pioD 15 GPIO_ACTIVE_LOW>; >> - cts-gpios = <&pioD 16 GPIO_ACTIVE_LOW>; >> - dtr-gpios = <&pioD 17 GPIO_ACTIVE_LOW>; >> - dsr-gpios = <&pioD 18 GPIO_ACTIVE_LOW>; >> - dcd-gpios = <&pioD 20 GPIO_ACTIVE_LOW>; >> - rng-gpios = <&pioD 19 GPIO_ACTIVE_LOW>; >> - }; >> - >> -- use DMA: >> - usart0: serial@f001c000 { >> - compatible = "atmel,at91sam9260-usart"; >> - reg = <0xf001c000 0x100>; >> - interrupts = <12 4 5>; >> - clocks = <&usart0_clk>; >> - clock-names = "usart"; >> - atmel,use-dma-rx; >> - atmel,use-dma-tx; >> - dmas = <&dma0 2 0x3>, >> - <&dma0 2 0x204>; >> - dma-names = "tx", "rx"; >> - atmel,fifo-size = <32>; >> - }; >> - >> -- SPI mode: >> - #include >> - >> - spi0: spi@f001c000 { >> - #address-cells = <1>; >> - #size-cells = <0>; >> - compatible = "atmel,at91rm9200-usart", "atmel,at91sam9260-usart"; >> - atmel,usart-mode = ; >> - reg = <0xf001c000 0x100>; >> - interrupts = <12 IRQ_TYPE_LEVEL_HIGH 5>; >> - clocks = <&usart0_clk>; >> - clock-names = "usart"; >> - dmas = <&dma0 2 AT91_DMA_CFG_PER_ID(3)>, >> - <&dma0 2 (AT91_DMA_CFG_PER_ID(4) | AT91_DMA_CFG_FIFOCFG_ASAP)>; >> - dma-names = "tx", "rx"; >> - cs-gpios = <&pioB 3 0>; >> - }; >> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >> new file mode 100644 >> index 000000000000..b25535b7a4d2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >> @@ -0,0 +1,183 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/serial/atmel,at91-usart.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Atmel Universal Synchronous Asynchronous Receiver/Transmitter (USART) >> + >> +maintainers: >> + - Richard Genoud >> + >> +properties: >> + compatible: >> + oneOf: >> + - enum: >> + - atmel,at91rm9200-usart >> + - atmel,at91sam9260-usart >> + - microchip,sam9x60-usart >> + - items: >> + - const: atmel,at91rm9200-dbgu >> + - const: atmel,at91rm9200-usart >> + - items: >> + - const: atmel,at91sam9260-dbgu >> + - const: atmel,at91sam9260-usart >> + - items: >> + - const: microchip,sam9x60-dbgu >> + - const: microchip,sam9x60-usart >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clock-names: >> + const: usart >> + >> + clocks: >> + maxItems: 1 >> + >> + dmas: >> + items: >> + - description: TX DMA Channel >> + - description: RX DMA Channel >> + >> + dma-names: >> + items: >> + - const: tx >> + - const: rx >> + >> + atmel,usart-mode: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Must be either for SPI or >> + for USART (found in dt-bindings/mfd/at91-usart.h). >> + enum: [ 0, 1 ] >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clock-names >> + - clocks >> + >> +allOf: >> + - if: >> + properties: >> + $nodename: >> + pattern: "^serial@[0-9a-f]+$" > > You should rather check value of atmel,usart-mode, because now you won't > properly match device nodes called "foobar". Since usart-mode has only > two possible values, this will nicely simplify you if-else. > > I did think of that but the previous binding specifies that atmel,usart-mode is required only for the SPI mode and it is optional for the USART mode. That is why I went for the node's regex since I thought it is something that both nodes would have. >> + then: >> + allOf: >> + - $ref: /schemas/serial/serial.yaml# >> + - $ref: /schemas/serial/rs485.yaml# >> + >> + properties: >> + atmel,use-dma-rx: >> + type: boolean >> + description: use of PDC or DMA for receiving data >> + >> + atmel,use-dma-tx: >> + type: boolean >> + description: use of PDC or DMA for transmitting data >> + >> + atmel,fifo-size: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Maximum number of data the RX and TX FIFOs can store for FIFO >> + capable USARTS. >> + enum: [ 16, 32 ] > > I did not mention it last time, but I think it should follow generic > practice, so define all properties top-level and disallow them for other > type. This allows you to simply use additionalProperties:false at the end. > What would be a good example binding in this case? >> + >> + else: >> + if: >> + properties: >> + $nodename: >> + pattern: "^spi@[0-9a-f]+$" >> + then: >> + allOf: >> + - $ref: /schemas/spi/spi-controller.yaml# >> + >> + properties: >> + atmel,usart-mode: >> + const: 1 >> + >> + "#size-cells": >> + const: 0 >> + >> + "#address-cells": >> + const: 1 > > The same - top level and disallow them for uart. > These values of #size-cells and #address-cells are only meant for the SPI so I guess I would still have to specify their mandatory const values here. >> + >> + required: >> + - atmel,usart-mode >> + - "#size-cells" >> + - "#address-cells" > > End else in this branch is what? > You are right, I will remove the useless if: after else: >> + >> +unevaluatedProperties: false >> + > > Best regards, > Krzysztof Regards, Sergiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel