From: Matthias Brugger <matthias.bgg@gmail.com>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Daniel Kurtz <djkurtz@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] soc: mediatek: Check if power domains can be powered on at boot time
Date: Thu, 1 Oct 2020 17:03:13 +0200 [thread overview]
Message-ID: <fe2f0eeb-ec21-5cf5-7cae-c17855bf0297@gmail.com> (raw)
In-Reply-To: <20200928113107.v2.1.I5e6f8c262031d0451fe7241b744f4f3111c1ce71@changeid>
On 28/09/2020 05:31, Nicolas Boichat wrote:
> In the error case, where a power domain cannot be powered on
> successfully at boot time (in mtk_register_power_domains),
> pm_genpd_init would still be called with is_off=false, and the
> system would later try to disable the power domain again, triggering
> warnings as disabled clocks are disabled again (and other potential
> issues).
>
> Also print a warning splat in that case, as this should never
> happen.
>
> Fixes: c84e358718a66f7 ("soc: Mediatek: Add SCPSYS power domain driver")
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Applied to v5.10-tmp/soc which will be v5.10-next/soc as soon as v5.10-rc1 gets
published.
Nicolas can you please make sure that similar logic will be part of the series
Enric is working on?
Thanks a lot.
Matthias
> ---
>
> Changes in v2:
> - Add WARN_ON if the domain can't be powered on, to make it more
> obvious that this should not happen (there is already an error
> message).
>
> drivers/soc/mediatek/mtk-scpsys.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
> index f669d3754627..ca75b14931ec 100644
> --- a/drivers/soc/mediatek/mtk-scpsys.c
> +++ b/drivers/soc/mediatek/mtk-scpsys.c
> @@ -524,6 +524,7 @@ static void mtk_register_power_domains(struct platform_device *pdev,
> for (i = 0; i < num; i++) {
> struct scp_domain *scpd = &scp->domains[i];
> struct generic_pm_domain *genpd = &scpd->genpd;
> + bool on;
>
> /*
> * Initially turn on all domains to make the domains usable
> @@ -531,9 +532,9 @@ static void mtk_register_power_domains(struct platform_device *pdev,
> * software. The unused domains will be switched off during
> * late_init time.
> */
> - genpd->power_on(genpd);
> + on = !WARN_ON(genpd->power_on(genpd) < 0);
>
> - pm_genpd_init(genpd, NULL, false);
> + pm_genpd_init(genpd, NULL, !on);
> }
>
> /*
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-01 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 3:31 [PATCH v2] soc: mediatek: Check if power domains can be powered on at boot time Nicolas Boichat
2020-10-01 15:03 ` Matthias Brugger [this message]
2020-10-05 1:08 ` Nicolas Boichat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe2f0eeb-ec21-5cf5-7cae-c17855bf0297@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=djkurtz@chromium.org \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).