From: Thomas Zimmermann <tzimmermann@suse.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, Sandy Huang <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Peter Robinson <pbrobinson@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: remove early framebuffers before registering the fbdev
Date: Sun, 16 May 2021 07:30:35 +0200 [thread overview]
Message-ID: <fe3285b7-3bc3-8292-bdc2-b8e823c1772d@suse.de> (raw)
In-Reply-To: <20210515221447.429779-1-javierm@redhat.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 2511 bytes --]
Hi
Am 16.05.21 um 00:14 schrieb Javier Martinez Canillas:
> There are drivers that register framebuffer devices very early in the boot
> process and make use of the existing framebuffer as setup by the firmware.
>
> If one of those drivers has registered a fbdev, then the fbdev registered
> by a DRM driver won't be bound to the framebuffer console. To avoid that,
> remove any early framebuffer before registering a DRM framebuffer device.
>
> By doing that, the fb mapped to the console is switched correctly from the
> early fbdev to the one registered by the rockchip DRM driver:
>
> [ 40.752420] fb0: switching to rockchip-drm-fb from EFI VGA
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
>
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> index 2fdc455c4ad..e3e5b63fdcc 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> @@ -4,6 +4,7 @@
> * Author:Mark Yao <mark.yao@rock-chips.com>
> */
>
> +#include <drm/drm_aperture.h>
> #include <drm/drm.h>
> #include <drm/drm_fb_helper.h>
> #include <drm/drm_fourcc.h>
> @@ -124,6 +125,15 @@ int rockchip_drm_fbdev_init(struct drm_device *dev)
>
> drm_fb_helper_prepare(dev, helper, &rockchip_drm_fb_helper_funcs);
>
> + /* Remove early framebuffers (e.g: simplefb or efifb) */
> + ret = drm_aperture_remove_framebuffers(false, "rockchip-drm-fb");
> + if (ret) {
> + DRM_DEV_ERROR(dev->dev,
> + "Failed to remove early framebuffers - %d.\n",
> + ret);
> + return ret;
> + }
> +
Such code used to be part of the fbdev helpers, but it's not really
related to fbdev functonality. Rather it controls ownership of the I/O
ranges.
This code block should be done at the very beginning; before the driver
tries to reserve the device's I/O ranges. Probably at [1]
Best regards
Thomas
[1]
https://elixir.bootlin.com/linux/v5.13-rc1/source/drivers/gpu/drm/rockchip/rockchip_drm_drv.c#L116
> ret = drm_fb_helper_init(dev, helper);
> if (ret < 0) {
> DRM_DEV_ERROR(dev->dev,
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-05-16 5:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 22:14 [PATCH] drm/rockchip: remove early framebuffers before registering the fbdev Javier Martinez Canillas
2021-05-16 5:30 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe3285b7-3bc3-8292-bdc2-b8e823c1772d@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pbrobinson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).