From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DBA7C4338F for ; Wed, 28 Jul 2021 16:24:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0C8C6101B for ; Wed, 28 Jul 2021 16:24:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E0C8C6101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AF6zj/1kJ40bypKmbIFQW2G8h9O88CsffcfDj4/zTDE=; b=LzxKVEkmt+mBNwHloIAoCa39vH EkX8STOfXNTrX1FtAK1bupoHt4bqX15+JkvWKYQZ3gxMwf0DYhYCi96HgVEOVi2WTKjoiAYAaXAsB gvK4tacIcpcPgNX6qUWxekOsGw/u1SYHvH+ATo1hK4U+cedn/LBuv5wypRoErYnpKGfuBmIbBbS6n nshl0C2hP/6lRcHWJsgMensp9maW2Vh4C3eSZ1Y2Vlm4BnJ5SPVMltAEaAOzVRWZKw6/t31bCQ21q urkhMfZ2jJidFU+rKUkEHY6aWBslHmz6J5Bex4Ll/eDRJ57YARr8h0xaAgEC8OxMf3OCXwfR/kYgB KtLqGsYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8mK2-001amx-2U; Wed, 28 Jul 2021 16:22:18 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8mCv-001XfD-Ki for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 16:14:59 +0000 Received: by mail-pj1-x1034.google.com with SMTP id j1so5890415pjv.3 for ; Wed, 28 Jul 2021 09:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XHepTzgLwPqN65zA0CSOOZE8+p0qfXTLJsI6vX6GqUc=; b=Qzw46NPHcQ03Zrp6maKJ20fbf0gQJDFibVuqn2kO0VIUCtMYrDLC/QJyV8Ba2QRq96 rD/C0lyrwL741Lw/xmBGiDt1JL0O8F89cVUoMrHutfu+ua6FN2np25wvSci2F3/lhxTo HNkFXs2L204rfSW4f6DxCJdzDMouNlryVIFKOmAzLfFhkNCGrpzSwMZUsMkQT87lthiW 5a9Gwyb5k533QBLGS9Yw54omPEEMwxYiaHZFpD2NMSy+9DhF8faFFSkNIrPQ6aaKeaLG 6MGolIfirTDGteRiZooDfERU69ptJT8c2GmPSLVC43XbUpZKkaAy53OfVkUzbtx320oN ikuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XHepTzgLwPqN65zA0CSOOZE8+p0qfXTLJsI6vX6GqUc=; b=SYE3ZUamrR1tVy5Wc4DkdHsLdbutR95Ivpu8evCZQMCLl6H2ZcwfObCJK+/hUHUuMa wYsRP6wX8Y48gT+MwVfQXDInY/Wfj9KeJAhOY1QbmzJiicuY1xODBK6RFetPi2//JG2R lxrsFeFTKZ/drLSdF44eE1M++LRaE0JgpHuOo90h+SIcaJ0fmLqZlTWx5W3ZBmA3/G7k +U3hOVbPowrS8Dkr3+lzeAZFfcS0+QvEgSf1wR1QRm9i1TQxUkJg/3JvVG+TYJf2B1u8 fOX0csULJxWLU30yG9KAhGCj3oa+u5NA5eqTMZRWMU+wc2fbCTQDhd/cHiimcQpTqmpt UL+w== X-Gm-Message-State: AOAM530bq+qzplhxqcOIImJy4SHKiJD6AIuJA19G7wABXQLiC0GFwH3O Oieur5uy0+LKW/5Ef6fDLJg= X-Google-Smtp-Source: ABdhPJzvYuXRjdX0pq4KCIAjjqbLq43MJBGO9FZNEDJv5hyI1cNk5s+7D+9tBmZK0IfNSgCTdXHoOQ== X-Received: by 2002:a17:90b:d8f:: with SMTP id bg15mr10129888pjb.152.1627488895725; Wed, 28 Jul 2021 09:14:55 -0700 (PDT) Received: from [192.168.1.121] (99-44-17-11.lightspeed.irvnca.sbcglobal.net. [99.44.17.11]) by smtp.gmail.com with ESMTPSA id x30sm445779pfh.126.2021.07.28.09.14.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 09:14:55 -0700 (PDT) Subject: Re: [PATCH] bcm63xx_enet: remove needless variable definitions To: Tang Bin , davem@davemloft.net, kuba@kernel.org, bcm-kernel-feedback-list@broadcom.com Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zhang Shengju References: <20210728132456.2540-1-tangbin@cmss.chinamobile.com> From: Florian Fainelli Message-ID: Date: Wed, 28 Jul 2021 09:14:53 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210728132456.2540-1-tangbin@cmss.chinamobile.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_091457_780321_E5C1948D X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/28/2021 6:24 AM, Tang Bin wrote: > In the function bcm_enetsw_probe(), 'ret' will be assigned by > bcm_enet_change_mtu(), so 'ret = 0' make no sense. You are not removing the variable definition or declaration, you are removing a redundant assignment which is a different thing. I do agree with the rationale however, so please fix up the subject and I will add my Acked-by to this patch. Thanks! > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin > --- > drivers/net/ethernet/broadcom/bcm63xx_enet.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c > index 916824cca..509e10013 100644 > --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c > +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c > @@ -2646,7 +2646,6 @@ static int bcm_enetsw_probe(struct platform_device *pdev) > if (!res_mem || irq_rx < 0) > return -ENODEV; > > - ret = 0; > dev = alloc_etherdev(sizeof(*priv)); > if (!dev) > return -ENOMEM; > -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel