From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5344EC28D13 for ; Mon, 22 Aug 2022 18:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aabEwfgE11QVYrXyAq7eZExJErH/jFgVkLH3upQ6Dvo=; b=L+fJuP495J+5J7 uaEWovvJoqxuK5zH38YG7XIrzTrDFAmBrNIak1g02OM/T9nC1uamxCvMhMJ4bIFOUCxs1z0pzpfWd MQWs5PX9O4wykRMW7UQkSvZIefalD3XsFgZRRNHr0Xv/l7uHa3mg+SpeHI5ot7aSl26QM7uPM2LVK 8MsmkOUIO4PW9Sqk26gFPjcSaDI4nwp0DBX1rWQXfpq44l9f5QmDY9vRw7m1kbURUokvg/xi8fpQS tulb318lrE3Qkr9pw02CNsNWNhd/9ruZ+zV0xdBqBg5vN0Xt/N9nsjNH1vTeqJyvl3dK3WNpjxCVO IAryNnAwwFukIoRNc9zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQC1b-00DUMd-85; Mon, 22 Aug 2022 18:19:48 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQC1R-00DUF3-2e for linux-arm-kernel@lists.infradead.org; Mon, 22 Aug 2022 18:19:41 +0000 Received: by mail-lf1-x12d.google.com with SMTP id m5so5779398lfj.4 for ; Mon, 22 Aug 2022 11:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=IUUq+zBZLLg7nojFWalzeoFMBrQ1c6+AbxuzsjXnnkg=; b=qwv6CgAI+Xx/7UTpw6T/ZwxnK4PJa+dbt690i+fuM/1sif7ZADV/O9QXCEJRlnKjZE Ru3jeVaAfUzF7cF34EncOm3b6aFamhkKhhbZVgtwmURwlLh9YyNsAUphwo08z8XJt49e Z5LgmPb66CsA24nrNJN9alP/0l7nQyZII/eRhuQheF6Vod3YIeBhxfDPDKReQL8CZePc NwOulHDWQMcwsM2rvkoCfNu4RsQsAYfxVI7j/fejE4eZen/g3YIXTyFDo4UOv5XcJakH lT2L0ox1+PS016xsibOIxwnTk8AKkWPHlEs+8ZabMrvevqIeLvPMJ1CDPgKAuuSB8NRd y10w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=IUUq+zBZLLg7nojFWalzeoFMBrQ1c6+AbxuzsjXnnkg=; b=Wu/atiH0bMzdRWAV1CeXEMMuqXhKzPkFeAkgfI9a4GxSmgBVFlu7pVOxJ2kuVOIXCm 6d4n9+mw+aEpe6FKBsBphLljQzhZOdaj+LYpjcIXMMJSUQuBD4C8RIsb4BdlZQi7mWf2 u2taJx77pmqXcB9KvLXIBRqnOqkOCX9OlKQPmN+rXOI/HfYvMTgudlDEp221d/b2c5yG +Dnqo61U+NxLxz2gajL1a9LcFtpkA9qUkFO4sc66zLNoUX1WER4rseCn19wQ54WzjN/q +YF2oy6VpgZF78grZsEt8LZBvhGQcGHcErx1XdqRsK/eqR6nzXJBmMUwcBxojt8bfGMJ GAvQ== X-Gm-Message-State: ACgBeo0Oyek08hvgMSnl7AEBxcZrTUzn7gOFqNlrK7F6pJ4L5CieMQwD ds7xSbktGVj1i+tLqEnAO4NyMQ== X-Google-Smtp-Source: AA6agR4NQSLOz5tBwgjn8bV1QR7qbJBs3EDjgJIHcoMa/jKzn+hSicxXOXpcYEVPQ7N2K9pjbl2zkg== X-Received: by 2002:ac2:4d45:0:b0:492:d8a2:de61 with SMTP id 5-20020ac24d45000000b00492d8a2de61mr4449767lfp.313.1661192371259; Mon, 22 Aug 2022 11:19:31 -0700 (PDT) Received: from [192.168.0.11] (89-27-92-210.bb.dnainternet.fi. [89.27.92.210]) by smtp.gmail.com with ESMTPSA id t5-20020a195f05000000b00491734dcb89sm2028163lfb.196.2022.08.22.11.19.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Aug 2022 11:19:30 -0700 (PDT) Message-ID: Date: Mon, 22 Aug 2022 21:19:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v6 04/17] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller bindings Content-Language: en-US To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, blarson@amd.com, brijeshkumar.singh@amd.com, catalin.marinas@arm.com, gsomlo@gmail.com, gerg@linux-m68k.org, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee.jones@linaro.org, broonie@kernel.org, yamada.masahiro@socionext.com, p.zabel@pengutronix.de, piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org, fancer.lancer@gmail.com, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, ulf.hansson@linaro.org, will@kernel.org, devicetree@vger.kernel.org References: <20220820195750.70861-1-brad@pensando.io> <20220820195750.70861-5-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: <20220820195750.70861-5-brad@pensando.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_111937_176957_160167AC X-CRM114-Status: GOOD ( 14.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/08/2022 22:57, Brad Larson wrote: > From: Brad Larson > > The AMD Pensando Elba SoC has integrated the DW APB SPI Controller > > Signed-off-by: Brad Larson > --- > .../devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index 37c3c272407d..403d6416f7ac 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -37,6 +37,15 @@ allOf: > else: > required: > - interrupts > + - if: > + properties: > + compatible: > + contains: > + enum: > + - amd,pensando-elba-spi > + then: > + required: > + - amd,pensando-elba-syscon There is no such property. You cannot make it required without first defining it. > > properties: > compatible: > @@ -75,6 +84,8 @@ properties: > - renesas,r9a06g032-spi # RZ/N1D > - renesas,r9a06g033-spi # RZ/N1S > - const: renesas,rzn1-spi # RZ/N1 > + - description: AMD Pensando Elba SoC SPI Controller > + const: amd,pensando-elba-spi Don't add stuff at the end, but in some logical (usually alphabetical) place. The order is already broken as everyone likes to add stuff in conflict-style, so just add it before baikal, for example. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel