From: Palmer Dabbelt <palmer@dabbelt.com>
To: krzk@kernel.org
Cc: heiko@sntech.de, paul@crapouillou.net, thierry.reding@gmail.com,
linux-riscv@lists.infradead.org, lee.jones@linaro.org,
f.fainelli@gmail.com, zhang.lyra@gmail.com, krzk@kernel.org,
linux-rockchip@lists.infradead.org, wens@csie.org,
bcm-kernel-feedback-list@broadcom.com,
u.kleine-koenig@pengutronix.de, orsonzhai@gmail.com,
linux-pwm@vger.kernel.org, rjui@broadcom.com, mripard@kernel.org,
linux-rpi-kernel@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-arm-kernel@lists.infradead.org, sbranden@broadcom.com,
linux-kernel@vger.kernel.org, baolin.wang7@gmail.com,
nsaenzjulienne@suse.de
Subject: Re: [PATCH 4/6] pwm: sifive: Simplify with dev_err_probe()
Date: Wed, 26 Aug 2020 09:22:24 -0700 (PDT) [thread overview]
Message-ID: <mhng-452a4fec-be33-4b49-a904-edb4b4c81e0c@palmerdabbelt-glaptop1> (raw)
In-Reply-To: <20200826144747.9436-4-krzk@kernel.org>
On Wed, 26 Aug 2020 07:47:45 PDT (-0700), krzk@kernel.org wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/pwm/pwm-sifive.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c
> index 62de0bb85921..2485fbaaead2 100644
> --- a/drivers/pwm/pwm-sifive.c
> +++ b/drivers/pwm/pwm-sifive.c
> @@ -254,11 +254,9 @@ static int pwm_sifive_probe(struct platform_device *pdev)
> return PTR_ERR(ddata->regs);
>
> ddata->clk = devm_clk_get(dev, NULL);
> - if (IS_ERR(ddata->clk)) {
> - if (PTR_ERR(ddata->clk) != -EPROBE_DEFER)
> - dev_err(dev, "Unable to find controller clock\n");
> - return PTR_ERR(ddata->clk);
> - }
> + if (IS_ERR(ddata->clk))
> + return dev_err_probe(dev, PTR_ERR(ddata->clk),
> + "Unable to find controller clock\n");
>
> ret = clk_prepare_enable(ddata->clk);
> if (ret) {
Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-26 16:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 14:47 [PATCH 1/6] pwm: bcm2835: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-08-26 14:47 ` [PATCH 2/6] pwm: jz4740: " Krzysztof Kozlowski
2020-09-02 7:12 ` Uwe Kleine-König
2020-08-26 14:47 ` [PATCH 3/6] pwm: rockchip: " Krzysztof Kozlowski
2020-09-02 7:13 ` Uwe Kleine-König
2020-08-26 14:47 ` [PATCH 4/6] pwm: sifive: " Krzysztof Kozlowski
2020-08-26 16:22 ` Palmer Dabbelt [this message]
2020-09-02 7:13 ` Uwe Kleine-König
2020-08-26 14:47 ` [PATCH 5/6] pwm: sprd: " Krzysztof Kozlowski
2020-08-27 2:01 ` Chunyan Zhang
2020-09-02 7:14 ` Uwe Kleine-König
2020-08-26 14:47 ` [PATCH 6/6] pwm: sun4i: " Krzysztof Kozlowski
2020-09-02 7:15 ` Uwe Kleine-König
2020-08-26 17:21 ` [PATCH 1/6] pwm: bcm2835: " Florian Fainelli
2020-09-02 7:12 ` Uwe Kleine-König
2020-09-23 11:59 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-452a4fec-be33-4b49-a904-edb4b4c81e0c@palmerdabbelt-glaptop1 \
--to=palmer@dabbelt.com \
--cc=baolin.wang7@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mripard@kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=orsonzhai@gmail.com \
--cc=paul.walmsley@sifive.com \
--cc=paul@crapouillou.net \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).