From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A07C4740A for ; Mon, 7 Oct 2019 08:02:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7934217F9 for ; Mon, 7 Oct 2019 08:02:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eccl2KEU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ILBNzhem" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7934217F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eLNV3Ctgbu9Q1tgB8q+k0mizpRK2vN6f8EGW5u6fJO0=; b=eccl2KEUT7rIXI KlAWGMD+i4N79A9bHvopp6HFGL7YnvlUbZaw2ZvQXh2JrR5k24iPMrg8zHYEyh72mRIbzzG8OfIBy 7+YuHGXy4RbJ5ps45y10r+JsIHg4HNvowkfzGCDQJdEMgAbbBGkkLnzUCsik3pjzzKn/4/AJ7jciW hM1q6Jvp8eUZeSRfllXwPv68VLbxAwpOpiY8TWybJwzC1IuiwRkj0Z+Jn02Njb5RXnNVpcreGC+D5 6Y7fIfvt9RjpMLWszQqG1fsYxxom2rm29XVQ5WwCQyAhLYK9iKRQMHJ3dFTOdQiKRzOdeUyod3/O6 RAs3oBkSmdxHmbQfDvBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHNyS-0005sg-6w; Mon, 07 Oct 2019 08:02:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHNyP-0005sK-BX for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2019 08:02:30 +0000 Received: from [10.33.87.18] (twin.jikos.cz [91.219.245.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8CECD20867; Mon, 7 Oct 2019 08:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570435348; bh=DbrpAfomurrCCdFD0IJeUwRw1yWRYID3uypVq0D8MQw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ILBNzhemPwPmbQnaC2LVrUnAx54C/R93wfWv1G86UaG8h1UKlITDQ2NQj8Y09JZjM B6xS9BAgcVSnQ/aOy+/+snNJS3s0TNmJiUt4QkMuI+50OcVJ03oqyCnztKugeo0x4g R+lPPA2M1btyA+m1tgijqbN/px5ni5HfUoG7g40Q= Date: Mon, 7 Oct 2019 10:02:11 +0200 (CEST) From: Jiri Kosina To: Will Deacon Subject: Re: [PATCH] panic: Ensure preemption is disabled during panic() In-Reply-To: <20191004104947.vbxe5kv3nbjxqs55@willie-the-truck> Message-ID: References: <20191002123538.22609-1-will@kernel.org> <201910021355.E578D2FFAF@keescook> <20191003205633.w26geqhq67u4ysit@willie-the-truck> <20191004091142.57iylai22aqpu6lu@pathway.suse.cz> <20191004092917.GY25745@shell.armlinux.org.uk> <20191004104947.vbxe5kv3nbjxqs55@willie-the-truck> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_010229_411128_715F2836 X-CRM114-Status: UNSURE ( 8.41 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , Feng Tang , Kees Cook , Greg Kroah-Hartman , contact@xogium.me, Russell King - ARM Linux admin , Steven Rostedt , linux-kernel@vger.kernel.org, Sergey Senozhatsky , Ingo Molnar , stable@vger.kernel.org, Andrew Morton , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 4 Oct 2019, Will Deacon wrote: > Indeed, and I think the LED blinking is already unreliable if the > brightness operation needs to sleep. One thing is that led_set_brightness() can probably be forced to avoid the workqueue scheduling, by setting LED_BLINK_SW on the device (e.g. by issuing led_set_software_blink() during panic). But I am afraid this still won't solve the issue completely, as USB keyboards need workqueues for blinking the LEDs in for URB management. -- Jiri Kosina SUSE Labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel