Linux-ARM-Kernel Archive on
 help / color / Atom feed
From: Nicolas Pitre <>
To: Stefan Agner <>
Subject: Re: [PATCH v2 0/5] ARM: convert to unified syntax
Date: Sun, 10 Feb 2019 16:24:45 -0500 (EST)
Message-ID: <nycvar.YSQ.7.76.1902101620430.2213@knanqh.ubzr> (raw)
In-Reply-To: <>

On Sun, 10 Feb 2019, Stefan Agner wrote:

> This patchset converts all assembly code to unified assembler
> language (UAL) compatible assembly code. From what I can tell,
> this mainly boils down to using conditional infixes instead of
> postfixes.
> Most of the conversion has been done using the following regular
> expression:
>   find ./arch/arm/ -name "*.[hSc]" -exec sed -i -r \
>     "s/^((\s*[._a-zA-Z0-9]*[\:\(])?\s*)([a-z]{3})(eq|ne|cs|hs|cc|lo|mi|pl|vs|vc|hi|ls|ge|lt|gt|le|al)([a-z]{1,2})(\s)/\1\3\5\4\6/"
> \
>     {} \;
> The expression resulted in some false positives and missed some
> instances where infix conditionals have been used. With this
> changes applied, I compiled several kernel configurations
> successfully and without a warning.
> The file arch/arm/probes/kprobes/test-arm.c is still using some
> divided syntax assembler.
> This does not allow to use LLVM's integrated assembler just yet,
> there is still some assembler which the integrated assembler does
> not like (yet). But it is a big step towards that direction.


Please document why you added .syntax unified in the commit log of each 
patch where this is added along with a link to the gcc PR.  Then you may 
add Acked-by: Nicolas Pitre <> to the whole series.


linux-arm-kernel mailing list

  parent reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 23:08 Stefan Agner
2019-02-09 23:08 ` [PATCH v2 1/5] ARM: use unified assembler in macros Stefan Agner
2019-02-09 23:08 ` [PATCH v2 2/5] ARM: use unified assembler in headers Stefan Agner
2019-02-09 23:09 ` [PATCH v2 3/5] ARM: use unified assembler in assembly files Stefan Agner
2019-02-09 23:09 ` [PATCH v2 4/5] ARM: use unified assembler in c files Stefan Agner
2019-02-09 23:09 ` [PATCH v2 5/5] ARM: warn if divided syntax assembler is used Stefan Agner
2019-02-11 18:03   ` Nick Desaulniers
2019-02-10 21:24 ` Nicolas Pitre [this message]
2019-02-12 19:31   ` [PATCH v2 0/5] ARM: convert to unified syntax Stefan Agner

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YSQ.7.76.1902101620430.2213@knanqh.ubzr \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on

Archives are clonable:
	git clone --mirror linux-arm-kernel/git/0.git
	git clone --mirror linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ \
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox