From: "Rakesh Pillai" <pillair@codeaurora.org>
To: "'Stephen Boyd'" <swboyd@chromium.org>, <agross@kernel.org>,
<bjorn.andersson@linaro.org>, <mathieu.poirier@linaro.org>,
<ohad@wizery.com>, <p.zabel@pengutronix.de>, <robh+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sibis@codeaurora.org>,
<mpubbise@codeaurora.org>, <kuabhs@chromium.org>
Subject: RE: [PATCH v8 3/3] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS
Date: Wed, 17 Nov 2021 12:01:51 +0530 [thread overview]
Message-ID: <000101d7db7c$d2ef1330$78cd3990$@codeaurora.org> (raw)
In-Reply-To: <CAE-0n53PSDzj9owjeaB1bGQ5=255=Q_djEvcQGtZzRxMRMhe1g@mail.gmail.com>
> -----Original Message-----
> From: Stephen Boyd <swboyd@chromium.org>
> Sent: Wednesday, November 17, 2021 4:25 AM
> To: Rakesh Pillai <pillair@codeaurora.org>; agross@kernel.org;
> bjorn.andersson@linaro.org; mathieu.poirier@linaro.org; ohad@wizery.com;
> p.zabel@pengutronix.de; robh+dt@kernel.org
> Cc: linux-arm-msm@vger.kernel.org; linux-remoteproc@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> sibis@codeaurora.org; mpubbise@codeaurora.org; kuabhs@chromium.org
> Subject: Re: [PATCH v8 3/3] remoteproc: qcom: q6v5_wpss: Add support for
> sc7280 WPSS
>
> Quoting Rakesh Pillai (2021-11-02 06:44:33)
> > @@ -457,7 +608,13 @@ static int adsp_probe(struct platform_device
> *pdev)
> > if (ret)
> > goto free_rproc;
> >
> > - pm_runtime_enable(adsp->dev);
> > + ret = qcom_rproc_pds_attach(adsp->dev, adsp->proxy_pds,
> > + desc->proxy_pd_names);
> > + if (ret < 0) {
> > + dev_err(&pdev->dev, "Failed to attach proxy power domains\n");
> > + goto free_rproc;
> > + }
> > + adsp->proxy_pd_count = ret;
>
> Can we check this against the define so that we don't have more than the
> fixed number of power domains and try to access elements beyond the
> length of the array?
The number of entries populated in the "proxy_pds" array depends on the "desc->proxy_pd_names", which is statically
initialized for each remoteproc. Hence there will not be any out of bound access for this array.
Thanks,
Rakesh Pillai.
next prev parent reply other threads:[~2021-11-17 6:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 13:44 [PATCH v8 0/3] Add support for sc7280 WPSS PIL loading Rakesh Pillai
2021-11-02 13:44 ` [PATCH v8 1/3] dt-bindings: remoteproc: qcom: adsp: Convert binding to YAML Rakesh Pillai
2021-11-12 18:41 ` Rob Herring
2021-11-15 23:40 ` Stephen Boyd
2021-11-02 13:44 ` [PATCH v8 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support Rakesh Pillai
2021-11-12 18:41 ` Rob Herring
2021-11-15 23:41 ` Stephen Boyd
2021-11-02 13:44 ` [PATCH v8 3/3] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS Rakesh Pillai
2021-11-15 23:43 ` Stephen Boyd
2021-11-16 17:49 ` pillair
2021-11-16 23:53 ` Stephen Boyd
2021-11-16 22:54 ` Stephen Boyd
2021-11-17 6:31 ` Rakesh Pillai [this message]
2021-11-17 6:39 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101d7db7c$d2ef1330$78cd3990$@codeaurora.org' \
--to=pillair@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kuabhs@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mpubbise@codeaurora.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).