From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
tiwai@suse.com, rohitkr@codeaurora.org,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Subject: Re: [PATCH v3 2/5] ASoC: dt-bindings: Add dt binding for lpass hdmi
Date: Fri, 4 Sep 2020 11:02:36 +0000 [thread overview]
Message-ID: <0101017458c84d4b-5236b891-5a8c-4edb-8ff3-bd1ceac88928-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <0aa914dd-6a6e-208d-d29f-214a84dfd8a2@linaro.org>
Thanks Srinivas For Review!!!
On 9/4/2020 4:11 PM, Srinivas Kandagatla wrote:
>
>
> On 31/08/2020 07:39, Srinivasa Rao Mandadapu wrote:
>> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>>
>> Adds bindings for lpass hdmi interface
>> which can support audio path over dp.
>>
>> Signed-off-by: Srinivasa Rao <srivasam@codeaurora.org>
>> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>> ---
>> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 51
>> ++++++++++++++++++++--
>> 1 file changed, 47 insertions(+), 4 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> index 09c9bd2..7c2ac0c 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> @@ -22,6 +22,7 @@ properties:
>> - qcom,lpass-cpu
>> - qcom,apq8016-lpass-cpu
>> - qcom,sc7180-lpass-cpu
>> + - qcom,sc7180-lpass-hdmi
>
> Why do we need a new compatible per interface, IMO, you should just
> use the existing compatible.
> Or please explain the reasons why we need this?
Two compatible strings are used because iommu's are different for I2S
and HDMI.
>
>> reg:
>> maxItems: 1
>> @@ -60,10 +61,12 @@ properties:
>> const: 0
>> patternProperties:
>> - "(^mi2s-[0-9a-f]$|mi2s)":
>> + "^dai@[0-9a-f]$":
>> type: object
>> - description: Required properties for each DAI
>> -
>> + description: |
>> + LPASS CPU dai node for each I2S device. Bindings of each node
>> + depends on the specific driver providing the functionality and
>> + properties.
>> properties:
>> reg:
>> maxItems: 1
>> @@ -145,6 +148,22 @@ allOf:
>> - iommus
>> - power-domains
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: qcom,sc7180-lpass-hdmi
>> + then:
>> + properties:
>> + clock-names:
>> + items:
>> + - const: pcnoc-sway-clk
>> + - const: audio-core
>> + - const: pcnoc-mport-clk
>> + required:
>> + - iommus
>> + - power-domains
>> +
>> examples:
>> - |
>> #include <dt-bindings/sound/sc7180-lpass.h>
>> @@ -178,12 +197,36 @@ examples:
>> #address-cells = <1>;
>> #size-cells = <0>;
>> /* Optional to set different MI2S SD lines */
>> - mi2s-primary@0 {
>> + dai@mi2s-primary {
>> reg = <MI2S_PRIMARY>;
>> qcom,playback-sd-lines = <1>;
>> qcom,capture-sd-lines = <0>;
>> };
>> };
>> +
>> + lpassh@62d87000 {
>> + compatible = "qcom,sc7180-lpass-hdmi";
>> +
>> + reg = <0 0x62d87000 0 0x68000>;
>> +
>> + iommus = <&apps_smmu 0x1032 0>;
>> +
>> + power-domains = <&lpass_hm 0>;
>> +
>> + clocks = <&gcc 131>,
>> + <&lpasscc 6>,
>> + <&lpasscc 10>;
>> +
>> + clock-names = "pcnoc-sway-clk", "audio-core",
>> + "pcnoc-mport-clk";
>> +
>> + #sound-dai-cells = <1>;
>> +
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + interrupts = <0 268 1>;
>> + };
>> };
>> ...
>>
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-09-04 11:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 6:39 [PATCH v3 0/5] Qualcomm's lpass-hdmi ASoC driver to support audio over dp port Srinivasa Rao Mandadapu
2020-08-31 6:39 ` [PATCH v3 1/5] ASoC: Add sc7180-lpass binding header hdmi define Srinivasa Rao Mandadapu
2020-08-31 6:39 ` [PATCH v3 2/5] ASoC: dt-bindings: Add dt binding for lpass hdmi Srinivasa Rao Mandadapu
2020-09-04 10:41 ` Srinivas Kandagatla
2020-09-04 11:02 ` Srinivasa Rao Mandadapu [this message]
2020-08-31 6:39 ` [PATCH v3 3/5] ASoC: qcom: Add support for lpass hdmi driver Srinivasa Rao Mandadapu
2020-09-01 7:36 ` Stephen Boyd
2020-09-03 9:29 ` Srinivasa Rao Mandadapu
2020-09-04 10:41 ` Srinivas Kandagatla
2020-09-04 11:21 ` Srinivasa Rao Mandadapu
[not found] ` <0101017458d94c82-96bbcff0-018e-4f5d-8273-7869c3599d32-000000@us-west-2.amazonses.com>
2020-09-04 11:24 ` Srinivas Kandagatla
2020-09-08 17:42 ` Srinivasa Rao Mandadapu
2020-08-31 6:39 ` [PATCH v3 4/5] ASoC: qcom: Add support for audio over DP Srinivasa Rao Mandadapu
2020-09-01 7:32 ` Stephen Boyd
2020-09-03 9:23 ` Srinivasa Rao Mandadapu
2020-08-31 6:39 ` [PATCH v3 5/5] ASoC: qcom: Optimise lpass variant structure Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101017458c84d4b-5236b891-5a8c-4edb-8ff3-bd1ceac88928-000000@us-west-2.amazonses.com \
--to=srivasam@codeaurora.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).