From: <ansuelsmth@gmail.com>
To: "'Ilia Mirkin'" <imirkin@alum.mit.edu>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: R: [PATCH] PCI: qcom: don't clear out PHY_REFCLK_USE_PAD
Date: Mon, 7 Sep 2020 03:18:41 +0200 [thread overview]
Message-ID: <018401d684b4$d31162c0$79342840$@gmail.com> (raw)
In-Reply-To: <20200907011238.3401-1-imirkin@alum.mit.edu>
> -----Messaggio originale-----
> Da: Ilia Mirkin <ibmirkin@gmail.com> Per conto di Ilia Mirkin
> Inviato: lunedì 7 settembre 2020 03:13
> A: ansuelsmth@gmail.com
> Cc: linux-arm-msm@vger.kernel.org; linux-pci@vger.kernel.org; Ilia Mirkin
> <imirkin@alum.mit.edu>
> Oggetto: [PATCH] PCI: qcom: don't clear out PHY_REFCLK_USE_PAD
>
> This makes PCIe links come up again on ifc6410 (apq8064).
>
> Fixes: de3c4bf6489 ("PCI: qcom: Add support for tx term offset for rev
> 2.1.0")
> Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
> ---
> drivers/pci/controller/dwc/pcie-qcom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c
> b/drivers/pci/controller/dwc/pcie-qcom.c
> index 3aac77a295ba..985b11cf6481 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -387,7 +387,6 @@ static int qcom_pcie_init_2_1_0(struct qcom_pcie
> *pcie)
>
> /* enable external reference clock */
> val = readl(pcie->parf + PCIE20_PARF_PHY_REFCLK);
> - val &= ~PHY_REFCLK_USE_PAD;
To make sure this doesn't brake ipq806x, why not limit the &= to the ipq806x
compatible like we do up in the code? (or use the use_pad only if apq8064
compatible is not detected, to address ipq8064-v2 added later?)
> val |= PHY_REFCLK_SSP_EN;
> writel(val, pcie->parf + PCIE20_PARF_PHY_REFCLK);
>
> --
> 2.26.2
next prev parent reply other threads:[~2020-09-07 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 1:12 [PATCH] PCI: qcom: don't clear out PHY_REFCLK_USE_PAD Ilia Mirkin
2020-09-07 1:18 ` ansuelsmth [this message]
2020-09-07 3:28 ` Ilia Mirkin
2020-09-14 22:02 ` R: " ansuelsmth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='018401d684b4$d31162c0$79342840$@gmail.com' \
--to=ansuelsmth@gmail.com \
--cc=imirkin@alum.mit.edu \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).