From: Rajendra Nayak <rnayak@codeaurora.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, skakit@codeaurora.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2
Date: Tue, 3 Aug 2021 10:03:16 +0530 [thread overview]
Message-ID: <029e9d59-ced7-af14-3e9e-2c7a62671abf@codeaurora.org> (raw)
In-Reply-To: <bb608936-65e0-ed68-9410-44a40faf2f61@codeaurora.org>
On 8/2/2021 6:06 PM, Rajendra Nayak wrote:
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>>> index 73225e3..f014cda 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>>> @@ -7,19 +7,12 @@
>>> /dts-v1/;
>>> -#include <dt-bindings/gpio/gpio.h>
>>> -#include <dt-bindings/iio/qcom,spmi-adc7-pmr735a.h>
I re-read your comment and I guess you meant this ^^^ header include
should stay too, and that's right, I seem to have wrongly moved it
to the common dtsi, will fix when I respost. thanks.
>>> -#include <dt-bindings/iio/qcom,spmi-adc7-pmr735b.h>
>>
>> Don't you want pmr735a include to stay here in SKU1 and not be included in the common one, as the hw is not present on sku2?
> []..
>>> #include "pmr735a.dtsi"
>
> Right, that's why this ^^^ include stays here and is not part of the common dtsi.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2021-08-03 4:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 9:39 [PATCH 0/2] Add DT files for sc7280 IDP2 board Rajendra Nayak
2021-08-02 9:39 ` [PATCH 1/2] dt-bindings: arm: qcom: Document qcom,sc7280-idp2 board Rajendra Nayak
2021-08-03 8:30 ` Stephen Boyd
2021-08-02 9:39 ` [PATCH 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2 Rajendra Nayak
2021-08-02 11:38 ` Konrad Dybcio
2021-08-02 12:36 ` Rajendra Nayak
2021-08-03 4:33 ` Rajendra Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=029e9d59-ced7-af14-3e9e-2c7a62671abf@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).