From: Amit Kucheria <amit.kucheria@linaro.org>
To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bjorn.andersson@linaro.org, swboyd@chromium.org,
sivaa@codeaurora.org, Andy Gross <agross@kernel.org>
Cc: Amit Kucheria <amit.kucheria@verdurent.com>, linux-pm@vger.kernel.org
Subject: [PATCH v3 4/9] drivers: thermal: tsens: Release device in success path
Date: Thu, 2 Jan 2020 20:24:29 +0530 [thread overview]
Message-ID: <0a969ecd48910dac4da81581eff45b5e579b2bfc.1577976221.git.amit.kucheria@linaro.org> (raw)
In-Reply-To: <cover.1577976221.git.amit.kucheria@linaro.org>
We don't currently call put_device in case of successfully initialising
the device.
Allow control to fall through so we can use same code for success and
error paths to put_device.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
drivers/thermal/qcom/tsens-common.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
index 1cbc5a6e5b4f..e84e94a6f1a7 100644
--- a/drivers/thermal/qcom/tsens-common.c
+++ b/drivers/thermal/qcom/tsens-common.c
@@ -687,8 +687,6 @@ int __init init_common(struct tsens_priv *priv)
tsens_enable_irq(priv);
tsens_debug_init(op);
- return 0;
-
err_put_device:
put_device(&op->dev);
return ret;
--
2.20.1
next prev parent reply other threads:[~2020-01-02 14:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 14:54 [PATCH v3 0/9] thermal: tsens: Handle critical interrupts Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 1/9] drivers: thermal: tsens: De-constify struct tsens_features Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 2/9] drivers: thermal: tsens: Pass around struct tsens_sensor as a constant Amit Kucheria
2020-01-02 19:16 ` Bjorn Andersson
2020-01-02 14:54 ` [PATCH v3 3/9] drivers: thermal: tsens: use simpler variables Amit Kucheria
2020-01-02 19:18 ` Bjorn Andersson
2020-01-02 14:54 ` Amit Kucheria [this message]
2020-01-02 19:29 ` [PATCH v3 4/9] drivers: thermal: tsens: Release device in success path Bjorn Andersson
2020-01-30 12:49 ` Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 5/9] drivers: thermal: tsens: Add critical interrupt support Amit Kucheria
2020-01-02 19:45 ` Bjorn Andersson
2020-01-30 12:07 ` Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 6/9] drivers: thermal: tsens: Add watchdog support Amit Kucheria
2020-01-02 19:55 ` Bjorn Andersson
2020-01-30 12:12 ` Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 7/9] arm64: dts: sdm845: thermal: Add critical interrupt support Amit Kucheria
2020-01-02 19:58 ` Bjorn Andersson
2020-01-02 14:54 ` [PATCH v3 8/9] arm64: dts: msm8996: " Amit Kucheria
2020-01-02 14:54 ` [PATCH v3 9/9] arm64: dts: msm8998: " Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a969ecd48910dac4da81581eff45b5e579b2bfc.1577976221.git.amit.kucheria@linaro.org \
--to=amit.kucheria@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sivaa@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).