From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05223C61DA4 for ; Fri, 27 Jan 2023 15:41:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234407AbjA0PlZ (ORCPT ); Fri, 27 Jan 2023 10:41:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231991AbjA0PlY (ORCPT ); Fri, 27 Jan 2023 10:41:24 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5013147438; Fri, 27 Jan 2023 07:41:20 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30RFeLIb015405; Fri, 27 Jan 2023 15:40:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=5gn0+SYkfxx8cxZnFQGwVZA6r5W4V8MyqQnERsnSs4k=; b=KJHp3rKwxkTIA8nDTmQBENudpLJKJwORZXMY7z4fCrKBh/5IwM2qKcIZnGFHcVrNjmzc JSLsD25TqXCwmbVi6gsqeqdvrfSVZSIwqBl8mER18b3Nv4jleidLIP/bbrPK7XGco2JF Ge3wxo7pqE6gtKmNB09PcA3JDaqXeTB/rpBuAt9ciw8ffQM6Bl8y6mmmb6pKZrzZi22v 5OoxblFdjZg/d6S4HT49X+YpaxMQd9ctTRklkiaukvQJg/PqL/0ZXx9lX0W1cRZqWYm8 XxqmJy9rstryE6wAlqUKUcLL4pi18S+m2hZRgIl16bMBzKide9YZaphqb2Mf7Cv5cKBW rA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ncheyr044-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Jan 2023 15:40:59 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30RFew9R031365 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Jan 2023 15:40:58 GMT Received: from [10.50.41.100] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 27 Jan 2023 07:40:50 -0800 Message-ID: <0b1df267-4f89-5b83-eb2e-351ea1596017@quicinc.com> Date: Fri, 27 Jan 2023 21:10:47 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/6] dt-bindings: clock: Add YAML schemas for QCOM A73 PLL Content-Language: en-US To: Konrad Dybcio , , , , , , , , , , , , , , , , , , , , CC: , , , , , , References: <20230113143647.14961-1-quic_devipriy@quicinc.com> <20230113143647.14961-2-quic_devipriy@quicinc.com> From: Devi Priya In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: G4mfedJwC_Bm_nflvfiujW809mmQHG3v X-Proofpoint-GUID: G4mfedJwC_Bm_nflvfiujW809mmQHG3v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-27_09,2023-01-27_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0 clxscore=1015 bulkscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301270145 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Thanks for taking time to review the patch! On 1/13/2023 8:35 PM, Konrad Dybcio wrote: > > > On 13.01.2023 15:36, devi priya wrote: >> Add schema for primary CPU PLL found on few Qualcomm platforms. >> >> Co-developed-by: Praveenkumar I >> Signed-off-by: Praveenkumar I >> Signed-off-by: devi priya >> --- > Doesn't this belong in Documentation/devicetree/bindings/clock/qcom,a53pll.yaml? > > It looks identical, so it may be as simple as adding your > new compatible there.. > As the name was specific to a53pll, added a new yaml for a73. Will add the a73 compatible in qcom,a53pll.yaml if that's accepted! > Konrad >> .../bindings/clock/qcom,a73pll.yaml | 52 +++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,a73pll.yaml >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,a73pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a73pll.yaml >> new file mode 100644 >> index 000000000000..a0e81094db8d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/qcom,a73pll.yaml >> @@ -0,0 +1,52 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/qcom,a73pll.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm A73 PLL clock >> + >> +maintainers: >> + - Bjorn Andersson >> + >> +description: >> + The A73 PLL on few Qualcomm platforms is the main CPU PLL used for >> + frequencies above 1GHz. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,ipq9574-a73pll >> + >> + reg: >> + maxItems: 1 >> + >> + '#clock-cells': >> + const: 0 >> + >> + clocks: >> + items: >> + - description: board XO clock >> + >> + clock-names: >> + items: >> + - const: xo >> + >> + operating-points-v2: true >> + >> +required: >> + - compatible >> + - reg >> + - '#clock-cells' >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + a73pll: clock@b116000 { >> + compatible = "qcom,ipq9574-a73pll"; >> + reg = <0x0b116000 0x40>; >> + #clock-cells = <0>; >> + clocks = <&xo_board_clk>; >> + clock-names = "xo"; >> + }; Best Regards, Devi Priya