From: Georgi Djakov <georgi.djakov@linaro.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk <linux-clk@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v2] clk: qcom: msm8916: Don't build by default
Date: Fri, 14 Jun 2019 17:08:38 +0300 [thread overview]
Message-ID: <0bc8b740-c421-8ecb-3716-b89ad73a243c@linaro.org> (raw)
In-Reply-To: <d654907d-a3a2-a00f-d6f5-3a34ae25ebcf@free.fr>
On 6/13/19 18:09, Marc Gonzalez wrote:
> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options
> built by default. Let's bring them back in line with the rest.
>
This change looks fine, but maybe we should enable these in defconfig?
Thanks,
Georgi
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
> Changes from v1:
> - Drop the default altogether, instead of changing it to 'default MSM_GCC_8916'
> ---
> drivers/clk/qcom/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index e1ff83cc361e..6461a1aa7325 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -21,7 +21,6 @@ if COMMON_CLK_QCOM
>
> config QCOM_A53PLL
> tristate "MSM8916 A53 PLL"
> - default ARCH_QCOM
> help
> Support for the A53 PLL on MSM8916 devices. It provides
> the CPU with frequencies above 1GHz.
> @@ -31,7 +30,6 @@ config QCOM_A53PLL
> config QCOM_CLK_APCS_MSM8916
> tristate "MSM8916 APCS Clock Controller"
> depends on QCOM_APCS_IPC || COMPILE_TEST
> - default ARCH_QCOM
> help
> Support for the APCS Clock Controller on msm8916 devices. The
> APCS is managing the mux and divider which feeds the CPUs.
>
next prev parent reply other threads:[~2019-06-14 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 15:09 [PATCH v2] clk: qcom: msm8916: Don't build by default Marc Gonzalez
2019-06-13 15:38 ` Bjorn Andersson
2019-06-14 14:08 ` Georgi Djakov [this message]
2019-06-24 12:25 ` Georgi Djakov
2019-06-24 13:26 ` [PATCH] clk: qcom: msm8916: Add 2 clk options in defconfig Marc Gonzalez
2019-06-24 13:57 ` Amit Kucheria
2019-07-03 14:00 ` Marc Gonzalez
2019-08-08 4:29 ` Stephen Boyd
2019-08-27 14:48 ` Niklas Cassel
2019-08-27 16:52 ` Bjorn Andersson
2019-08-08 4:30 ` [PATCH v2] clk: qcom: msm8916: Don't build by default Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc8b740-c421-8ecb-3716-b89ad73a243c@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).