From: Andrey Konovalov <andrey.konovalov@linaro.org>
To: Robert Foss <robert.foss@linaro.org>,
todor.too@gmail.com, agross@kernel.org,
bjorn.andersson@linaro.org, mchehab@kernel.org,
robh+dt@kernel.org, angelogioacchino.delregno@somainline.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
Rob Herring <robh@kernel.org>, Sakari Ailus <sakari.ailus@iki.fi>,
Nicolas Boichat <drinkcat@chromium.org>
Cc: Tomasz Figa <tfiga@chromium.org>,
Azam Sadiq Pasha Kapatrala Syed <akapatra@quicinc.com>,
Sarvesh Sridutt <Sarvesh.Sridutt@smartwirelesscompute.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jonathan Marek <jonathan@marek.ca>
Subject: Re: [PATCH v4 11/22] media: camss: Add support for CSIPHY hardware version Titan 170
Date: Mon, 8 Feb 2021 21:02:45 +0300 [thread overview]
Message-ID: <104e9dad-6819-119e-8f76-d83473374642@linaro.org> (raw)
In-Reply-To: <20210205104414.299732-12-robert.foss@linaro.org>
Hi Robert,
Thank you for your patchset!
On 05.02.2021 13:44, Robert Foss wrote:
> Add register definitions for version 170 of the Titan architecture
> and implement support for the CSIPHY subdevice.
>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> ---
> .../qcom/camss/camss-csiphy-3ph-1-0.c | 182 ++++++++++++++++--
> .../media/platform/qcom/camss/camss-csiphy.c | 66 +++++--
> drivers/media/platform/qcom/camss/camss.c | 74 +++++++
> 3 files changed, 290 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> index 97cb9de85031..148b8c50382c 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> @@ -47,6 +47,105 @@
> #define CSIPHY_3PH_CMN_CSI_COMMON_CTRL6_SHOW_REV_ID BIT(1)
> #define CSIPHY_3PH_CMN_CSI_COMMON_STATUSn(n) (0x8b0 + 0x4 * (n))
>
> +#define CSIPHY_DEFAULT_PARAMS 0
> +#define CSIPHY_LANE_ENABLE 1
> +#define CSIPHY_SETTLE_CNT_LOWER_BYTE 2
> +#define CSIPHY_SETTLE_CNT_HIGHER_BYTE 3
> +#define CSIPHY_DNP_PARAMS 4
> +#define CSIPHY_2PH_REGS 5
> +#define CSIPHY_3PH_REGS 6
> +
> +struct csiphy_reg_t {
> + int32_t reg_addr;
> + int32_t reg_data;
> + int32_t delay;
> + uint32_t csiphy_param_type;
> +};
> +
> +static const struct
> +csiphy_reg_t lane_regs_sdm845[5][14] = {
<snip>
> @@ -208,6 +294,66 @@ static void csiphy_lanes_enable(struct csiphy_device *csiphy,
>
> val = CSIPHY_3PH_LNn_MISC1_IS_CLKLANE;
> writel_relaxed(val, csiphy->base + CSIPHY_3PH_LNn_MISC1(l));
> +}
> +
> +static void csiphy_gen2_config_lanes(struct csiphy_device *csiphy,
> + u8 settle_cnt)
> +{
> + int i, l;
> + u32 val;
> +
> + for (l = 0; l < 5; l++) {
> + for (i = 0; i < 14; i++) {
> + struct csiphy_reg_t *r = &lane_regs_sdm845[l][i];
- this line gives me a compilation warning :
warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
306 | struct csiphy_reg_t *r = &lane_regs_sdm845[l][i];
Change it to:
const struct csiphy_reg_t *r = &lane_regs_sdm845[l][i];
?
Thanks,
Andrey
next prev parent reply other threads:[~2021-02-08 18:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 10:43 [PATCH v4 00/22] Add support for the SDM845 Camera Subsystem Robert Foss
2021-02-05 10:43 ` [PATCH v4 01/22] media: camss: Fix vfe_isr_comp_done() documentation Robert Foss
2021-02-05 10:43 ` [PATCH v4 02/22] media: camss: Fix vfe_isr comment typo Robert Foss
2021-02-05 10:43 ` [PATCH v4 03/22] media: camss: Replace trace_printk() with dev_dbg() Robert Foss
2021-02-06 4:38 ` Nicolas Boichat
2021-02-05 10:43 ` [PATCH v4 04/22] media: camss: Add CAMSS_845 camss version Robert Foss
2021-02-05 10:43 ` [PATCH v4 05/22] media: camss: Make ISPIF subdevice optional Robert Foss
2021-02-09 20:59 ` Andrey Konovalov
2021-02-10 10:43 ` Robert Foss
2021-02-05 10:43 ` [PATCH v4 07/22] media: camss: Add support for VFE hardware version Titan 170 Robert Foss
2021-02-10 19:36 ` Andrey Konovalov
2021-02-17 11:02 ` Robert Foss
2021-02-05 10:44 ` [PATCH v4 08/22] media: camss: Add missing format identifiers Robert Foss
2021-02-05 10:44 ` [PATCH v4 09/22] media: camss: Refactor CSID HW version support Robert Foss
2021-02-11 8:59 ` Andrey Konovalov
2021-02-15 10:23 ` Robert Foss
2021-02-05 10:44 ` [PATCH v4 10/22] media: camss: Add support for CSID hardware version Titan 170 Robert Foss
2021-02-05 10:44 ` [PATCH v4 11/22] media: camss: Add support for CSIPHY " Robert Foss
2021-02-06 1:15 ` kernel test robot
2021-02-08 18:02 ` Andrey Konovalov [this message]
2021-02-08 18:05 ` Robert Foss
2021-02-09 16:13 ` kernel test robot
2021-02-05 10:44 ` [PATCH v4 12/22] media: camss: Remove per VFE power domain toggling Robert Foss
2021-02-05 10:44 ` [PATCH v4 13/22] media: camss: Enable SDM845 Robert Foss
2021-02-05 10:44 ` [PATCH v4 14/22] dt-bindings: media: camss: Add qcom,msm8916-camss binding Robert Foss
2021-02-10 19:26 ` Rob Herring
2021-02-05 10:44 ` [PATCH v4 15/22] dt-bindings: media: camss: Add qcom,msm8996-camss binding Robert Foss
2021-02-10 19:32 ` Rob Herring
2021-02-05 10:44 ` [PATCH v4 16/22] dt-bindings: media: camss: Add qcom,sdm660-camss binding Robert Foss
2021-02-05 10:44 ` [PATCH v4 17/22] dt-bindings: media: camss: Add qcom,sdm845-camss binding Robert Foss
2021-02-10 19:33 ` Rob Herring
2021-02-05 10:44 ` [PATCH v4 18/22] MAINTAINERS: Change CAMSS documentation to use dtschema bindings Robert Foss
2021-02-05 10:44 ` [PATCH v4 19/22] media: dt-bindings: media: Remove qcom,camss documentation Robert Foss
2021-02-10 19:33 ` Rob Herring
2021-02-05 10:44 ` [PATCH v4 20/22] arm64: dts: sdm845: Add CAMSS ISP node Robert Foss
2021-02-05 10:44 ` [PATCH v4 21/22] arm64: dts: sdm845-db845c: Configure regulators for camss node Robert Foss
2021-02-05 10:44 ` [PATCH v4 22/22] arm64: dts: sdm845-db845c: Enable ov8856 sensor and connect to ISP Robert Foss
2021-02-10 20:14 ` [PATCH v4 00/22] Add support for the SDM845 Camera Subsystem Andrey Konovalov
2021-02-17 11:04 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=104e9dad-6819-119e-8f76-d83473374642@linaro.org \
--to=andrey.konovalov@linaro.org \
--cc=Sarvesh.Sridutt@smartwirelesscompute.com \
--cc=agross@kernel.org \
--cc=akapatra@quicinc.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=jonathan@marek.ca \
--cc=kholk11@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).