From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: "open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<linux-arm-msm@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Jonathan Marek <jonathan@marek.ca>,
Dikshita Agarwal <dikshita@codeaurora.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>
Subject: Re: [RESEND PATCH 0/4] Fixup clocks for venus on sm8250
Date: Wed, 3 Feb 2021 14:57:53 +0000 [thread overview]
Message-ID: <106dcea1-557a-a3cd-267a-43517815eaef@linaro.org> (raw)
In-Reply-To: <CAA8EJpquw_HBT+x=go_378_ZVqLiHmq7y9FvBEgoqESaTosy4Q@mail.gmail.com>
On 03/02/2021 14:25, Dmitry Baryshkov wrote:
> On Wed, 3 Feb 2021 at 14:53, Bryan O'Donoghue
> <bryan.odonoghue@linaro.org> wrote:
>>
>> - Adds some missing indices to the videocc index
>> - Adds videocc clock tree hirearchy for msv0
>> - Adds a regulator to power the videocc consistent with downstream
>>
>> Once done we can move on to enabling these clocks in the DTS and switch on
>> the venus.
>>
>> Bryan O'Donoghue (4):
>> dt-bindings: clock: Add missing SM8250 videoc clock indices
>> clk: qcom: videocc: Add sm8250 VIDEO_CC_MVS0_DIV_CLK_SRC
>> clk: qcom: videocc: Add sm8250 VIDEO_CC_MVS0_CLK
>> clk: qcom: videocc: Add gdsc mmcx-reg supply hook
>
> I remember now the old discussion about these two clocks
> (https://lore.kernel.org/linux-arm-msm/160092826778.310579.12225989905897101118@swboyd.mtv.corp.google.com/).
>
> Is the message. reported by Jonathan, solved by the mmcx-reg supply?
The stuck problem is a bandwidth problem not a regulator problem,
there's some internal clock dependency we don't have visibility of.
Both of these resolve,
Jonathan had a hack:
https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=tracking-qcomlt-sm8250-09-11-20%2bvenus-flto-simple-test2&id=d4bea74282d14244127a1e97766b6108ec68e22f
Dikshita proposed this instead, which, we will send out soon:
https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=tracking-qcomlt-sm8250-venus-integrated-sm8250&id=782202d611761e639af7e44d8344c0c098642b9f
> Also are these clocks necessary at all?
Eh well I'm not sure what happens if I try to dump the clocks but, this
is an accurate representation of what is done downstream so..
---
bod
next prev parent reply other threads:[~2021-02-03 14:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 11:54 [RESEND PATCH 0/4] Fixup clocks for venus on sm8250 Bryan O'Donoghue
2021-02-03 11:54 ` [PATCH 1/4] dt-bindings: clock: Add missing SM8250 videoc clock indices Bryan O'Donoghue
2021-02-03 11:54 ` [PATCH 2/4] clk: qcom: videocc: Add sm8250 VIDEO_CC_MVS0_DIV_CLK_SRC Bryan O'Donoghue
2021-02-03 11:54 ` [PATCH 3/4] clk: qcom: videocc: Add sm8250 VIDEO_CC_MVS0_CLK Bryan O'Donoghue
2021-02-03 11:54 ` [PATCH 4/4] clk: qcom: videocc: Add gdsc mmcx-reg supply hook Bryan O'Donoghue
2021-02-03 14:16 ` [RESEND PATCH 0/4] Fixup clocks for venus on sm8250 Dmitry Baryshkov
2021-02-03 14:25 ` Dmitry Baryshkov
2021-02-03 14:57 ` Bryan O'Donoghue [this message]
2021-02-04 10:50 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=106dcea1-557a-a3cd-267a-43517815eaef@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dikshita@codeaurora.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).