From: Iskren Chernev <iskren.chernev@gmail.com>
To: Nicolas Dechesne <nicolas.dechesne@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Sivaprakash Murugesan <sivaprak@codeaurora.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v1 2/2] mailbox: qcom: Add support for sm4125 sm6115 APCS IPC
Date: Sat, 28 Aug 2021 09:21:58 +0300 [thread overview]
Message-ID: <1085ae56-f164-27e3-0c00-f6b187eed1b3@gmail.com> (raw)
In-Reply-To: <CAP71WjxRpdoN9MMTH2Y2Xgc==tC2jWfm7X0_A1CrzZ40N_rg8Q@mail.gmail.com>
On 8/27/21 6:42 PM, Nicolas Dechesne wrote:
> On Tue, Jun 22, 2021 at 10:38 PM Iskren Chernev
> <iskren.chernev@gmail.com> wrote:
>>
>> SM4125 and SM6115, codename bengal, have APCS mailbox setup similar to
>> msm8998 and msm8916.
>
> subject and commit refer to SM4125/SM6115, but the diff below is about
> 4250/6115. I suppose it's a typo here, since 6115 is similar to 4250,
> not 4125, right?
Yes, you're correct. The issue was resolved in v2 submitted shorty after:
https://lkml.org/lkml/2021/6/27/167
>>
>> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
>> ---
>> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> index f25324d03842..1a4d8cca5881 100644
>> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> @@ -166,6 +166,8 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
>> { .compatible = "qcom,sc8180x-apss-shared", .data = &apps_shared_apcs_data },
>> { .compatible = "qcom,sdm660-apcs-hmss-global", .data = &sdm660_apcs_data },
>> { .compatible = "qcom,sdm845-apss-shared", .data = &apps_shared_apcs_data },
>> + { .compatible = "qcom,sm4250-apcs-hmss-global", .data = &sdm660_apcs_data },
>> + { .compatible = "qcom,sm6115-apcs-hmss-global", .data = &sdm660_apcs_data },
>> { .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data },
>> { .compatible = "qcom,sdx55-apcs-gcc", .data = &sdx55_apcs_data },
>> {}
>> --
>> 2.31.1
>>
next prev parent reply other threads:[~2021-08-28 6:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 20:37 [PATCH v1 1/2] dt-bindings: mailbox: qcom: Add SM6115, SM4250 APCS compatible Iskren Chernev
2021-06-22 20:37 ` [PATCH v1 2/2] mailbox: qcom: Add support for sm4125 sm6115 APCS IPC Iskren Chernev
2021-08-27 15:42 ` Nicolas Dechesne
2021-08-28 6:21 ` Iskren Chernev [this message]
2021-07-14 18:05 ` [PATCH v1 1/2] dt-bindings: mailbox: qcom: Add SM6115, SM4250 APCS compatible Rob Herring
2021-07-14 20:48 ` Iskren Chernev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1085ae56-f164-27e3-0c00-f6b187eed1b3@gmail.com \
--to=iskren.chernev@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.dechesne@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sivaprak@codeaurora.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).