* [PATCH] hwspinlock: qcom: Correct msb in regmap_field
@ 2015-06-26 21:47 bjorn
0 siblings, 0 replies; only message in thread
From: bjorn @ 2015-06-26 21:47 UTC (permalink / raw)
To: Andy Gross, Ohad Ben-Cohen; +Cc: linux-kernel, linux-arm-msm
From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
msb of the regmap_field was mistakenly given the value 32, to set all bits
in the regmap update mask; although incorrect this worked until 921cc294,
where the mask calculation was corrected.
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
drivers/hwspinlock/qcom_hwspinlock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c
index 93b62e0..c752447 100644
--- a/drivers/hwspinlock/qcom_hwspinlock.c
+++ b/drivers/hwspinlock/qcom_hwspinlock.c
@@ -123,7 +123,7 @@ static int qcom_hwspinlock_probe(struct platform_device *pdev)
for (i = 0; i < QCOM_MUTEX_NUM_LOCKS; i++) {
field.reg = base + i * stride;
field.lsb = 0;
- field.msb = 32;
+ field.msb = 31;
bank->lock[i].priv = devm_regmap_field_alloc(&pdev->dev,
regmap, field);
--
1.9.3 (Apple Git-50)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-26 21:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-26 21:47 [PATCH] hwspinlock: qcom: Correct msb in regmap_field bjorn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).