From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EB4BC433DB for ; Wed, 24 Mar 2021 06:50:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF17F619E0 for ; Wed, 24 Mar 2021 06:50:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235628AbhCXGtf (ORCPT ); Wed, 24 Mar 2021 02:49:35 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:10619 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235627AbhCXGtG (ORCPT ); Wed, 24 Mar 2021 02:49:06 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1616568546; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=oBQV+I9x0ZBz/5epdrA7py274iUh8GHJsi69OW1jM1E=; b=APmVMhw1gFzTEDwFHBkX/Ke8PJ3nUO2VD+hh0QS3AttwWqb2SEV282Ob66LXqb/ZH8qj0wCH f4Srqy+XHncis1uV1MKZThFX/RvH9bLdw8w3WzXsgmcWhyanyVoox+cc3xA/BoU+80WxGpnb 5zNcQTGkBW6w6rlRRpS040g6v8A= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 605ae0df4db3bb680173578d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 24 Mar 2021 06:49:03 GMT Sender: sibis=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7F716C43461; Wed, 24 Mar 2021 06:49:02 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sibis) by smtp.codeaurora.org (Postfix) with ESMTPSA id AF8D8C433C6; Wed, 24 Mar 2021 06:49:01 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 24 Mar 2021 12:19:01 +0530 From: Sibi Sankar To: Stephen Boyd Cc: Bjorn Andersson , p.zabel@pengutronix.de, robh+dt@kernel.org, agross@kernel.org, mani@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] arm64: dts: qcom: sc7280: Add nodes to boot WPSS In-Reply-To: <161653719350.3012082.12055201782488576903@swboyd.mtv.corp.google.com> References: <1615269111-25559-1-git-send-email-sibis@codeaurora.org> <1615269111-25559-7-git-send-email-sibis@codeaurora.org> <161567197220.1478170.12600358804299446135@swboyd.mtv.corp.google.com> <161653719350.3012082.12055201782488576903@swboyd.mtv.corp.google.com> Message-ID: <14476306c74356a747473e820d4067a6@codeaurora.org> X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-03-24 03:36, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-03-13 20:16:39) >> On Sat 13 Mar 15:46 CST 2021, Stephen Boyd wrote: >> >> > Quoting Sibi Sankar (2021-03-08 21:51:51) >> > > Add miscellaneous nodes to boot the Wireless Processor Subsystem on >> > >> > Maybe add (WPSS) after the name so we know they're related. >> > >> > > SC7280 SoCs. >> > > >> > > Signed-off-by: Sibi Sankar >> > > --- >> > > >> > > https://patchwork.kernel.org/project/linux-arm-msm/list/?series=438217 >> > > Depends on ipcc dt node enablement from ^^ >> > > >> > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 143 +++++++++++++++++++++++++++++++++++ >> > > 1 file changed, 143 insertions(+) >> > > >> > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> > > index 18637c369c1d..4f03c468df51 100644 >> > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> > > @@ -244,12 +251,131 @@ >> > > reg = <0 0x80000000 0 0>; >> > > }; >> > > >> > > + tcsr_mutex: hwlock { >> > > + compatible = "qcom,tcsr-mutex"; >> > > + syscon = <&tcsr_mutex_regs 0 0x1000>; >> > > + #hwlock-cells = <1>; >> > > + }; >> > >> > Is this node in the right place? I think the node above it is 'memory'? >> > In which case 'hwlock' comes before 'memory' alphabetically. >> > >> >> Thanks for spotting this, as it's no longer acceptable to have a >> standalone "syscon" node I was asked to rewrite the binding for this a >> few months ago. So the tcsr_mutex should now be represented with a reg >> under /soc. > > Oh nice, I wasn't aware. > >> > > + #interrupt-cells = <2>; >> > > + }; >> > > + }; >> > > + >> > > + smp2p-mpss { >> > > + compatible = "qcom,smp2p"; >> > > + qcom,smem = <435>, <428>; >> > > + interrupts-extended = <&ipcc IPCC_CLIENT_MPSS >> > > + IPCC_MPROC_SIGNAL_SMP2P >> > > + IRQ_TYPE_EDGE_RISING>; >> > > + mboxes = <&ipcc IPCC_CLIENT_MPSS >> > > + IPCC_MPROC_SIGNAL_SMP2P>; >> > > + >> > > + qcom,local-pid = <0>; >> > > + qcom,remote-pid = <1>; >> > > + >> > > + modem_smp2p_out: master-kernel { >> > > + qcom,entry-name = "master-kernel"; >> > > + #qcom,smem-state-cells = <1>; >> > > + }; >> > > + >> > > + modem_smp2p_in: slave-kernel { >> > > + qcom,entry-name = "slave-kernel"; >> > >> > Do these names need to have 'master' and 'slave' in them? We're trying >> > to avoid these terms. See Documentation/process/coding-style.rst Section >> > 4 naming. >> > >> >> They need to match the naming in the firmware, but I would welcome a >> future change to something in line with the coding style and simply >> more >> descriptive. >> > > Sibi can this be done? I think it's still pretty early days for the > firmware so hopefully the terms can be replaced with something > different. I'll discuss the ask with the modem fw team and get back. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.