From: Rajendra Nayak <rnayak@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>, Rob Herring <robh@kernel.org>
Cc: sboyd@kernel.org, andy.gross@linaro.org, ulf.hansson@linaro.org,
collinsd@codeaurora.org, mka@chromium.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/6] dt-bindings: power: Add qcom rpm power domain driver bindings
Date: Thu, 30 Aug 2018 12:01:42 +0530 [thread overview]
Message-ID: <1463d24b-481d-eecd-9e44-e7a5a993e5fc@codeaurora.org> (raw)
In-Reply-To: <20180704055757.4li26b6poxllmh2k@vireshk-i7>
On 7/4/2018 11:27 AM, Viresh Kumar wrote:
> On 03-07-18, 16:35, Rob Herring wrote:
>>> +qcom,level values specified in the OPP tables for RPMh power domains
>>> +should use the RPMH_REGULATOR_LEVEL_* constants from
>>> +<dt-bindings/power/qcom-rpmhpd.h>
>>> +
>>> + rpmhpd: power-controller {
>>> + compatible = "qcom,sdm845-rpmhpd";
>>> + #power-domain-cells = <1>;
>>> + operating-points-v2 = <&rpmhpd_opp_table>;
>>> + };
>>> +
>>> + rpmhpd_opp_table: opp-table {
>>> + compatible = "operating-points-v2-qcom-level";
>>> +
>>> + rpmhpd_opp_ret: opp1 {
>>> + qcom,level = <RPMH_REGULATOR_LEVEL_RETENTION>;
>>> + };
>>
>> I don't see the point in using the OPP binding here when you aren't
>> using *any* of the properties from it.
>
> Yeah, that's the case for now. But there are cases (as Stephen
> mentioned earlier [1]) where the voltage values (and maybe other
> values like current, etc) would be known and filled in DT. And that's
> why we all agreed to use OPP tables for PM domains as well, as these
> are really "operating performance points" of these PM domains.
Rob, are you fine with these bindings then?
If so, can we please have your reviewed-by?
next prev parent reply other threads:[~2018-08-30 6:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 4:52 [PATCH v4 0/6] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 1/6] dt-bindings: opp: Introduce qcom-opp bindings Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 2/6] dt-bindings: power: Add qcom rpm power domain driver bindings Rajendra Nayak
2018-07-03 22:35 ` Rob Herring
2018-07-04 5:57 ` Viresh Kumar
2018-08-30 6:31 ` Rajendra Nayak [this message]
2018-09-20 18:51 ` Rob Herring
2018-09-25 10:25 ` Rajendra Nayak
2018-09-25 19:43 ` Rob Herring
2018-10-04 8:36 ` Viresh Kumar
2018-10-04 15:18 ` Rob Herring
2018-10-04 19:17 ` Niklas Cassel
2018-10-04 22:17 ` Rob Herring
2018-10-05 20:44 ` Niklas Cassel
2018-10-15 12:47 ` [RFC PATCH] dt-bindings: opp: Extend qcom-opp bindings with properties needed for CPR Niklas Cassel
2018-10-22 5:45 ` Viresh Kumar
2018-11-05 23:17 ` Rob Herring
2018-11-09 16:39 ` Niklas Cassel
2018-11-20 4:12 ` Rajendra Nayak
2018-11-20 16:14 ` Niklas Cassel
2018-11-27 5:04 ` Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 3/6] soc: qcom: rpmpd: Add a Power domain driver to model corners Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 4/6] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 5/6] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2018-06-27 4:52 ` [PATCH v4 6/6] soc: qcom: rpmhpd: Add RPMh Power domain driver Rajendra Nayak
2018-08-30 6:35 ` [PATCH v4 0/6] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-08-30 8:21 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463d24b-481d-eecd-9e44-e7a5a993e5fc@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).