This patch series adds PDC Global and AOSS reset support on SC7180 SoCs. Sibi Sankar (4): dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs reset: qcom: aoss: Add support for SC7180 SoCs dt-bindings: reset: pdc: Add PDC Global binding for SC7180 SoCs reset: qcom: pdc: Add support for SC7180 SoCs Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 3 ++- Documentation/devicetree/bindings/reset/qcom,pdc-global.txt | 3 ++- drivers/reset/reset-qcom-aoss.c | 1 + drivers/reset/reset-qcom-pdc.c | 1 + 4 files changed, 6 insertions(+), 2 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Add SC7180 AOSS reset to the list of possible bindings. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt index 510c748656ec5..8f0bbdc6afd91 100644 --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt @@ -8,7 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: + Definition: must be one of: + "qcom,sc7180-aoss-cc" "qcom,sdm845-aoss-cc" - reg: -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Add AOSS reset support for SC7180 SoCs. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- drivers/reset/reset-qcom-aoss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/reset/reset-qcom-aoss.c b/drivers/reset/reset-qcom-aoss.c index 36db967504507..a400db93eb7d2 100644 --- a/drivers/reset/reset-qcom-aoss.c +++ b/drivers/reset/reset-qcom-aoss.c @@ -115,6 +115,7 @@ static int qcom_aoss_reset_probe(struct platform_device *pdev) } static const struct of_device_id qcom_aoss_reset_of_match[] = { + { .compatible = "qcom,sc7180-aoss-cc", .data = &sdm845_aoss_desc }, { .compatible = "qcom,sdm845-aoss-cc", .data = &sdm845_aoss_desc }, {} }; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Add SC7180 PDC global to the list of possible bindings. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- Documentation/devicetree/bindings/reset/qcom,pdc-global.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt index a62a492843e70..1f1ff280b2d69 100644 --- a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt @@ -8,7 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: + Definition: must be one of: + "qcom,sc7180-pdc-global" "qcom,sdm845-pdc-global" - reg: -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Add PCD Global support for SC7180 SoCs. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- drivers/reset/reset-qcom-pdc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/reset/reset-qcom-pdc.c b/drivers/reset/reset-qcom-pdc.c index ab74bccd4a5b5..d876e48f05524 100644 --- a/drivers/reset/reset-qcom-pdc.c +++ b/drivers/reset/reset-qcom-pdc.c @@ -106,6 +106,7 @@ static int qcom_pdc_reset_probe(struct platform_device *pdev) } static const struct of_device_id qcom_pdc_reset_of_match[] = { + { .compatible = "qcom,sc7180-pdc-global" }, { .compatible = "qcom,sdm845-pdc-global" }, {} }; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
On Wed, 2019-08-21 at 15:24 +0530, Sibi Sankar wrote:
> Add SC7180 AOSS reset to the list of possible bindings.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
> Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
> index 510c748656ec5..8f0bbdc6afd91 100644
> --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
> @@ -8,7 +8,8 @@ Required properties:
> - compatible:
> Usage: required
> Value type: <string>
> - Definition: must be:
> + Definition: must be one of:
> + "qcom,sc7180-aoss-cc"
> "qcom,sdm845-aoss-cc"
>
> - reg:
Does sc7180 have exactly the same resets (mss, camss, venus, gpu,
dispss, wcss, and lpass) as sdm845? If so, it could be considered
compatible, and the driver changes wouldn't be needed at all:
- Definition: must be:
+ Definition: must be one of:
+ "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc"
"qcom,sdm845-aoss-cc"
Is there a reason not to do this?
regards
Philipp
Hey Philipp, Thanks for the review! On 2019-08-21 16:02, Philipp Zabel wrote: > On Wed, 2019-08-21 at 15:24 +0530, Sibi Sankar wrote: >> Add SC7180 AOSS reset to the list of possible bindings. >> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> index 510c748656ec5..8f0bbdc6afd91 100644 >> --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt >> @@ -8,7 +8,8 @@ Required properties: >> - compatible: >> Usage: required >> Value type: <string> >> - Definition: must be: >> + Definition: must be one of: >> + "qcom,sc7180-aoss-cc" >> "qcom,sdm845-aoss-cc" >> >> - reg: > > Does sc7180 have exactly the same resets (mss, camss, venus, gpu, > dispss, wcss, and lpass) as sdm845? If so, it could be considered > compatible, and the driver changes wouldn't be needed at all: Yes they are identical both AOSS and PDC resets. > > - Definition: must be: > + Definition: must be one of: > + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" > > "qcom,sdm845-aoss-cc" > > Is there a reason not to do this? I am fine with ^^, will change them in v2. > > regards > Philipp -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.