From: Stephen Boyd <swboyd@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Sibi Sankar <sibis@codeaurora.org>,
Rishabh Bhatnagar <rishabhb@codeaurora.org>
Subject: Re: [PATCH v3 8/8] remoteproc: qcom: Introduce panic handler for PAS and ADSP
Date: Thu, 13 Feb 2020 18:43:04 -0800 [thread overview]
Message-ID: <158164818421.184098.5580195556346218701@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200211005059.1377279-9-bjorn.andersson@linaro.org>
Quoting Bjorn Andersson (2020-02-10 16:50:59)
> diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
> index 19f784adf91c..822881534d37 100644
> --- a/drivers/remoteproc/qcom_q6v5_adsp.c
> +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
> @@ -291,12 +291,20 @@ static void *adsp_da_to_va(struct rproc *rproc, u64 da, int len)
> return adsp->mem_region + offset;
> }
>
> +static unsigned int adsp_panic(struct rproc *rproc)
> +{
> + struct qcom_adsp *adsp = (struct qcom_adsp *)rproc->priv;
We don't need to cast from void. Please drop the cast.
> +
> + return qcom_q6v5_panic(&adsp->q6v5);
> +}
> +
> static const struct rproc_ops adsp_ops = {
> .start = adsp_start,
> .stop = adsp_stop,
> .da_to_va = adsp_da_to_va,
> .parse_fw = qcom_register_dump_segments,
> .load = adsp_load,
> + .panic = adsp_panic,
> };
>
> static int adsp_init_clock(struct qcom_adsp *adsp, const char **clk_ids)
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index d20ce3c62256..ac38624fb14d 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -242,12 +242,20 @@ static void *adsp_da_to_va(struct rproc *rproc, u64 da, int len)
> return adsp->mem_region + offset;
> }
>
> +static unsigned int adsp_panic(struct rproc *rproc)
> +{
> + struct qcom_adsp *adsp = (struct qcom_adsp *)rproc->priv;
Same.
> +
> + return qcom_q6v5_panic(&adsp->q6v5);
> +}
prev parent reply other threads:[~2020-02-14 2:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 0:50 [PATCH v3 0/8] remoteproc: qcom: post mortem debug support Bjorn Andersson
2020-02-11 0:50 ` [PATCH v3 1/8] dt-bindings: remoteproc: Add Qualcomm PIL info binding Bjorn Andersson
2020-02-14 2:24 ` Stephen Boyd
2020-02-14 4:58 ` Bjorn Andersson
2020-02-20 17:59 ` Mathieu Poirier
2020-02-11 0:50 ` [PATCH v3 2/8] remoteproc: qcom: Introduce driver to store pil info in IMEM Bjorn Andersson
2020-02-14 2:35 ` Stephen Boyd
2020-02-14 4:57 ` Bjorn Andersson
2020-02-20 19:01 ` Mathieu Poirier
2020-02-11 0:50 ` [PATCH v3 3/8] remoteproc: qcom: Update IMEM PIL info on load Bjorn Andersson
2020-02-20 20:42 ` Mathieu Poirier
2020-02-11 0:50 ` [PATCH v3 4/8] arm64: dts: qcom: qcs404: Add IMEM and PIL info region Bjorn Andersson
2020-02-14 2:37 ` Stephen Boyd
2020-02-14 4:40 ` Bjorn Andersson
2020-02-20 20:47 ` Mathieu Poirier
2020-02-11 0:50 ` [PATCH v3 5/8] arm64: dts: qcom: sdm845: " Bjorn Andersson
2020-02-20 20:48 ` Mathieu Poirier
2020-02-11 0:50 ` [PATCH v3 6/8] remoteproc: Introduce "panic" callback in ops Bjorn Andersson
2020-02-13 16:00 ` Arnaud POULIQUEN
2020-02-14 2:41 ` Stephen Boyd
2020-02-14 4:37 ` Bjorn Andersson
2020-02-11 0:50 ` [PATCH v3 7/8] remoteproc: qcom: q6v5: Add common panic handler Bjorn Andersson
2020-02-11 0:50 ` [PATCH v3 8/8] remoteproc: qcom: Introduce panic handler for PAS and ADSP Bjorn Andersson
2020-02-14 2:43 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158164818421.184098.5580195556346218701@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=rishabhb@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).