From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BAD0C10F27 for ; Tue, 10 Mar 2020 18:11:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D718222D9 for ; Tue, 10 Mar 2020 18:11:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HLZpkhv2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726641AbgCJSLA (ORCPT ); Tue, 10 Mar 2020 14:11:00 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:36611 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbgCJSLA (ORCPT ); Tue, 10 Mar 2020 14:11:00 -0400 Received: by mail-pl1-f194.google.com with SMTP id g12so5758576plo.3 for ; Tue, 10 Mar 2020 11:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=zsKib0GqynNKua7iAWBmqWACz2JHoCf4kZ0aZVNqsbQ=; b=HLZpkhv24sgfXCUG4fX3MIo+Au43vnAfit8xW0HNvvMmiJukq0nlQHasooY+XayfsH bPDPnsiOCYxI3bQG7B0B/K/8wZgxUxSAH4dukVWksxBstHWMBiG0AFIKs5cR34NvIry0 7XpgDvrSHWGOiZ1HYqWiFG8XWhw20Xr6INzc4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=zsKib0GqynNKua7iAWBmqWACz2JHoCf4kZ0aZVNqsbQ=; b=BiYKhitfzEbciMAdQNihwwsig7PHNFBwoNcYmXsXx4whJfN23SvO+lFZWvXjK/ZsHn G5lA01kJiYJtLyM/EXKo0Euxxomgg3bcQYKNNVH58OGWk+9G0pEAib0BZOoD6SSF4L/w M8FuvsZPaNYGPAK2HpBtkaXgfRIk6wQ4tX1/ZdWdBNkUMdBxlRyuHw5t2UD45+Rc7Uw3 iebDnyMyo2O6b7Q0Ia2kQ76GuF+A9HGA6IZHxgDxPfaa8Sr//QMQXvyfeQykd2cazm/h YO5bM7ZJvfNsBJwnnJgUdfsS9o72xQcmHBfAmLC6rxb/dz8am6JLsoI3r+pjoSmqLimn RTrA== X-Gm-Message-State: ANhLgQ1VPyhsoo0JTzlp+dQ9eg6OgOw/fqYMZU3SHoGO2KdFWbdj5fRH dXNwyCHi+VO7PuNZ1Iiz2Qy7K11pyOw= X-Google-Smtp-Source: ADFU+vvi/bGVsNtmguU66YqisKjD03wxFAZstCH06FyZW30xgi/xqHri6gRo4LARgAX/p5XdWG7+gQ== X-Received: by 2002:a17:902:ab8f:: with SMTP id f15mr22089420plr.280.1583863857702; Tue, 10 Mar 2020 11:10:57 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id e2sm14277262pgv.81.2020.03.10.11.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 11:10:57 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200310063338.3344582-4-bjorn.andersson@linaro.org> References: <20200310063338.3344582-1-bjorn.andersson@linaro.org> <20200310063338.3344582-4-bjorn.andersson@linaro.org> Subject: Re: [PATCH v4 3/5] remoteproc: qcom: Update PIL relocation info on load From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mathieu Poirier To: Andy Gross , Bjorn Andersson , Ohad Ben-Cohen , Rob Herring Date: Tue, 10 Mar 2020 11:10:56 -0700 Message-ID: <158386385637.149997.10680456822295964075@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Bjorn Andersson (2020-03-09 23:33:36) > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qco= m_q6v5_adsp.c > index e953886b2eb7..d5cdff942535 100644 > --- a/drivers/remoteproc/qcom_q6v5_adsp.c > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c > @@ -164,10 +166,18 @@ static int qcom_adsp_shutdown(struct qcom_adsp *ads= p) > static int adsp_load(struct rproc *rproc, const struct firmware *fw) > { > struct qcom_adsp *adsp =3D (struct qcom_adsp *)rproc->priv; > + int ret; > + > + ret =3D qcom_mdt_load_no_init(adsp->dev, fw, rproc->firmware, 0, > + adsp->mem_region, adsp->mem_phys, > + adsp->mem_size, &adsp->mem_reloc); > + if (ret) > + return ret; > =20 > - return qcom_mdt_load_no_init(adsp->dev, fw, rproc->firmware, 0, > - adsp->mem_region, adsp->mem_phys, adsp->mem_= size, > - &adsp->mem_reloc); > + /* Failures only affect post mortem debugging, so ignore return v= alue */ > + qcom_pil_info_store(adsp->info_name, adsp->mem_reloc, adsp->mem_s= ize); If the return value was void then the comment wouldn't be necessary and it would be self documenting as such. Can we do that?