From: Stephen Boyd <swboyd@chromium.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Douglas Anderson <dianders@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rafael.j.wysocki@intel.com
Cc: mka@chromium.org, mkshah@codeaurora.org, evgreen@chromium.org,
Douglas Anderson <dianders@chromium.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/5] soc: qcom: rpmh-rsc: We aren't notified of our own failure w/ NOTIFY_BAD
Date: Thu, 23 Apr 2020 19:38:24 -0700 [thread overview]
Message-ID: <158769590404.135303.4049749400685142607@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200422145408.v4.2.I1927d1bca2569a27b2d04986baf285027f0818a2@changeid>
Quoting Douglas Anderson (2020-04-22 14:55:00)
> When a PM Notifier returns NOTIFY_BAD it doesn't get called with
> CPU_PM_ENTER_FAILED. It only get called for CPU_PM_ENTER_FAILED if
> someone else (further down the notifier chain) returns NOTIFY_BAD.
>
> Handle this case by taking our CPU out of the list of ones that have
> entered PM. Without this it's possible we could detect that the last
> CPU went down (and we would flush) even if some CPU was alive. That's
> not good since our flushing routines currently assume they're running
> on the last CPU for mutual exclusion.
>
> Fixes: 985427f997b6 ("soc: qcom: rpmh: Invoke rpmh_flush() for dirty caches")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reported-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2020-04-24 2:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 21:54 [PATCH v4 1/5] soc: qcom: rpmh-rsc: Corrently ignore CPU_CLUSTER_PM notifications Douglas Anderson
2020-04-22 21:55 ` [PATCH v4 2/5] soc: qcom: rpmh-rsc: We aren't notified of our own failure w/ NOTIFY_BAD Douglas Anderson
2020-04-23 4:48 ` Maulik Shah
2020-04-24 2:38 ` Stephen Boyd [this message]
2020-04-24 2:41 ` Stephen Boyd
2020-04-22 21:55 ` [PATCH v4 4/5] soc: qcom: rpmh-rsc: Simplify locking by eliminating the per-TCS lock Douglas Anderson
2020-04-24 2:48 ` Stephen Boyd
2020-04-24 16:47 ` Doug Anderson
2020-04-22 21:55 ` [PATCH v4 5/5] soc: qcom: rpmh-rsc: Remove the pm_lock Douglas Anderson
2020-04-24 3:59 ` Stephen Boyd
2020-04-23 4:45 ` [PATCH v4 1/5] soc: qcom: rpmh-rsc: Corrently ignore CPU_CLUSTER_PM notifications Maulik Shah
2020-04-23 16:19 ` Doug Anderson
2020-04-24 2:38 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158769590404.135303.4049749400685142607@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).