Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
@ 2020-05-20  3:56 Rakesh Pillai
  2020-05-20 17:50 ` Sibi Sankar
  2020-05-21 16:19 ` Evan Green
  0 siblings, 2 replies; 7+ messages in thread
From: Rakesh Pillai @ 2020-05-20  3:56 UTC (permalink / raw)
  To: devicetree; +Cc: linux-arm-kernel, linux-kernel, linux-arm-msm, Rakesh Pillai

Add device node for the ath10k SNOC platform driver probe
and add resources required for WCN3990 on sc7180 soc.

Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
---
Changes from v10:
- Corrected the position of wifi node, as per address
- Removed the wlan_fw_mem from reserved memory, since
  its already added as reserved memory in board DT file.
---
 arch/arm64/boot/dts/qcom/sc7180-idp.dts |  7 +++++++
 arch/arm64/boot/dts/qcom/sc7180.dtsi    | 22 ++++++++++++++++++++++
 2 files changed, 29 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 4e9149d..38b102e 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -389,6 +389,13 @@
 	};
 };
 
+&wifi {
+	status = "okay";
+	wifi-firmware {
+		iommus = <&apps_smmu 0xc2 0x1>;
+	};
+};
+
 /* PINCTRL - additions to nodes defined in sc7180.dtsi */
 
 &qspi_clk {
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 6b12c60..da79f8f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -2811,6 +2811,28 @@
 
 			#freq-domain-cells = <1>;
 		};
+
+		wifi: wifi@18800000 {
+			compatible = "qcom,wcn3990-wifi";
+			reg = <0 0x18800000 0 0x800000>;
+			reg-names = "membase";
+			iommus = <&apps_smmu 0xc0 0x1>;
+			interrupts =
+				<GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH /* CE0 */ >,
+				<GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH /* CE1 */ >,
+				<GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH /* CE2 */ >,
+				<GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH /* CE3 */ >,
+				<GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH /* CE4 */ >,
+				<GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH /* CE5 */ >,
+				<GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH /* CE6 */ >,
+				<GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH /* CE7 */ >,
+				<GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH /* CE8 */ >,
+				<GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH /* CE9 */ >,
+				<GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH /* CE10 */>,
+				<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH /* CE11 */>;
+			memory-region = <&wlan_mem>;
+			status = "disabled";
+		};
 	};
 
 	thermal-zones {
-- 
2.7.4

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
  2020-05-20  3:56 [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Rakesh Pillai
@ 2020-05-20 17:50 ` Sibi Sankar
  2020-05-21 16:19 ` Evan Green
  1 sibling, 0 replies; 7+ messages in thread
From: Sibi Sankar @ 2020-05-20 17:50 UTC (permalink / raw)
  To: Rakesh Pillai
  Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
	linux-kernel-owner

On 2020-05-20 09:26, Rakesh Pillai wrote:
> Add device node for the ath10k SNOC platform driver probe
> and add resources required for WCN3990 on sc7180 soc.
> 
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> Changes from v10:
> - Corrected the position of wifi node, as per address
> - Removed the wlan_fw_mem from reserved memory, since
>   its already added as reserved memory in board DT file.

Reviewed-by: Sibi Sankar <sibis@codeaurora.org>

> ---
>  arch/arm64/boot/dts/qcom/sc7180-idp.dts |  7 +++++++
>  arch/arm64/boot/dts/qcom/sc7180.dtsi    | 22 ++++++++++++++++++++++
>  2 files changed, 29 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 4e9149d..38b102e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -389,6 +389,13 @@
>  	};
>  };
> 
> +&wifi {
> +	status = "okay";
> +	wifi-firmware {
> +		iommus = <&apps_smmu 0xc2 0x1>;
> +	};
> +};
> +
>  /* PINCTRL - additions to nodes defined in sc7180.dtsi */
> 
>  &qspi_clk {
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 6b12c60..da79f8f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -2811,6 +2811,28 @@
> 
>  			#freq-domain-cells = <1>;
>  		};
> +
> +		wifi: wifi@18800000 {
> +			compatible = "qcom,wcn3990-wifi";
> +			reg = <0 0x18800000 0 0x800000>;
> +			reg-names = "membase";
> +			iommus = <&apps_smmu 0xc0 0x1>;
> +			interrupts =
> +				<GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH /* CE0 */ >,
> +				<GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH /* CE1 */ >,
> +				<GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH /* CE2 */ >,
> +				<GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH /* CE3 */ >,
> +				<GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH /* CE4 */ >,
> +				<GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH /* CE5 */ >,
> +				<GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH /* CE6 */ >,
> +				<GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH /* CE7 */ >,
> +				<GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH /* CE8 */ >,
> +				<GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH /* CE9 */ >,
> +				<GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH /* CE10 */>,
> +				<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH /* CE11 */>;
> +			memory-region = <&wlan_mem>;
> +			status = "disabled";
> +		};
>  	};
> 
>  	thermal-zones {

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
  2020-05-20  3:56 [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Rakesh Pillai
  2020-05-20 17:50 ` Sibi Sankar
@ 2020-05-21 16:19 ` Evan Green
  2020-06-17 22:45   ` Evan Green
  1 sibling, 1 reply; 7+ messages in thread
From: Evan Green @ 2020-05-21 16:19 UTC (permalink / raw)
  To: Rakesh Pillai
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-arm Mailing List, LKML, linux-arm-msm

On Tue, May 19, 2020 at 8:57 PM Rakesh Pillai <pillair@codeaurora.org> wrote:
>
> Add device node for the ath10k SNOC platform driver probe
> and add resources required for WCN3990 on sc7180 soc.
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>

Reviewed-by: Evan Green <evgreen@chromium.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
  2020-05-21 16:19 ` Evan Green
@ 2020-06-17 22:45   ` Evan Green
  2020-06-20 14:44     ` Rakesh Pillai
  2020-06-21 19:06     ` Bjorn Andersson
  0 siblings, 2 replies; 7+ messages in thread
From: Evan Green @ 2020-06-17 22:45 UTC (permalink / raw)
  To: Rakesh Pillai, Bjorn Andersson
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-arm Mailing List, LKML, linux-arm-msm

On Thu, May 21, 2020 at 9:19 AM Evan Green <evgreen@chromium.org> wrote:
>
> On Tue, May 19, 2020 at 8:57 PM Rakesh Pillai <pillair@codeaurora.org> wrote:
> >
> > Add device node for the ath10k SNOC platform driver probe
> > and add resources required for WCN3990 on sc7180 soc.
> >
> > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>
> Reviewed-by: Evan Green <evgreen@chromium.org>

Looks like this never landed anywhere. Is it blocked on something?
-Evan

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
  2020-06-17 22:45   ` Evan Green
@ 2020-06-20 14:44     ` Rakesh Pillai
  2020-06-21 19:06     ` Bjorn Andersson
  1 sibling, 0 replies; 7+ messages in thread
From: Rakesh Pillai @ 2020-06-20 14:44 UTC (permalink / raw)
  To: 'Evan Green', 'Bjorn Andersson'
  Cc: 'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE
	BINDINGS', 'linux-arm Mailing List', 'LKML',
	'linux-arm-msm'

Hi Evan,
All the dependent patches are already merged.

Thanks,
Rakesh Pillai.

> -----Original Message-----
> From: Evan Green <evgreen@chromium.org>
> Sent: Thursday, June 18, 2020 4:15 AM
> To: Rakesh Pillai <pillair@codeaurora.org>; Bjorn Andersson
> <bjorn.andersson@linaro.org>
> Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; linux-arm Mailing List <linux-arm-
> kernel@lists.infradead.org>; LKML <linux-kernel@vger.kernel.org>; linux-
> arm-msm <linux-arm-msm@vger.kernel.org>
> Subject: Re: [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN
> module device node
> 
> On Thu, May 21, 2020 at 9:19 AM Evan Green <evgreen@chromium.org>
> wrote:
> >
> > On Tue, May 19, 2020 at 8:57 PM Rakesh Pillai <pillair@codeaurora.org>
> wrote:
> > >
> > > Add device node for the ath10k SNOC platform driver probe
> > > and add resources required for WCN3990 on sc7180 soc.
> > >
> > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> >
> > Reviewed-by: Evan Green <evgreen@chromium.org>
> 
> Looks like this never landed anywhere. Is it blocked on something?
> -Evan


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
  2020-06-17 22:45   ` Evan Green
  2020-06-20 14:44     ` Rakesh Pillai
@ 2020-06-21 19:06     ` Bjorn Andersson
  2020-06-22  9:16       ` Rakesh Pillai
  1 sibling, 1 reply; 7+ messages in thread
From: Bjorn Andersson @ 2020-06-21 19:06 UTC (permalink / raw)
  To: Evan Green
  Cc: Rakesh Pillai,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-arm Mailing List, LKML, linux-arm-msm

On Wed 17 Jun 15:45 PDT 2020, Evan Green wrote:

> On Thu, May 21, 2020 at 9:19 AM Evan Green <evgreen@chromium.org> wrote:
> >
> > On Tue, May 19, 2020 at 8:57 PM Rakesh Pillai <pillair@codeaurora.org> wrote:
> > >
> > > Add device node for the ath10k SNOC platform driver probe
> > > and add resources required for WCN3990 on sc7180 soc.
> > >
> > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> >
> > Reviewed-by: Evan Green <evgreen@chromium.org>
> 
> Looks like this never landed anywhere. Is it blocked on something?

I remember waiting for some reviews, but I see those are in place. Then
as I was applying this I saw that a v12 had shown up, with regulators.

So, I applied v12.

Thanks,
Bjorn

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
  2020-06-21 19:06     ` Bjorn Andersson
@ 2020-06-22  9:16       ` Rakesh Pillai
  0 siblings, 0 replies; 7+ messages in thread
From: Rakesh Pillai @ 2020-06-22  9:16 UTC (permalink / raw)
  To: 'Bjorn Andersson', 'Evan Green'
  Cc: 'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE
	BINDINGS', 'linux-arm Mailing List', 'LKML',
	'linux-arm-msm'



> -----Original Message-----
> From: Bjorn Andersson <bjorn.andersson@linaro.org>
> Sent: Monday, June 22, 2020 12:36 AM
> To: Evan Green <evgreen@chromium.org>
> Cc: Rakesh Pillai <pillair@codeaurora.org>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; linux-arm
> Mailing List <linux-arm-kernel@lists.infradead.org>; LKML <linux-
> kernel@vger.kernel.org>; linux-arm-msm <linux-arm-
> msm@vger.kernel.org>
> Subject: Re: [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN
> module device node
> 
> On Wed 17 Jun 15:45 PDT 2020, Evan Green wrote:
> 
> > On Thu, May 21, 2020 at 9:19 AM Evan Green <evgreen@chromium.org>
> wrote:
> > >
> > > On Tue, May 19, 2020 at 8:57 PM Rakesh Pillai <pillair@codeaurora.org>
> wrote:
> > > >
> > > > Add device node for the ath10k SNOC platform driver probe
> > > > and add resources required for WCN3990 on sc7180 soc.
> > > >
> > > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> > >
> > > Reviewed-by: Evan Green <evgreen@chromium.org>
> >
> > Looks like this never landed anywhere. Is it blocked on something?
> 
> I remember waiting for some reviews, but I see those are in place. Then
> as I was applying this I saw that a v12 had shown up, with regulators.
> 
> So, I applied v12.


Thanks Bjorn.


> 
> Thanks,
> Bjorn


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20  3:56 [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Rakesh Pillai
2020-05-20 17:50 ` Sibi Sankar
2020-05-21 16:19 ` Evan Green
2020-06-17 22:45   ` Evan Green
2020-06-20 14:44     ` Rakesh Pillai
2020-06-21 19:06     ` Bjorn Andersson
2020-06-22  9:16       ` Rakesh Pillai

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git