From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10BA3C433E7 for ; Sat, 10 Oct 2020 00:54:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9E5D22251 for ; Sat, 10 Oct 2020 00:54:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OY0/mr8F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729107AbgJJAxF (ORCPT ); Fri, 9 Oct 2020 20:53:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729125AbgJJAj4 (ORCPT ); Fri, 9 Oct 2020 20:39:56 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0E0BC0613D8 for ; Fri, 9 Oct 2020 17:39:54 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id q123so8269168pfb.0 for ; Fri, 09 Oct 2020 17:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=F5/qH043zEuGeatUEpHVuXqbPsOkFkmiSQ+O0T+kgNI=; b=OY0/mr8FkN7fSU5zYf/x9oHuQmQYqIF3NZteXcH28gcYzCSf5+MT4y49z8aUjOjqBv lha3BSSjRHKCiX9eo/5oSgg3mzkB27HCrpXBOvuU8f2fnOZ/YBvY6fZmuOjh//FvW6kL O7ol4CBYBbsd7yhoCo0gpIi6aDg3ajTAUIbi4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=F5/qH043zEuGeatUEpHVuXqbPsOkFkmiSQ+O0T+kgNI=; b=pazTUMz41gmmyDwhSTg1MOKdu6nsfHqcutRTRtc3fU7VTlqVBKik8esi49nqRb+J9h y62uxzMNaDemYJp0JGmg8TStvxFiCY3ljXAUybB6003SmbUBzQ75DBIkl08W39CFvklF YASkEr5FVdXFiHv581HCdE1sqLsgEC268zQmO6HGVLih73yHogAQ23HOZIy1MNzBfxLs 4DqZe0Y4CxQsBdvfTmpABNZESfRNmkOWwSmHkz7fdgNlqYH0M9ln8JirjlTVKU976B70 +xedQ4IksEcwpjyOSxhztLG0oIcYVQ0YKoYZUNL8yjOeHjS3YayY/OHIXz93OIV3Bzfp THFw== X-Gm-Message-State: AOAM530Cd7vTC0JERQGq0y5rLXl7ieQbZPI2GOSDguskwVzSg+bqiuMT 5PyjKq1b2+KMFsnOaR0NOel0TaKOgHFjIQ== X-Google-Smtp-Source: ABdhPJzE8O8QFPi4at6QU9iWZO8FPHQ/o/AIuLT2fpJQ9Opv/aO707p4HOAAU7mEUsaVWB5etuwZ6g== X-Received: by 2002:aa7:9009:0:b029:154:f822:27c9 with SMTP id m9-20020aa790090000b0290154f82227c9mr14645151pfo.48.1602290394214; Fri, 09 Oct 2020 17:39:54 -0700 (PDT) Received: from chromium.org ([2620:15c:202:201:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id m4sm11572541pgv.87.2020.10.09.17.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 17:39:53 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20201008155154.2.I7b22281453b8a18ab16ef2bfd4c641fb1cc6a92c@changeid> References: <20201008225235.2035820-1-dianders@chromium.org> <20201008155154.2.I7b22281453b8a18ab16ef2bfd4c641fb1cc6a92c@changeid> Subject: Re: [PATCH 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race" From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, Douglas Anderson , Andy Gross , Mukesh Savaliya , linux-kernel@vger.kernel.org To: Akash Asthana , Bjorn Andersson , Douglas Anderson , Wolfram Sang Date: Fri, 09 Oct 2020 17:39:52 -0700 Message-ID: <160229039221.310579.11648298092136196056@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Douglas Anderson (2020-10-08 15:52:34) > This reverts commit 02b9aec59243c6240fc42884acc958602146ddf6. >=20 > As talked about in the patch ("soc: qcom: geni: More properly switch > to DMA mode"), swapping the order of geni_se_setup_m_cmd() and > geni_se_xx_dma_prep() can sometimes cause corrupted transfers. Thus > we traded one problem for another. Now that we've debugged the > problem further and fixed the geni helper functions to more disable > FIFO interrupts when we move to DMA mode we can revert it and end up > with (hopefully) zero problems! >=20 > To be explicit, the patch ("soc: qcom: geni: More properly switch > to DMA mode") is a prerequisite for this one. >=20 > Fixes: 02b9aec59243 ("i2c: i2c-qcom-geni: Fix DMA transfer race") > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd